Re: [PATCH 2/5] configure: check for python cffi module

[Tomi Ollila <tomi.ollila@iki.fi>]

On Sun, Nov 03 2019, David Bremner wrote:

> This is needed to build the new python bindings
> ---
>  configure | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>
> diff --git a/configure b/configure
> index 3c148e12..300591fe 100755
> --- a/configure
> +++ b/configure
> @@ -671,6 +671,15 @@ if [ $have_python -eq 0 ]; then
>      errors=$((errors + 1))
>  fi
>  
> +printf "Checking for python cffi... "
> +if "$python" -c 'import cffi' >/dev/null 2>&1; then
> +    printf "Yes.\n"
> +    have_python_cffi=1;

trailing ;

> +else
> +    printf "No.\n"
> +    have_python_cffi=0;

ditto :)


otherwise tolerable =D

> +fi
> +
>  printf "Checking for valgrind development files... "
>  if pkg-config --exists valgrind; then
>      printf "Yes.\n"
> @@ -1223,6 +1232,9 @@ HAVE_GETLINE = ${have_getline}
>  # building/testing ruby bindings.
>  HAVE_RUBY_DEV = ${have_ruby_dev}
>  
> +# Is the python cffi package available?
> +HAVE_PYTHON_CFFI = ${have_python_cffi}
> +
>  # Whether the strcasestr function is available (if not, then notmuch will
>  # build its own version)
>  HAVE_STRCASESTR = ${have_strcasestr}
> @@ -1376,6 +1388,9 @@ NOTMUCH_RUBY=${RUBY}
>  # building/testing ruby bindings.
>  NOTMUCH_HAVE_RUBY_DEV=${have_ruby_dev}
>  
> +# Is the python cffi package available?
> +NOTMUCH_HAVE_PYTHON_CFFI=${have_python_cffi}
> +
>  # Platform we are run on
>  PLATFORM=${platform}
>  EOF
> -- 
> 2.24.0.rc1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch