From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id kKLDBOm7/l+NIgAA0tVLHw (envelope-from ) for ; Wed, 13 Jan 2021 09:22:49 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id iAJrAOm7/l+rHwAAbx9fmQ (envelope-from ) for ; Wed, 13 Jan 2021 09:22:49 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 41E6B9404FD for ; Wed, 13 Jan 2021 09:22:48 +0000 (UTC) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 54FBE29ED1; Wed, 13 Jan 2021 04:22:40 -0500 (EST) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [185.185.170.37]) by mail.notmuchmail.org (Postfix) with ESMTPS id 13CF129E75 for ; Wed, 13 Jan 2021 04:13:29 -0500 (EST) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id A769B1B0024D; Wed, 13 Jan 2021 11:13:26 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1610529206; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IlTtAO1zlp8cg0LvlYcRoSzr2srNAqPdac+koYwJopg=; b=wFB36ah3Y6jKpoXVbH/SVlVQzqy4QXaQ4Qlcqln3geNMuworIm61imMA/bpAdkL0TQEkvu Vl8GxYD5gy+FnaHt1JdxpxSshKMaFpOKlZJtj6M55mXoaFlIOe/njNVdDYy0x8wUvlNhRs uixZnDSo9cEL8aGc4crI/fNTruS3T6xC2LG7rcx6MsXgkIXXOVip6uBKQMrtI1QHzbHaZh 0IzF5hDULFShwXPeEE6EHD0CNOpW4IVAvZXsATu+82HBbXWleZXactrC0xRekwzWJnfLHV VaQSzmOOWYqbC52vc/ungMI8kQ9d2wdR2vhoT1bWFa/H70j/dbcOCakGsto9QA== From: Tomi Ollila To: Jonas Bernoulli , notmuch@notmuchmail.org Subject: Re: [PATCH v2 00/36] [emacs] Add outline headings and switch to lexical scope In-Reply-To: <20210110140112.25930-1-jonas@bernoul.li> References: <20201214162401.19569-1-jonas@bernoul.li> <20210110140112.25930-1-jonas@bernoul.li> User-Agent: Notmuch/0.31.3+83~gfe438d5 (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1610529206; a=rsa-sha256; cv=none; b=dNCu1RL2FAKK0EWR8nm9docCxtx+Kls02LbzcoVPIbEdByG7f2Wk57S+WTiLtCJV2kabZ/ b4DkTGEIcFMNi1u8vv3+UfeFj1eCsEhqd7mkEeqAoIr7/P5S+qA1+wISOs7Gll1zlIJsD8 jMZNR4ypeWQDh//v5vJTGuS/WZhiTXIr0ibiBrUwPZVMSWHQki1HPtZQFrRI4z3FO9c/kX EBgAFIHw0foJe9gU3PX4T2jdSJ3+4qheQ6+hvNeaw35nDIBZyErPQwrKeTmD6qPY6LZ9zW Lp+RLk9SkXG/TEzJ08T2wPo9GyKG6Uff6NpdK2M3BU3Ca8ixMWWkBgj1KLaiIw== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1610529206; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IlTtAO1zlp8cg0LvlYcRoSzr2srNAqPdac+koYwJopg=; b=k8oZtxJiYVR6NsUVBzWdtWaUckIXgpooRaiWaSBSAJNwyfftMuuVk6dJE7b8ML2EU0nSUu k0XQ90l49d4GrvMflkTEZLrKGUJsvdEcB2yPipmMifFbIK3d0WYOaiI/w4a0f9Paxf9Yje UGLGViGFOBQSTWceJbpn066Oe6C61tbBYzF1gwFHk3y2XkLZmjE5RyOMRB6sMb4nCwE3GR WCao2GmxnV27W75kbK1vL7V7SR9kjq1U391dF9QvxurG3gjPSA9n0XfoTsgYl6ar6ORw8Y 7HgCF92gVUXrwtHW8RV2ZQzICDVK+j5Cur4Qyb7cHUpJc0ZB3l/dOIJcHJ0eCA== Message-ID-Hash: QFPY6FDBRYSE2RZV7MQL7QCROJ53RQWY X-Message-ID-Hash: QFPY6FDBRYSE2RZV7MQL7QCROJ53RQWY X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 0.92 Authentication-Results: aspmx1.migadu.com; dkim=fail (body hash did not verify) header.d=iki.fi header.s=lahtoruutu header.b=wFB36ah3; arc=reject (signature check failed: fail, {[1] = sig:iki.fi:reject}); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 41E6B9404FD X-Spam-Score: 0.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: hMBaf4Vfxx0O On Sun, Jan 10 2021, Jonas Bernoulli wrote: > This fixes a minor whitespace bug that Tomi notices in (1). > > This also adds for commits, two of them in response to a concern > raised by Tomi, who didn't "see enough point for requiring subr-x > just [for string-empty-p]", which I agree with: > > 2) Changes how `cl-lib' and `pcase' are required. I did that first > because I want to do it the same way as for `subr-x'. > > 3) Require `subr-x', so that we can use it without having to worry > whether we have now reached the threshold where it becomes > justified to require an additional library. > > Personally I consider this library to be part of core elisp > libraries, and wish it were autoloaded like, say `subr'. I am > not the only one with that opinion and some other package is > bound to load this very small library anyways, so we might as > well benefit from the goodies that it provides too. > > The remaining two new commits (4,5) I have already submitted earlier > in a separate thread. Unfortunately they did not get merged or even > just discussed so far, so I am including them here again. Series looks good (also patch 35/36 (*)). It was easy to review, although took time to browse through all small changes. Marked ready using *-notmuch::needs-review in notmuch show buffer. I have been using the series for couple of days now (and sending this email having the changes in use) -- it feels like this starts faster than previously but that must be just a feeling. Tomi (*) I would even suggest "the best thing", but then it would need more discussion... > > Cheers, > Jonas > > Jonas Bernoulli (36): > emacs: use setq instead of set > emacs: sanitize dedicated widget action/notify functions > emacs: define new notmuch-search-item widget type > emacs: notmuch-start-notmuch: remove backward compatibility code > emacs: notmuch-start-notmuch-error-sentinel: assert buffer is alive > emacs: notmuch-start-notmuch-sentinel: assert buffer is alive > emacs: notmuch-start-notmuch: avoid storing process buffer twice > emacs: avoid passing around some redundant information > emacs: avoid killing process buffer when process is still alive > emacs: make headings outline-minor-mode compatible > emacs: use lexical-bindings in all libraries > emacs: deal with unused lexical arguments and variables > emacs: notmuch-tag--get-formats: silence byte-compiler > emacs: inline notmuch-sexp-eof into only caller > emacs: notmuch-wash-region-to-button: remove unused MSG argument > emacs: silence compiler wrt notmuch-show-insert-part-text/plain > emacs: define notmuch-message-queued-tag-changes as buffer-local > emacs: notmuch-message-apply-queued-tag-changes: cosmetics > emacs: notmuch-wash.el: require diff-mode at beginning of code > emacs: notmuch-mua-prompt-for-sender: don't force Ido on users > emacs: notmuch-mua.el: move all options into "Options" section > emacs: notmuch-crypto-status-button-type: fix potential bug > 1 emacs: various cosmetic improvements > emacs: various comment improvements > emacs: various doc-string improvements > emacs: remove variable notmuch-search-disjunctive-regexp > emacs: define a few variables as automatically buffer-local > emacs: notmuch-search-stash-thread-id: use notmuch-search-query-string > emacs: reorder notmuch.el a bit > emacs: avoid unnecessary let-bindings > 2 emacs: improve how cl-lib and pcase are required > 3 emacs: make subr-x available in all libraries > emacs: use string-empty-p > emacs: notmuch-tree-get-match: No longer define as command > 4 emacs: allow opting out of notmuch's address completion > 5 emacs: notmuch-address-expand-name: use the actual initial-input > > emacs/coolj.el | 14 +- > emacs/make-deps.el | 2 +- > emacs/notmuch-address.el | 103 +++++++------- > emacs/notmuch-company.el | 3 - > emacs/notmuch-compat.el | 4 +- > emacs/notmuch-crypto.el | 14 +- > emacs/notmuch-draft.el | 27 +++- > emacs/notmuch-hello.el | 229 +++++++++++++++--------------- > emacs/notmuch-jump.el | 18 +-- > emacs/notmuch-lib.el | 199 +++++++++++++------------- > emacs/notmuch-maildir-fcc.el | 114 +++++++-------- > emacs/notmuch-message.el | 25 ++-- > emacs/notmuch-mua.el | 124 +++++++++-------- > emacs/notmuch-parser.el | 22 ++- > emacs/notmuch-print.el | 16 ++- > emacs/notmuch-query.el | 21 ++- > emacs/notmuch-show.el | 130 ++++++++++------- > emacs/notmuch-tag.el | 103 ++++++++------ > emacs/notmuch-tree.el | 61 ++++---- > emacs/notmuch-wash.el | 54 ++++---- > emacs/notmuch.el | 261 ++++++++++++++++++----------------- > emacs/rstdoc.el | 2 +- > test/test-lib.el | 4 +- > 23 files changed, 813 insertions(+), 737 deletions(-) > > -- > 2.29.1 > _______________________________________________ > notmuch mailing list -- notmuch@notmuchmail.org > To unsubscribe send an email to notmuch-leave@notmuchmail.org