From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id IBcQLCiOq2ANKQEAgWs5BA (envelope-from ) for ; Mon, 24 May 2021 13:29:44 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id WGa/JyiOq2CNLwAAB5/wlQ (envelope-from ) for ; Mon, 24 May 2021 11:29:44 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 138DF1AEF7 for ; Mon, 24 May 2021 13:29:44 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id EFE842AA7A; Mon, 24 May 2021 07:29:36 -0400 (EDT) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [185.185.170.37]) by mail.notmuchmail.org (Postfix) with ESMTPS id 274FA27DF6 for ; Mon, 24 May 2021 07:29:33 -0400 (EDT) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 10C881B00121; Mon, 24 May 2021 14:29:30 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1621855770; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vCirxkGkrp7xDgO5aJEM59FXLG4CJaDECI9KybxzJPA=; b=jV8dDtrgCNwyk/1M4cyZh30XzaISpwSkK7s3AXMw8YFDooLYuzYeDaHRzBgmyLiYRvKKTM nG7NKaArCjsiV4XRjH4bwBAmsleS2HuswuUM3dqgDhhtCncOSQRIwiazrPbmGAM8H5ENiE HwUfz2AAuPWO7yyeIzDnAbx+m8UVtWYAp0EvNFuAlm3LloJrzwoUYcCbmD3JiqdEMtfGSg lmreKtXQm39B2KEuo4OjiZctGrmPtcnXwp3YWF9lPdTekCWcpyp316/xfMCk/a7X2NxfU0 a0CuagrdqdDFEeYqZaQSqp1GXTLHdcAjVAt3UhcyxJVHKCxPgQcUcGFJoDkU2A== From: Tomi Ollila To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH 1/2] make _alloc_notmuch static In-Reply-To: <20210524000829.2660860-1-david@tethera.net> References: <20210524000829.2660860-1-david@tethera.net> User-Agent: Notmuch/0.32+21~gfdddd4c (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1621855770; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vCirxkGkrp7xDgO5aJEM59FXLG4CJaDECI9KybxzJPA=; b=OIXeogee0WQugI9ylTADtm7ti8JNj8QWx2VTc6MI/yJLgJROSOGd7MgGpJapgRzgUF8ViQ adDEWM5Zfsa5MH0hFbpxL5EAY4gvG5MqKfAcFFaivUIQXZliPRCAsyR5oyE2zXOWkd6WaT wg/FbIfDMGvKSQ+anANSYs9FmpWDkrIIuB7FsLcBN5QeHGHW1ll2EnxLSuX554gaw2eCKg GbWgm/7vCq2Xn/4dmPo+oHtqpaBN9PCxpjQfSRtu7y0k0By8xVeBtll1AJKuamRYWOYB/d sOJivfR/S9T06XyZbit0ywwW+2g8c7L54gs4KixOjtyseh+zKIuB62nWt9cTTA== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1621855770; a=rsa-sha256; cv=none; b=mmj1NzBJFkQuREbNG5s4MQFH32ZPtGxq32PvDlo7ZIIMpo3xfWW0hLAXXtaz2RukvcnmOh kFnD3O5JwX6dQ5YrZGxwwqHJ8m1Ag23KSnMUvq6lCtgRh/CsnCBt55jeqnfh9RgaK9ULp9 9zYULx66eteQnkTgTANGG/FBe9PVDgPqQxTcU1T4af/dCq603RYAEbiSALZpyOAScaouZE QXDKcI+4VZpvQ9L0b9H9U8v4poEnXuywTI63l2flOHy1Xru9BTC3VzD5zCuKhJQkBFpqpc wMS0/qvDbB2MUNIMmeIe4wv3DxtChqRCIuxEhJoqCY5w+ImXqszCO9Hnb5sHqg== Message-ID-Hash: IKT4KOFHUXNWNQMID62LA6B3BW765CLG X-Message-ID-Hash: IKT4KOFHUXNWNQMID62LA6B3BW765CLG X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1621855784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=wFxAWKd4Sv+FKfAyE5SHHMXtLqC40UnlmCE/A/TyoiI=; b=fexXHb7tAm8zTcvu3x8qOnI9q4cJmwfwaJ/npS6VfLX0JGNiKgrmGClkicuk9c7/bksNgv FWCz32wbuPjPCQ7E2Dheva9epf/4buCmAEpN2PUo8AXYHtlPaHOFp99bcfgM0uhEVkVYjR nH+MzH/JEF4IOs5nv3fbnJDsBsAovFJLU7nzCjOQ3Z1DF9JdERW3Eswd/wG8N4SNOr0XcH jV2eKL7Ku6W1Ly9dP94nbj4SMs/lmYY4zuK5OzlioWuhA8Z4n+0Z1ni27QMKjUMsbJzEEA dVZywfKDVvjx7wrFCisxqofkjcmwlNaZYbdMpd/vYK269I21YkkFKKHtpnnykA== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1621855784; a=rsa-sha256; cv=fail; b=aWJlH134yKdx+z9VM3Yw9jH3HUSwjc51FrfdYcV2+qAZJWGBaxyEJ70vLLa+zUnWSVsaxC sjMbE7Rieryo+cLHsB/Ma2KJuOoyr1z+osH4+UPpb/fk4w+YxdThV57KoctYReqt3mRjR0 RDU/G1FHZTtGlqL1xw3PZtqg8MOa7ePU+n3QYCSn1twdgpRukeNspF6RWtkfoEd8QoP0Mx WvwfFPVNm30LbbDl4hna6KP6/4GTbsy8msg2G8G3VopcdnBb7SkLw/H84YNQWo2BWRY7+U sC0M6MB9+TEE5OPujjTa04N0YEbTAQiPJnL/MupnjU1384tex9GECIZfVgdtRw== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=jV8dDtrg; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: 0.94 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=jV8dDtrg; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 138DF1AEF7 X-Spam-Score: 0.94 X-Migadu-Scanner: scn0.migadu.com X-TUID: +JPoOOkmkRm/ On Sun, May 23 2021, David Bremner wrote: > It is not used outside this file, so being extern seems like an oversight > --- > lib/open.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/open.cc b/lib/open.cc > index 1ca69665..bf166e15 100644 > --- a/lib/open.cc > +++ b/lib/open.cc > @@ -242,7 +242,7 @@ _choose_database_path (void *ctx, > return NOTMUCH_STATUS_SUCCESS; > } > > -notmuch_database_t * > +static notmuch_database_t * > _alloc_notmuch () > { > notmuch_database_t *notmuch; could also add static to _maybe_load_config_from_database() in the same file (open.cc) and to _notmuch_message_remove_indexed_terms() in message.cc