From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] make _alloc_notmuch static
Date: Mon, 24 May 2021 14:29:28 +0300 [thread overview]
Message-ID: <m27djoxtd3.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20210524000829.2660860-1-david@tethera.net>
On Sun, May 23 2021, David Bremner wrote:
> It is not used outside this file, so being extern seems like an oversight
> ---
> lib/open.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/open.cc b/lib/open.cc
> index 1ca69665..bf166e15 100644
> --- a/lib/open.cc
> +++ b/lib/open.cc
> @@ -242,7 +242,7 @@ _choose_database_path (void *ctx,
> return NOTMUCH_STATUS_SUCCESS;
> }
>
> -notmuch_database_t *
> +static notmuch_database_t *
> _alloc_notmuch ()
> {
> notmuch_database_t *notmuch;
could also add static to _maybe_load_config_from_database()
in the same file (open.cc) and to
_notmuch_message_remove_indexed_terms() in message.cc
next prev parent reply other threads:[~2021-05-24 11:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 0:08 [PATCH 1/2] make _alloc_notmuch static David Bremner
2021-05-24 0:08 ` [PATCH 2/2] lib/message: use passed database for error handling David Bremner
2021-05-24 11:29 ` Tomi Ollila [this message]
2021-06-07 23:32 ` [PATCH 1/2] make _alloc_notmuch static David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m27djoxtd3.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).