unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] test/libconfig: make indexing more consistent
Date: Sun, 20 Jun 2021 23:04:11 +0300	[thread overview]
Message-ID: <m27diob8w4.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20210619133116.2392932-1-david@tethera.net>

On Sat, Jun 19 2021, David Bremner wrote:

> The other tests have converted to two digit decimal, the commit does
> the same to the remaining test that was printing out indices in hex.

LGTM.

Tomi

> ---
>  test/T590-libconfig.sh | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/test/T590-libconfig.sh b/test/T590-libconfig.sh
> index bc7298f8..189381f7 100755
> --- a/test/T590-libconfig.sh
> +++ b/test/T590-libconfig.sh
> @@ -713,23 +713,23 @@ cat c_head2 - c_tail <<'EOF' | test_C ${MAIL_DIR} %NULL% %NULL%
>  	 key < NOTMUCH_CONFIG_LAST;
>  	 key = (notmuch_config_key_t)(key + 1)) {
>  	const char *val = notmuch_config_get (db, key);
> -	printf("%x: '%s'\n", key, val ? val : "NULL" );
> +	printf("%02d: '%s'\n", key, val ? val : "NULL" );
>      }
>  }
>  EOF
>  cat <<'EOF' >EXPECTED
>  == stdout ==
> -0: 'MAIL_DIR'
> -1: 'MAIL_DIR'
> -2: 'MAIL_DIR/.notmuch/hooks'
> -3: 'MAIL_DIR/.notmuch/backups'
> -4: 'foo;bar;fub'
> -5: 'unread;inbox'
> -6: 'sekrit_junk'
> -7: 'true'
> -8: 'test_suite@notmuchmail.org'
> -9: 'test_suite_other@notmuchmail.org;test_suite@otherdomain.org'
> -a: 'Notmuch Test Suite'
> +00: 'MAIL_DIR'
> +01: 'MAIL_DIR'
> +02: 'MAIL_DIR/.notmuch/hooks'
> +03: 'MAIL_DIR/.notmuch/backups'
> +04: 'foo;bar;fub'
> +05: 'unread;inbox'
> +06: 'sekrit_junk'
> +07: 'true'
> +08: 'test_suite@notmuchmail.org'
> +09: 'test_suite_other@notmuchmail.org;test_suite@otherdomain.org'
> +10: 'Notmuch Test Suite'
>  == stderr ==
>  EOF
>  test_expect_equal_file EXPECTED OUTPUT
> -- 
> 2.30.2
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org

  reply	other threads:[~2021-06-20 20:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-19 13:31 [PATCH] test/libconfig: make indexing more consistent David Bremner
2021-06-20 20:04 ` Tomi Ollila [this message]
2021-06-21 10:07 ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m27diob8w4.fsf@guru.guru-group.fi \
    --to=tomi.ollila@iki.fi \
    --cc=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).