NEWS: add entries for the changes in the python bindings

NEWS: add entries for the changes in the python bindings

[Justus Winter]

This patch series adds a section for the python binding changes to the
NEWS file.

Cheers,
Justus

[PATCH 1/3] NEWS: add entry for python error handling fix

[Justus Winter]

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
---
 NEWS |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/NEWS b/NEWS
index 2acdce5..bee6f2e 100644
--- a/NEWS
+++ b/NEWS
@@ -47,6 +47,16 @@ New functions
   notmuch_query_add_tag_exclude supports the new tag exclusion
   feature.
 
+Python bindings changes
+-----------------------
+
+Fix error handling in python bindings.
+
+  The python bindings in 0.11 failed to detect NULL pointers being
+  returned from libnotmuch functions and thus failed to raise
+  exceptions to indicate the error condition. Any subsequent calls
+  into libnotmuch caused segmentation faults.
+
 Build fixes
 -----------
 
-- 
1.7.8.3

[PATCH 2/3] NEWS: add entry for python 3.2 compatibility

[Justus Winter]

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
---
 NEWS |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/NEWS b/NEWS
index bee6f2e..71644ff 100644
--- a/NEWS
+++ b/NEWS
@@ -57,6 +57,10 @@ Fix error handling in python bindings.
   exceptions to indicate the error condition. Any subsequent calls
   into libnotmuch caused segmentation faults.
 
+Python 3.2 compatibility
+
+  The python bindings are now compatible with both python 2.x and 3.2.
+
 Build fixes
 -----------
 
-- 
1.7.8.3

[PATCH 3/3] NEWS: add entry for the improved unicode handling in the python bindings

[Justus Winter]

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
---
 NEWS |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/NEWS b/NEWS
index 71644ff..132efe8 100644
--- a/NEWS
+++ b/NEWS
@@ -61,6 +61,12 @@ Python 3.2 compatibility
 
   The python bindings are now compatible with both python 2.x and 3.2.
 
+Added missing unicode conversions
+
+  Python strings have to be encoded to and decoded from utf-8 when
+  calling libnotmuch functions. Porting the bindings to python 3.2
+  revealed a few function calls that were missing these conversions.
+
 Build fixes
 -----------
 
-- 
1.7.8.3

Re: NEWS: add entries for the changes in the python bindings

[Tomi Ollila]

On Sun, 29 Jan 2012 18:08:50 +0100, Justus Winter <4winter@informatik.uni-hamburg.de> wrote:
> This patch series adds a section for the python binding changes to the
> NEWS file.

LGTM -- although knowing which python 2.x versions works would
be nice to know. At least tests pass using python 2.5 but how
complete are those tests...

> 
> Cheers,
> Justus

Tomi

Re: NEWS: add entries for the changes in the python bindings

[Tomi Ollila]

On Sun, 29 Jan 2012 18:08:50 +0100, Justus Winter <4winter@informatik.uni-hamburg.de> wrote:
> This patch series adds a section for the python binding changes to the
> NEWS file.

I marked patches 2/3 and 3/3 stale as git-am doesn't accept those anymore
on top of 2c6710e3ba22f5af6e5813dad8bee732e6c5d02c.

> 
> Cheers,
> Justus

Tomi

Re: NEWS: add entries for the changes in the python bindings

[Justus Winter]

Quoting Tomi Ollila (2012-02-05 22:19:16)
>On Sun, 29 Jan 2012 18:08:50 +0100, Justus Winter <4winter@informatik.uni-hamburg.de> wrote:
>> This patch series adds a section for the python binding changes to the
>> NEWS file.
>
>I marked patches 2/3 and 3/3 stale as git-am doesn't accept those anymore
>on top of 2c6710e3ba22f5af6e5813dad8bee732e6c5d02c.

come on... these are patches for the NEWS file, it's as much work for
me to merge these as for anyone else ;)

Justus

Re: NEWS: add entries for the changes in the python bindings

[Tomi Ollila]

On Mon, 06 Feb 2012 00:21:58 -0000, Justus Winter <4winter@informatik.uni-hamburg.de> wrote:
> Quoting Tomi Ollila (2012-02-05 22:19:16)
> >On Sun, 29 Jan 2012 18:08:50 +0100, Justus Winter <4winter@informatik.uni-hamburg.de> wrote:
> >> This patch series adds a section for the python binding changes to the
> >> NEWS file.
> >
> >I marked patches 2/3 and 3/3 stale as git-am doesn't accept those anymore
> >on top of 2c6710e3ba22f5af6e5813dad8bee732e6c5d02c.
> 
> come on... these are patches for the NEWS file, it's as much work for
> me to merge these as for anyone else ;)

Yes.... I just happened to add the 'notmuch::patch' tag without checking
that the patches apply (and those appeared to ready list)... So I did
not have much choice for the time being...


> Justus

Tomi