From: Tomi Ollila <tomi.ollila@iki.fi>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/5] Fix adjacent and overlapping termpos
Date: Sat, 21 Jun 2014 22:20:49 +0300 [thread overview]
Message-ID: <m261juvzla.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1402886434-16169-1-git-send-email-amdragon@mit.edu>
On Mon, Jun 16 2014, Austin Clements <amdragon@MIT.EDU> wrote:
> This series fixes several related bugs that caused indexing to
> generate adjacent and overlapping term positions, which caused
> messages to incorrectly match phrase queries. This obsoletes (and
> fixes) the known-broken tests from
> id:1400359552-10928-1-git-send-email-amdragon@mit.edu.
The code looks good to me and tests pass. +1
Tomi
next prev parent reply other threads:[~2014-06-21 19:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 2:40 [PATCH 0/5] Fix adjacent and overlapping termpos Austin Clements
2014-06-16 2:40 ` [PATCH 1/5] test: Fix from/to search test queries Austin Clements
2014-06-16 2:40 ` [PATCH 2/5] test: Add search tests for combined name/address queries Austin Clements
2014-06-16 2:40 ` [PATCH 3/5] lib: Index name and address of from/to headers as a phrase Austin Clements
2014-06-16 2:40 ` [PATCH 4/5] test: Known-broken test for overlapping/adjacent termpos Austin Clements
2014-06-16 2:40 ` [PATCH 5/5] lib: Separate all phrases indexed by _notmuch_message_gen_terms Austin Clements
2014-06-18 21:11 ` David Bremner
2014-06-21 19:20 ` Tomi Ollila [this message]
2014-06-22 10:02 ` [PATCH 0/5] Fix adjacent and overlapping termpos David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m261juvzla.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=amdragon@MIT.EDU \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).