From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>,
Michal Sojka <sojkam1@fel.cvut.cz>,
notmuch@notmuchmail.org
Subject: Re: [PATCH v2 06/10] cli: Introduce "notmuch address" command
Date: Tue, 04 Nov 2014 11:40:04 +0200 [thread overview]
Message-ID: <m261ev483v.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <87d293mp9c.fsf@maritornes.cs.unb.ca>
On Tue, Nov 04 2014, David Bremner <david@tethera.net> wrote:
> Michal Sojka <sojkam1@fel.cvut.cz> writes:
>
>> +{
>> + local cur prev words cword split
>> + _init_completion -s || return
>> +
>> + $split &&
>> + case "${prev}" in
>> + --format)
>> + COMPREPLY=( $( compgen -W "json sexp text text0" -- "${cur}" ) )
>> + return
>> + ;;
>> + --output)
>> + COMPREPLY=( $( compgen -W "sender recipients" -- "${cur}" ) )
>> + return
>> + ;;
>> + --sort)
>> + COMPREPLY=( $( compgen -W "newest-first oldest-first" -- "${cur}" ) )
>> + return
>> + ;;
>> + --exclude)
>> + COMPREPLY=( $( compgen -W "true false flag all" -- "${cur}" ) )
>> + return
>> + ;;
>> + esac
>> +
>> + ! $split &&
>> + case "${cur}" in
>> + -*)
>> + local options="--format= --output= --sort= --exclude="
>> + compopt -o nospace
>> + COMPREPLY=( $(compgen -W "$options" -- ${cur}) )
>> + ;;
>> + *)
>> + _notmuch_search_terms
>> + ;;
>> + esac
>> +}
>> +
>
> I am reminded that we have no tests for shell completion stuff, which
> seems pretty fragile.
That is what users are for -- i.e. the completion testing monkies ! ;D
>
>> +
>> + ``--format=``\ (**json**\ \|\ **sexp**\ \|\ **text**\ \|\ **text0**)
>> + Presents the results in either JSON, S-Expressions, newline
>> + character separated plain-text (default), or null character
>> + separated plain-text (compatible with **xargs(1)** -0 option
>> + where available).
>> +
>> + ``--format-version=N``
>> + Use the specified structured output format version. This is
>> + intended for programs that invoke **notmuch(1)** internally. If
>> + omitted, the latest supported version will be used.
>> +
>
>
> I wonder if at some point we should have a notmuch-output-formats.7 page.
>
>
>> + ``--exclude=(true|false|all|flag)``
>> + A message is called "excluded" if it matches at least one tag in
>> + search.tag\_exclude that does not appear explicitly in the
>> + search terms. This option specifies whether to omit excluded
>> + messages in the search process.
>
> Similarly for excludes. I'm ok with the duplication for now, and I can
> see an argument for not making the user chase references.
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2014-11-04 20:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 23:50 [PATCH v2 00/10] "notmuch address" command Michal Sojka
2014-11-03 23:50 ` [PATCH v2 01/10] cli: search: Rename options to context Michal Sojka
2014-11-04 6:24 ` David Bremner
2014-11-03 23:50 ` [PATCH v2 02/10] cli: search: Move more variables into search_context_t Michal Sojka
2014-11-03 23:50 ` [PATCH v2 03/10] cli: search: Convert ctx. to ctx-> Michal Sojka
2014-11-04 6:29 ` David Bremner
2014-11-03 23:50 ` [PATCH v2 04/10] cli: search: Split notmuch_search_command to smaller functions Michal Sojka
2014-11-03 23:50 ` [PATCH v2 05/10] cli: add support for hierarchical command line option arrays Michal Sojka
2014-11-04 6:36 ` David Bremner
2014-11-04 6:38 ` David Bremner
2014-11-03 23:50 ` [PATCH v2 06/10] cli: Introduce "notmuch address" command Michal Sojka
2014-11-04 6:52 ` David Bremner
2014-11-04 9:40 ` Tomi Ollila [this message]
2014-11-04 21:59 ` Michal Sojka
2014-11-04 22:12 ` David Bremner
2014-11-04 9:04 ` Mark Walters
2014-11-04 22:15 ` Michal Sojka
2014-11-05 11:22 ` Mark Walters
2014-11-05 12:23 ` Michal Sojka
2014-11-05 12:48 ` Mark Walters
2014-11-03 23:50 ` [PATCH v2 07/10] cli: search: Convert --output to keyword argument Michal Sojka
2014-11-04 8:58 ` Mark Walters
2014-11-04 9:08 ` Mark Walters
2014-11-04 11:26 ` Michal Sojka
2014-11-03 23:50 ` [PATCH v2 08/10] cli: address: Do not output duplicate addresses Michal Sojka
2014-11-04 7:05 ` David Bremner
2014-11-04 11:36 ` Michal Sojka
2014-11-03 23:50 ` [PATCH v2 09/10] cli: address: Add --output=count Michal Sojka
2014-11-04 9:11 ` Mark Walters
2014-11-03 23:50 ` [PATCH v2 10/10] cli: address: Add --filter-by option to configure address filtering Michal Sojka
2014-11-04 9:23 ` [PATCH v2 00/10] "notmuch address" command Mark Walters
2014-11-04 20:33 ` Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m261ev483v.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=sojkam1@fel.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).