From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>,
Mark Walters <markwalters1009@gmail.com>,
notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: tree: mark read change
Date: Wed, 24 Jun 2015 00:14:02 +0300 [thread overview]
Message-ID: <m2616eb011.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <87si9iyxn9.fsf@maritornes.cs.unb.ca>
On Tue, Jun 23 2015, David Bremner <david@tethera.net> wrote:
> Mark Walters <markwalters1009@gmail.com> writes:
>
>> The mark read code for tree mode did not get updated in the recent
>> changes. This updates it to match. Since the user can customize the
>> mark read logic we just call the show logic in the message pane.
>> ---
>>
>> An alternative would be to mark any message explicitly viewed in
>> tree-mode as read. That would be simpler but I think this is better as
>> it deals with user customized mark read functions -- for example if
>> the user has a customized function that only marks a message read if
>> the whole message is viewed then this version will do the same in tree
>> mode.
>
> At first I was leery of the chaining of hooks, but now that I
> noticed/experienced the bug, it makes more sense to me. I'm considering
> rolling a bug fix release with this (I imagine the bug is pretty
> annoying for people using only notmuch-tree), so I'd like a bit more
> feedback before merging it.
From code point of view it looks good to me.
Tomi
>
> d
prev parent reply other threads:[~2015-06-23 21:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 9:51 [PATCH] emacs: tree: mark read change Mark Walters
2015-06-23 20:31 ` David Bremner
2015-06-23 21:14 ` Tomi Ollila [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2616eb011.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).