From: Tomi Ollila <tomi.ollila@iki.fi>
To: J Farkas <jf.hyqohaczlksw4tx6ae@l2015aftruuq.dns007.net>,
David Bremner <david@tethera.net>
Cc: notmuch@notmuchmail.org
Subject: Re: T070 tests portability
Date: Thu, 07 Jan 2016 23:50:10 +0200 [thread overview]
Message-ID: <m260z5jbzh.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1452088279.96.560c52fa@201601.l2015aftruuq.dns007.net>
On Wed, Jan 06 2016, J Farkas <jf.hyqohaczlksw4tx6ae@l2015aftruuq.dns007.net> wrote:
> On 2016-01-05 at 17:41:06, David Bremner wrote:
>> Tomi Ollila <tomi.ollila@iki.fi> writes:
>>
>> > The page https://sourceware.org/gdb/onlinedocs/gdb/Returning.html
>> > talks something about gdb not knowing the return type if function
>> > was compiled without debug info... well, is this is the reason,
>> > perhaps we should allow testing w/o debug info compiled in.
>>
>> The test suite overall assumes debug info is present; T000-basic tests
>> for this.
>
> I'm not missing the debug infos (well, except for the thread library if I
> understand correctly - and that affects a lot of other tests, but not this).
> Perhaps it the version of gdb, but not any compilation flags that can be
> changed for the notmuch tree.
>
> Without the changes, I'm getting these two kind of errors (and as you can
> see, the test for the debugging symbols passes too).
ack... keep reading...
>
> $ ./T000-basic.sh
>
> T000-basic: Testing the test framework itself.
> PASS success is reported like this
> ...
> PASS PATH is set to build directory
> PASS notmuch is compiled with debugging symbols
> $ ./T070-insert.sh
>
> T070-insert: Testing "notmuch insert"
> PASS Insert zero-length file
> ...
> FAIL Insert duplicate message
> --- T070-insert.6.expected 2016-01-06 13:31:01.644676102 +0000
> +++ T070-insert.6.output 2016-01-06 13:31:01.648675891 +0000
> @@ -1 +1 @@
> -2
> + 2
This is trivial to fix w/ the same
output=$((`notmuch search --output=files "subject:insert-subject" | wc -l`))
construct that is used in T060-count.sh
A separate patch doing just this would be appreciated.
> PASS Duplicate message does not change tags
> PASS Insert message, add tag
> ...
> PASS Tags starting with '-' in new.tags are forbidden
> PASS Invalid tags set exit code
> FAIL error exit when add_message returns OUT_OF_MEMORY
> --- T070-insert.26.expected 2016-01-06 13:31:06.940397013 +0000
> +++ T070-insert.26.output 2016-01-06 13:31:06.940397013 +0000
> @@ -1 +1 @@
> -1
> +255
> warning: Unable to find libthread_db matching inferior's thread library, thread debugging will not be available.
> index-file-OUT_OF_MEMORY.gdb:7: Error in sourced command file:
> Return value type not available for selected stack frame.
> Please use an explicit cast of the value to return.
> FAIL success exit with --keep when add_message returns OUT_OF_MEMORY
Your setup is interesting -- you have GNU textutils 2.0.22, released
2002-07-20 (i.e. 13.5 years ago) and then gdb 7.4. I just run this
test file on Scientific Linux 6.2 (gcc 4.4.6 and gdb 7.2), and the
tests passed without problems.
Apart from a few special cases, no typecasts should be added lightly
to the code -- be it at innocent-looking as it can be. Those impedes
the possibility for compiler (etc.) to do type checking.
So, in this case, if you're the only one seeing this problem I'd suggest
you tolerate the problem (by using private patch) (you could also dig
deeper if interested). If this "problem" is (were!) more widespread,
*and* unfixable in reasonable manner this thing like this typecast
could be applied -- which would also mean this test system would
be a bit less robust as it is now...(*)
Tomi
(*) imo these are hard facts, but someone(tm) may consider these as mere
opinions...
> ...
>
> (The above is then repeated for all gdb using `insert` tests.)
>
> János
next prev parent reply other threads:[~2016-01-07 21:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 10:55 T070 tests portability J Farkas
2016-01-05 20:58 ` Tomi Ollila
2016-01-05 21:41 ` David Bremner
2016-01-06 13:51 ` J Farkas
2016-01-07 21:50 ` Tomi Ollila [this message]
2016-01-08 19:23 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m260z5jbzh.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=jf.hyqohaczlksw4tx6ae@l2015aftruuq.dns007.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).