From: Tomi Ollila <tomi.ollila@iki.fi>
To: "W. Trevor King" <wking@tremily.us>, notmuch@notmuchmail.org
Subject: Re: [PATCH] nmbug: Add --no-renames to default log options
Date: Mon, 26 Sep 2016 21:46:10 +0300 [thread overview]
Message-ID: <m260pixzwt.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <7c8e197c8137c0a3c0c185000f5da35728f347c4.1474907453.git.wking@tremily.us>
On Mon, Sep 26 2016, "W. Trevor King" <wking@tremily.us> wrote:
> Git has supported this since b68ea12e (diff.c: respect diff.renames
> config option, 2006-07-07, v1.4.2). All of our information is in the
> paths (the files are empty), so we don't want rename detection. By
> using --no-renames, we get entries like:
>
> $ nmbug log -- e473b453a2
> commit e473b453a25c072b5df67d834d822121373321f5
> Author: David Bremner <david@tethera.net>
> Date: Sun Sep 25 07:54:11 2016 -0300
>
> D tags/1474196252-31700-1-git-send-email-markwalters1009@gmail.com/0.23
> A tags/1474196252-31700-1-git-send-email-markwalters1009@gmail.com/pushed
>
> ...
>
> Instead of the old:
>
> $ nmbug log -- e473b453a2
> commit e473b453a25c072b5df67d834d822121373321f5
> Author: David Bremner <david@tethera.net>
> Date: Sun Sep 25 07:54:11 2016 -0300
>
> R100 tags/1474196252-31700-1-git-send-email-markwalters1009@gmail.com/0.23 tags/1474196252-31700-1-git-send-email-markwalters1009@gmail.com/pushed
> ---
You must have newer git (than 2.8.2) (with smarter rename detection) as I
do not experience this using current nmbug -- also doing
( cd $HOME/.nmbug && exec git log --name-status e473b453a2 )
works as expected (I tried also renaming .gitconfig away w/o effect)
anyway, change looks good; i just cannot test it (fully), the it seems like
it works after change since git log --name-status --no-renames e473b453a2
works too
> devel/nmbug/nmbug | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/devel/nmbug/nmbug b/devel/nmbug/nmbug
> index 1dd5f14..6febf16 100755
> --- a/devel/nmbug/nmbug
> +++ b/devel/nmbug/nmbug
> @@ -475,7 +475,7 @@ def log(args=()):
> 'nmbug log HEAD..@{upstream}'.
> """
> # we don't want output trapping here, because we want the pager.
> - args = ['log', '--name-status'] + list(args)
> + args = ['log', '--name-status', '--no-renames'] + list(args)
> with _git(args=args, expect=(0, 1, -13)) as p:
> p.wait()
>
> --
> 2.1.0.60.g85f0837
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2016-09-26 18:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-25 11:00 nmbug log feature request David Bremner
2016-09-26 16:32 ` [PATCH] nmbug: Add --no-renames to default log options W. Trevor King
2016-09-26 18:46 ` Tomi Ollila [this message]
2016-10-04 10:54 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m260pixzwt.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=notmuch@notmuchmail.org \
--cc=wking@tremily.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).