From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tomi.ollila@iki.fi>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 4B7D46DE0FF7
 for <notmuch@notmuchmail.org>; Sun, 13 May 2018 11:19:18 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: 0.474
X-Spam-Level: 
X-Spam-Status: No, score=0.474 tagged_above=-999 required=5 tests=[AWL=-0.178, 
 SPF_NEUTRAL=0.652] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id FKKB6T2bChQd for <notmuch@notmuchmail.org>;
 Sun, 13 May 2018 11:19:16 -0700 (PDT)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
 by arlo.cworth.org (Postfix) with ESMTP id 917216DE0C64
 for <notmuch@notmuchmail.org>; Sun, 13 May 2018 11:19:15 -0700 (PDT)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
 by guru.guru-group.fi (Postfix) with ESMTP id 55B5D100090;
 Sun, 13 May 2018 21:19:04 +0300 (EEST)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, David Bremner <david@tethera.net>,
 notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] drop use of register keyword
In-Reply-To: <20180513161718.20901-1-david@tethera.net>
References: <87605rle5q.fsf@tethera.net>
 <20180513161718.20901-1-david@tethera.net>
User-Agent: Notmuch/0.26.1+22~g888240d (https://notmuchmail.org) Emacs/25.2.1
 (x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
 !)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Sun, 13 May 2018 21:19:04 +0300
Message-ID: <m2603rh10n.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sun, 13 May 2018 18:19:18 -0000

On Sun, May 13 2018, David Bremner wrote:

> The performance benefits are dubious, and it's deprecated in C++11.

series +1

Tomi

> ---
>  gmime-filter-reply.c | 2 +-
>  lib/index.cc         | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gmime-filter-reply.c b/gmime-filter-reply.c
> index a1ba4b45..f673c0a2 100644
> --- a/gmime-filter-reply.c
> +++ b/gmime-filter-reply.c
> @@ -113,7 +113,7 @@ filter_filter (GMimeFilter *filter, char *inbuf, size_t inlen, size_t prespace,
>  	       char **outbuf, size_t *outlen, size_t *outprespace)
>  {
>  	GMimeFilterReply *reply = (GMimeFilterReply *) filter;
> -	register const char *inptr = inbuf;
> +	const char *inptr = inbuf;
>  	const char *inend = inbuf + inlen;
>  	char *outptr;
>  
> diff --git a/lib/index.cc b/lib/index.cc
> index 0ad683fa..146a8928 100644
> --- a/lib/index.cc
> +++ b/lib/index.cc
> @@ -176,7 +176,7 @@ filter_filter (GMimeFilter *gmime_filter, char *inbuf, size_t inlen, size_t pres
>  {
>      NotmuchFilterDiscardNonTerm *filter = (NotmuchFilterDiscardNonTerm *) gmime_filter;
>      const scanner_state_t *states = filter->states;
> -    register const char *inptr = inbuf;
> +    const char *inptr = inbuf;
>      const char *inend = inbuf + inlen;
>      char *outptr;
>  
> -- 
> 2.17.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch