From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iL6HBNa3jWD4BgEAgWs5BA (envelope-from ) for ; Sat, 01 May 2021 22:19:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id qCM0ANa3jWBFEAAAB5/wlQ (envelope-from ) for ; Sat, 01 May 2021 20:19:34 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5400718C8E for ; Sat, 1 May 2021 22:19:33 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id D69242716D; Sat, 1 May 2021 16:19:30 -0400 (EDT) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [IPv6:2a0b:5c81:1c1::37]) by mail.notmuchmail.org (Postfix) with ESMTPS id 3CA271FBC5 for ; Sat, 1 May 2021 16:19:28 -0400 (EDT) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 1A3E01B0102D; Sat, 1 May 2021 23:19:27 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1619900367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qCDwE59ipqN6K3Jh1AJTc+TJxiqmkk8J2UHMKPvId4c=; b=KrDrdDawSEPrn74nawNQi6Rt+2pw0v+BEcDEkbIoLdtYK/IgvtWH0CcvYMJsya/iqSv04j NFpNYsXcbAIOXKEYnYZXo1Nxpp5xFlgWJ7J7xeCJ3zxzw2TgnN1wz2+kuLNEtCGD9XTXsH 8C5ko5z4O1OlfLPE/Kfy2UvlpQHn5Cst7zaZyxap6Y6dSJK6vsi8azzxTryvymV/gQgx// LxPNYDd2upnKcVcv0uc7WWESolT1p1O8rxDTySdjebqX8yKOqwIynQYUARHSydJzoAWDfD qHWRZWBpoUSYuOcVEM3UDM6+kd+WXCWyTgvupXuOU9tkZ2LZwxzgAtCTSjMTPw== From: Tomi Ollila To: Felipe Contreras , notmuch@notmuchmail.org Subject: Re: [PATCH 07/13] test: add external prereqs to many emacs tests In-Reply-To: <20210501115422.483314-8-felipe.contreras@gmail.com> References: <20210501115422.483314-1-felipe.contreras@gmail.com> <20210501115422.483314-8-felipe.contreras@gmail.com> User-Agent: Notmuch/0.31.4+128~gc67b63a (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1619900367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qCDwE59ipqN6K3Jh1AJTc+TJxiqmkk8J2UHMKPvId4c=; b=NdxAcLW5EtguyCa/2JfeHYVbmCib8mZkGU3Gggb1DAYUsiJCjz5/XAjAWdqBQRhbDJirwu gOW8mHWDOEaTJA05yA/po5rTbA1/X2+X3Z4SP6IsNyzszGJJOV4ih5B4OR1aGt+d0CZSLt 2pWlyw1vSEXkHiy3DfP2jGaXPdTwqrepa7PQVEDiA7Jncbsp7uMDTU7HxMcpoZgdPXrHLz 1VK2vNLxseAKxXMkQTypDwOiCtEjtTAw48YDy7XjtK0bhkO9H8D8fReDOC6oddi/Awzu+U U66scvUbuEHMbiaE0BJPgod+Jq7p/Reoy3coQOZmaVNnrJvch6H/YNoyNsP1GQ== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1619900367; a=rsa-sha256; cv=none; b=XTrjd5vNbJK5TBJl1YRv2CjG+D2ZuEVYXPDA6d8yPDGSBkZHO3/cQaMIIITtkr1tCd9O3x y3/HArCly+4hicr1gS+FB+z8ycJ7FwrjxMt26RtfIJwbxQYpefXNcKrWuheDFbFSaA25Eb vn+h5sQZskJwY8snDjWxa/tw8zCR4VnsiAGM9iQF0uLQVciml+I0e7FpkNeqfhRsDvKUij zEsWi+ENA8EIqtMXBfz/l8gsoumym3Tb8h5r1yRlLSSqGOP7ACc6r9vV9pmARp9q1E1C6v kVa7aGcjQ6YjUs2H5EkC07KaR5/Rq8Csx7nOWS9ZEvi+yoQJAWQjSHvcDVVCQg== Message-ID-Hash: V465GIJWHHEW6WM4I2EQLBL4ADLTZJDR X-Message-ID-Hash: V465GIJWHHEW6WM4I2EQLBL4ADLTZJDR X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Daniel Kahn Gillmor X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619900373; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=WXRR1B33Vm3gwGvDs2Gd0gBcejC5n46kmlx6ScgGWMY=; b=m2EYXX+gymjVQqM7ppmO/Tr7+eUnE/J8YtruvZ9XN+SwrrmwLfJNzTtzamtEPPCg2OzsQJ 5kos694P/HQYJf3Q/d69s+fyRjVHkx/sPz9503+1m3FOSHW1iMx6Th6saJcVTT/nKqNO8m S9dZwBe0Dy2ajbNyJwCZpHQ+tclyFqwM3oFz33CVQhgsilsdpgbQavO8PxDGpO1D6TUiht HiJgNZF10BtfBbpDjPmK+OVHZa8OqRdiOZHiyjBtc93hUVKIfwPL03J9SN6F+FitwtsTEP zKuryyLq4kOe3mwLk/+xq3HEDHn4uJz3tfmLV4ppzFeww0ONoyOtHLQSYvhIUQ== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1619900373; a=rsa-sha256; cv=fail; b=m22KZ5cSoJG2iAecpMEJcfPQqKv/Myt1DAyleikmoESVnGiUjNV9GnXq/r2WZA0DemlRGw Xtd46+MtLLlHD9iJj3jyC19B5KN9zXbirEPa4YKEEhdYg8c7z5P18lhjGLl2c72vMav4Ci YuDbk9M2w9ZV2rjQi7dlHOAsDGYSUVlQpiADOHX2iCNk63+a5EioY49aS3WWosdnHe9JRd S5+U13hkuvsYLmlpOudunVrR+pyf915zZCQrfVELPw6qkrzVSPUYWmM4/+Rxxc2L0TAcdZ tcDj/DxcJYrIUbjmIAQG5Hrvmt1FrCVydBJJgtPZnoyRF9q8A3ZYwstd/eP2EQ== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=KrDrdDaw; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: 0.91 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=KrDrdDaw; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 5400718C8E X-Spam-Score: 0.91 X-Migadu-Scanner: scn0.migadu.com X-TUID: SZTeDIDFKtRd On Sat, May 01 2021, Felipe Contreras wrote: > The tests fail otherwise. LGTM. Tomi > > Signed-off-by: Felipe Contreras > --- > test/T310-emacs.sh | 1 + > test/T350-crypto.sh | 1 + > test/T355-smime.sh | 1 + > test/T357-index-decryption.sh | 1 + > test/T450-emacs-show.sh | 1 + > test/T460-emacs-tree.sh | 1 + > test/T730-emacs-forwarding.sh | 2 ++ > test/test-lib.sh | 6 ++++++ > 8 files changed, 14 insertions(+) > > diff --git a/test/T310-emacs.sh b/test/T310-emacs.sh > index 78ac19a8..e64627c6 100755 > --- a/test/T310-emacs.sh > +++ b/test/T310-emacs.sh > @@ -5,6 +5,7 @@ test_description="emacs interface" > > EXPECTED=$NOTMUCH_SRCDIR/test/emacs.expected-output > > +test_require_emacs > add_email_corpus > > # syntax errors in test-lib.el cause mysterious failures > diff --git a/test/T350-crypto.sh b/test/T350-crypto.sh > index 0aada4df..ae1d6a98 100755 > --- a/test/T350-crypto.sh > +++ b/test/T350-crypto.sh > @@ -9,6 +9,7 @@ test_description='PGP/MIME signature verification and decryption' > > ################################################## > > +test_require_emacs > add_gnupg_home > > test_begin_subtest "emacs delivery of signed message" > diff --git a/test/T355-smime.sh b/test/T355-smime.sh > index 8b2b52be..12ac2525 100755 > --- a/test/T355-smime.sh > +++ b/test/T355-smime.sh > @@ -3,6 +3,7 @@ > test_description='S/MIME signature verification and decryption' > . $(dirname "$0")/test-lib.sh || exit 1 > > +test_require_emacs > test_require_external_prereq openssl > test_require_external_prereq gpgsm > > diff --git a/test/T357-index-decryption.sh b/test/T357-index-decryption.sh > index 1ed5f28c..b81bdfe1 100755 > --- a/test/T357-index-decryption.sh > +++ b/test/T357-index-decryption.sh > @@ -7,6 +7,7 @@ test_description='indexing decrypted mail' > > ################################################## > > +test_require_emacs > add_gnupg_home > > # create a test encrypted message > diff --git a/test/T450-emacs-show.sh b/test/T450-emacs-show.sh > index cca56ca3..bd76d378 100755 > --- a/test/T450-emacs-show.sh > +++ b/test/T450-emacs-show.sh > @@ -5,6 +5,7 @@ test_description="emacs notmuch-show view" > > EXPECTED=$NOTMUCH_SRCDIR/test/emacs-show.expected-output > > +test_require_emacs > add_email_corpus > > test_begin_subtest "Hiding Original Message region at beginning of a message" > diff --git a/test/T460-emacs-tree.sh b/test/T460-emacs-tree.sh > index cb2c90b8..195485c1 100755 > --- a/test/T460-emacs-tree.sh > +++ b/test/T460-emacs-tree.sh > @@ -5,6 +5,7 @@ test_description="emacs tree view interface" > > EXPECTED=$NOTMUCH_SRCDIR/test/emacs-tree.expected-output > > +test_require_emacs > add_email_corpus > > test_begin_subtest "Basic notmuch-tree view in emacs" > diff --git a/test/T730-emacs-forwarding.sh b/test/T730-emacs-forwarding.sh > index 45e61568..5d6ac9f0 100755 > --- a/test/T730-emacs-forwarding.sh > +++ b/test/T730-emacs-forwarding.sh > @@ -3,6 +3,8 @@ > test_description="emacs forwarding" > . $(dirname "$0")/test-lib.sh || exit 1 > > +test_require_emacs > + > test_begin_subtest "Forward setting the correct references header" > # Check that, when forwarding a message, the new message has > # a References-header pointing to the original (forwarded) message. > diff --git a/test/test-lib.sh b/test/test-lib.sh > index 72ac2e89..88e2a82f 100644 > --- a/test/test-lib.sh > +++ b/test/test-lib.sh > @@ -114,6 +114,12 @@ unset ALTERNATE_EDITOR > unset EMAIL > unset NAME > > +test_require_emacs () { > + test_require_external_prereq emacs > + test_require_external_prereq ${TEST_EMACSCLIENT} > + test_require_external_prereq dtach > +} > + > add_gnupg_home () > { > [ -e "${GNUPGHOME}/gpg.conf" ] && return > -- > 2.31.0 > _______________________________________________ > notmuch mailing list -- notmuch@notmuchmail.org > To unsubscribe send an email to notmuch-leave@notmuchmail.org