From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>,
Felipe Contreras <felipe.contreras@gmail.com>,
notmuch@notmuchmail.org
Subject: Re: [PATCH 7/9] test: ruby: use much more standard Ruby idioms
Date: Sun, 02 May 2021 22:00:10 +0300 [thread overview]
Message-ID: <m25z01q7ut.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <87v981mm1r.fsf@tethera.net>
On Sun, May 02 2021, David Bremner wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>> ---
>> test/T395-ruby.sh | 20 ++++++++------------
>> 1 file changed, 8 insertions(+), 12 deletions(-)
>>
>> diff --git a/test/T395-ruby.sh b/test/T395-ruby.sh
>> index f871ddd9..f5a8d245 100755
>> --- a/test/T395-ruby.sh
>> +++ b/test/T395-ruby.sh
>> @@ -24,7 +24,7 @@ notmuch search --sort=oldest-first --output=threads tag:inbox | sed s/^thread://
>> test_ruby <<"EOF"
>> @q = @db.query('tag:inbox')
>> @q.sort = Notmuch::SORT_OLDEST_FIRST
>> -for t in @q.search_threads do
>> +@q.search_threads.each do |t|
>> puts t.thread_id
>> end
>> EOF
>
> The downside to these changes is that they make the tests harder for the
> non-rubyist (i.e. me) to read. So I'm not (yet) convinced this is a good
> change.
I am convinced that this is good change (like all the other changes
in this series).
Every now and then I encounter ruby code, and have seen syntax like
`@q.search_threads.each do |t|` been used, so more exposure to that
syntax is good thing (for everyone (IMO))
Tomi
next prev parent reply other threads:[~2021-05-02 19:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-01 11:59 [PATCH 0/9] test: ruby: several cleanups and simplifications Felipe Contreras
2021-05-01 11:59 ` [PATCH 1/9] test: move test_ruby() inside the only client Felipe Contreras
2021-05-02 10:49 ` David Bremner
2021-05-02 18:28 ` Tomi Ollila
2021-05-01 11:59 ` [PATCH 2/9] test: ruby: refactor test_ruby() Felipe Contreras
2021-05-02 10:50 ` David Bremner
2021-05-01 11:59 ` [PATCH 3/9] test: ruby: simplify MAIL_DIR check Felipe Contreras
2021-05-02 10:51 ` David Bremner
2021-05-01 11:59 ` [PATCH 4/9] test: ruby: simplify MAIL_DIR initialization Felipe Contreras
2021-05-02 10:56 ` David Bremner
2021-05-01 11:59 ` [PATCH 5/9] test: ruby: simplify test_ruby() Felipe Contreras
2021-05-02 11:02 ` David Bremner
2021-05-02 21:53 ` Felipe Contreras
2021-05-01 11:59 ` [PATCH 6/9] test: ruby: use much more standard puts Felipe Contreras
2021-05-02 11:03 ` David Bremner
2021-05-01 11:59 ` [PATCH 7/9] test: ruby: use much more standard Ruby idioms Felipe Contreras
2021-05-02 11:07 ` David Bremner
2021-05-02 19:00 ` Tomi Ollila [this message]
2021-05-05 22:29 ` David Bremner
2021-05-06 11:52 ` Felipe Contreras
2021-05-02 22:11 ` Felipe Contreras
2021-05-01 11:59 ` [PATCH 8/9] test: ruby: don't use instance variables Felipe Contreras
2021-05-02 11:08 ` David Bremner
2021-05-01 11:59 ` [PATCH 9/9] test: ruby: simplify output comparison Felipe Contreras
2021-05-02 11:09 ` David Bremner
2021-05-02 11:22 ` [PATCH 0/9] test: ruby: several cleanups and simplifications David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m25z01q7ut.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=felipe.contreras@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).