From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4FlgFQ4k+2CxfQAAgWs5BA (envelope-from ) for ; Fri, 23 Jul 2021 22:18:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 4MvoEA4k+2BCVgAA1q6Kng (envelope-from ) for ; Fri, 23 Jul 2021 20:18:22 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0EF8411F53 for ; Fri, 23 Jul 2021 22:18:22 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 1073E29088; Fri, 23 Jul 2021 16:18:17 -0400 (EDT) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [IPv6:2a0b:5c81:1c1::37]) by mail.notmuchmail.org (Postfix) with ESMTPS id 6CC0426BE0 for ; Fri, 23 Jul 2021 16:18:14 -0400 (EDT) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 389A21B0004B; Fri, 23 Jul 2021 23:18:13 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1627071493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PFecqZFRD7qKpA2p0C77Cgf0Ws3Vdxq+ONas5wtkE3g=; b=G7YICQEHfRweYE5ryj3lXAo/D1n0b06xaiSgf4nEHexD3cCmemAAWDHCGLCc0ZZiwxXX/D GTw0diVcu02tLmG1jLZgxubBAmteULoSJfAWAy6KQtD+KJ75jWUUUC7D2OOMBBuuEaCqto wTOux3KUiiCnS1bbbC+9vMX6KyS7tM6/rp0OWTg4Uua7r57FogO1O9o66//CBJBzMVrGyr s5F0KC3H7wzRrHFaiyDUan8B4a8N7JjfuoarWR58A0M30a1R5hcvbV33Thbdlr6OTJblpF Hx9szuEbUiiOVHVP4zraakkvIjmew3GbNnvYXWVm6FV7bNj+GlrzfL4ww8/QzA== From: Tomi Ollila To: Jonas Bernoulli , notmuch@notmuchmail.org Subject: Re: [PATCH 0/5] Use closures and other emacs cleanup In-Reply-To: <20210719113109.5197-1-jonas@bernoul.li> References: <20210719113109.5197-1-jonas@bernoul.li> User-Agent: Notmuch/0.32+21~gfdddd4c (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1627071493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PFecqZFRD7qKpA2p0C77Cgf0Ws3Vdxq+ONas5wtkE3g=; b=NC7fHMD0dnPniwAbJAfetR1K02Rkp9yYbq16zlN2rWb470Ur/E7uoqNYm7PVwMw1+ivQz+ 4IcAH4IZ/bbWhB3Wj0bTuDcGpJTl0J+l3/Lj8UG5mJzDux6nqphGPdoKl2rhHFZf5qWYq8 21XPra0vwe8jeQF7LZbMSoUMcyQZww1DsNqlXzsO6/CaLfEl6o4t+8ctAgH79BwHr2ObUg s0jzTwbCP2NUMx8jvqorRvnkYZJ56eXBHQmouoDGmMkidifVDLFw1e8QFRZ6jM4lNzMvLe C7p6jKih4KdTeplzaKfL9xIESnR940iDlC2irDxkTtzAfMx/Ae6/jjr2+cOd9Q== ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1627071493; a=rsa-sha256; cv=none; b=oe6sQF2O9BrCh+MH724tLSQcBGw+YxllW/O9/w96JHNZIkqy67muvbDP8HDixfJLbGRKd9 7EAOt3eJdcdXKx47oJuyOqSifa2D9MKI4cY19/cAFG2B870Xds9lQQIXdMjOYPlCT4ZbFj C0SwV0KL0PxKLKVoIlNa+liqoi4OeuEI0tareEfuWdtjA66DWggvrJZ3sbfwCcLwcEVggO bUaUcPjcax8F3Q+SzscCUlofcsSSiF1cC0ISeAHwlaJjCvSpleZQ/p+r8o7lGYlCcRK4hF 2rQipayY31v4E6Wp95SiSR4c0jg3rOPRIfTdelk//i/WTL3ZIuW3tJ+dhPYGog== Message-ID-Hash: KI5HEZU6SRIMSZXJVAWNQV5DJFDEESBV X-Message-ID-Hash: KI5HEZU6SRIMSZXJVAWNQV5DJFDEESBV X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1627071502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=xy9UhYuaRd3LXowjAmFT8palLtz/AQVa+/Nz209KIns=; b=dWA9HlJGXRqF5wH+BtOGuSQ87M0STbl6C2aj9Q4//KmFf19dS5nTSmV7qJ2lHr3Qonl0NF QnQ7uimEEt7jnAY+xhCHS/lJk9P0OBQMqpoxCAAGkFM2kKSIEzM5C25AUZ4vlNOwyc7B1o RuwDycaptB8Xr5TA3mu0QkXaHlvpYkWMwv2QBK6tOSdhKi9ATJTzER7BCAD8ztwKyFNEaB Swmjq9h/ML/wEHw4FjUxUfi1aBz0m0ctoAjgNWsHdFuBgO9w9SAYZj+AmfNxdlBSaon3iD AZdOA7zqamz1+OciwkjdYWr5J3ukxsdyZK6unCnPEu6NVYcCcwN/pcohuiEQXw== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1627071502; a=rsa-sha256; cv=fail; b=KhaXQgsTxZC40mfB7WWs+WRtSC3f+e14V+VBbpCltE5wU/d3LJbclPn43opeJSRK5zPwAt IaWzm4K1IJqEof/ETjZuiWYmuR/y2WsGtR215LrG4+9PcUoxlvSma+BrLWIV64M9afOu5d kLr+V2vGcj0xzLmRykarWT2SL5NGf8FfunpwMlLyzyHybkGXaNN+meGH9l35TiD5ugkKX2 CZUoVULX3SXPq7uOStOtsb3j/qRiBC3YaQ2tt22dZcuD6NpwFJp9+CHf2kuMsC3bxe/oBi sK4SOOUrENsDYlZYlLWkj89QHXSp4/OxqlmrMbda823Ujri7eTD0G/oE9rtUDA== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=G7YICQEH; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: 0.96 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=G7YICQEH; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 0EF8411F53 X-Spam-Score: 0.96 X-Migadu-Scanner: scn0.migadu.com X-TUID: n4zMcS0HS3H4 On Mon, Jul 19 2021, Jonas Bernoulli wrote: > Some assorted emacs cleanup and fixes. The big one is the switch to > using closures instead of backquoted lambdas. The other commits for > the most part just deal with things the compiler complained about. > > Jonas Bernoulli (5): > emacs: use closures instead of backquoted lambdas > emacs: add some function declarations > emacs: fix some option type declarations > emacs: notmuch-show-pipe-message: cosmetics > emacs: shorten lines in two doc-strings This series *looks* good to me (especially the 1st change -- I hope it works >;D). I don't understand why byte compiler would complain about too long lines but perhaps the changed docstrings are better (2 weeks in island w/o exposion to english language so can say notmuch about the content (if i could otherwise >;))) Tomi > > emacs/notmuch-draft.el | 2 +- > emacs/notmuch-hello.el | 24 ++++++++------- > emacs/notmuch-jump.el | 30 +++++++++++-------- > emacs/notmuch-show.el | 26 ++++++++--------- > emacs/notmuch-tag.el | 2 +- > emacs/notmuch-tree.el | 66 +++++++++++++++++++++++++----------------- > emacs/notmuch.el | 13 +++++---- > 7 files changed, 93 insertions(+), 70 deletions(-) > > -- > 2.31.1 > _______________________________________________ > notmuch mailing list -- notmuch@notmuchmail.org > To unsubscribe send an email to notmuch-leave@notmuchmail.org