unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file
Date: Sat, 04 Feb 2012 10:28:23 +0200	[thread overview]
Message-ID: <m24nv7t32w.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <87sjishv3e.fsf@gmail.com>

On Fri, 03 Feb 2012 18:04:05 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> On Thu, 02 Feb 2012 10:00:59 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> > Hey, Dmitry.  I'm so sorry I sent my last email on your original patch
> > before I saw this new series.  I do now like your original proposal
> > better, since it shows the diff based the names the caller provides,
> > which I now agree is probably the clearest and most robust solution.
> > The second patch in this series could still go through, though, no
> > matter what version of the change to test_expect_equal_file we go with.
> > 
> 
> Actually, we can do both: check file name for consistent diff order
> (from expected to actual) and use file names that the caller provides.
> 
> What do you think?

+1

> Regards,
>   Dmitry

Tomi

  parent reply	other threads:[~2012-02-04  8:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-02  0:04 [PATCH 0/2] test_expect_equal_file arguments check Dmitry Kurochkin
2012-02-02  0:04 ` [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file Dmitry Kurochkin
2012-02-02 18:00   ` Jameson Graef Rollins
2012-02-03  0:18     ` Dmitry Kurochkin
2012-02-03 14:04     ` Dmitry Kurochkin
2012-02-03 21:24       ` Jameson Graef Rollins
2012-02-04  8:28       ` Tomi Ollila [this message]
2012-10-12 17:42       ` Ethan Glasser-Camp
2012-10-18 10:05         ` Tomi Ollila
2012-02-02  0:04 ` [PATCH 2/2] test: fix order and format of test_expect_equal_file arguments Dmitry Kurochkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m24nv7t32w.fsf@guru.guru-group.fi \
    --to=tomi.ollila@iki.fi \
    --cc=dmitry.kurochkin@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).