From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 77390431FBD for ; Mon, 14 Apr 2014 05:21:22 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BgfAkaXZhMYZ for ; Mon, 14 Apr 2014 05:21:16 -0700 (PDT) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by olra.theworths.org (Postfix) with ESMTP id 7E3FB431FBC for ; Mon, 14 Apr 2014 05:21:16 -0700 (PDT) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id 352A610008F; Mon, 14 Apr 2014 15:21:08 +0300 (EEST) From: Tomi Ollila To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH 1/2] build: add canonicalize_file_name to symbols exported from libnotmuch.so In-Reply-To: <1397042643-10975-1-git-send-email-david@tethera.net> References: <87r4586p7m.fsf@zancas.localnet> <1397042643-10975-1-git-send-email-david@tethera.net> User-Agent: Notmuch/0.17+200~g5c6d42d (http://notmuchmail.org) Emacs/24.3.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Apr 2014 12:21:22 -0000 On Wed, Apr 09 2014, David Bremner wrote: > This is needed for our compat version of canonicalize_file_name to be used. > --- This series LGTM, just that this does not apply anymore (2nd patch, that is). > lib/gen-version-script.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/gen-version-script.sh b/lib/gen-version-script.sh > index 76670d5..64a7374 100644 > --- a/lib/gen-version-script.sh > +++ b/lib/gen-version-script.sh > @@ -23,6 +23,6 @@ while read sym; do > ;; > esac > done > -nm $* | awk '$1 ~ "^[0-9a-fA-F][0-9a-fA-F]*$" && $2 == "T" && $3 ~ "^get(line|delim)$" {print $3 ";"}' > +nm $* | awk '$1 ~ "^[0-9a-fA-F][0-9a-fA-F]*$" && $2 == "T" && $3 ~ "^(getline|getdelim|canonicalize_file_name)$" {print $3 ";"}' > sed -n 's/^[[:space:]]*\(notmuch_[a-z_]*\)[[:space:]]*(.*/ \1;/p' $HEADER > printf "local: *;\n};\n" > -- > 1.9.0 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch