From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tomi.ollila@iki.fi>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 93C876DE0243
 for <notmuch@notmuchmail.org>; Tue, 16 Jun 2015 15:12:05 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: 0.98
X-Spam-Level: 
X-Spam-Status: No, score=0.98 tagged_above=-999 required=5 tests=[AWL=0.328,
 SPF_NEUTRAL=0.652] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 7kcdMwOZ6I-k for <notmuch@notmuchmail.org>;
 Tue, 16 Jun 2015 15:12:03 -0700 (PDT)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
 by arlo.cworth.org (Postfix) with ESMTP id BDECC6DE01F5
 for <notmuch@notmuchmail.org>; Tue, 16 Jun 2015 15:12:02 -0700 (PDT)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
 by guru.guru-group.fi (Postfix) with ESMTP id B610E100086;
 Wed, 17 Jun 2015 01:11:38 +0300 (EEST)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Daniel Schoepe <daniel@schoepe.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] Fix documentation for notmuch--tag-hook functions
In-Reply-To: <1434491240-31023-1-git-send-email-daniel@schoepe.org>
References: <1434491240-31023-1-git-send-email-daniel@schoepe.org>
User-Agent: Notmuch/0.20+12~gf3d9440 (http://notmuchmail.org) Emacs/24.3.1
 (x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
 !)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Wed, 17 Jun 2015 01:11:38 +0300
Message-ID: <m24mm7mhgl.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Jun 2015 22:12:05 -0000

On Wed, Jun 17 2015, Daniel Schoepe <daniel@schoepe.org> wrote:

> The second argument to notmuch-tag is now called tag-changes, but the
> documentation for notmuch-before-tag-hook and notmuch-after-tag-hook
> still used the old argument name `tags'. This resulted in broken hooks
> when following the documentation.

LGTM.

Tomi

> ---
>  emacs/notmuch-tag.el | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el
> index f54aa9d..c7f62c9 100644
> --- a/emacs/notmuch-tag.el
> +++ b/emacs/notmuch-tag.el
> @@ -265,7 +265,7 @@ changed (the normal case) are shown using formats from
>  (defcustom notmuch-before-tag-hook nil
>    "Hooks that are run before tags of a message are modified.
>  
> -'tags' will contain the tags that are about to be added or removed as
> +'tag-changes' will contain the tags that are about to be added or removed as
>  a list of strings of the form \"+TAG\" or \"-TAG\".
>  'query' will be a string containing the search query that determines
>  the messages that are about to be tagged"
> @@ -277,7 +277,7 @@ the messages that are about to be tagged"
>  (defcustom notmuch-after-tag-hook nil
>    "Hooks that are run after tags of a message are modified.
>  
> -'tags' will contain the tags that were added or removed as
> +'tag-changes' will contain the tags that were added or removed as
>  a list of strings of the form \"+TAG\" or \"-TAG\".
>  'query' will be a string containing the search query that determines
>  the messages that were tagged"
> -- 
> 2.4.3
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch