unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH 3/5] build: optionally build python-cffi bindings
Date: Mon, 04 Nov 2019 23:26:25 +0200	[thread overview]
Message-ID: <m24kzjib9a.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20191104013927.17037-4-david@tethera.net>

On Sun, Nov 03 2019, David Bremner wrote:

> Put the build product (and tests) in a well known location so that we
> can find them e.g. from the tests.
> ---
>  Makefile.local          | 2 +-
>  bindings/Makefile.local | 9 +++++++++
>  2 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile.local b/Makefile.local
> index 3c6dacbc..7c12612d 100644
> --- a/Makefile.local
> +++ b/Makefile.local
> @@ -1,7 +1,7 @@
>  # -*- makefile -*-
>  
>  .PHONY: all
> -all: notmuch notmuch-shared build-man build-info ruby-bindings
> +all: notmuch notmuch-shared build-man build-info ruby-bindings python-cffi-bindings
>  ifeq ($(MAKECMDGOALS),)
>  ifeq ($(shell cat .first-build-message 2>/dev/null),)
>  	@NOTMUCH_FIRST_BUILD=1 $(MAKE) --no-print-directory all
> diff --git a/bindings/Makefile.local b/bindings/Makefile.local
> index 18f95835..b8e18c92 100644
> --- a/bindings/Makefile.local
> +++ b/bindings/Makefile.local
> @@ -13,6 +13,13 @@ ifeq ($(HAVE_RUBY_DEV),1)
>  	$(MAKE) -C $(dir)/ruby
>  endif
>  
> +python-cffi-bindings: lib/$(LINKER_NAME)
> +ifeq ($(HAVE_PYTHON_CFFI),1)
> +	cd $(dir)/python-cffi && \

how bad does out-of-tree build break with this -- do we need to do
the same as with ruby bindings (copy sources -- do we still do so)? or does
python provide better alternative..?

> +		${PYTHON} setup.py build --build-lib build/stage && \
> +		mkdir -p build/stage/tests && cp tests/*.py build/stage/tests
> +endif
> +
>  CLEAN += $(patsubst %,$(dir)/ruby/%, \
>  	.RUBYARCHDIR.time \
>  	Makefile database.o directory.o filenames.o\
> @@ -20,3 +27,5 @@ CLEAN += $(patsubst %,$(dir)/ruby/%, \
>  	status.o tags.o thread.o threads.o)
>  
>  CLEAN += bindings/ruby/.vendorarchdir.time
> +
> +CLEAN += bindings/python-cffi/build
> -- 
> 2.24.0.rc1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

  reply	other threads:[~2019-11-04 21:26 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-04  1:39 python CFFI bindings integration into notmuch build/test David Bremner
2019-11-04  1:39 ` [PATCH 1/5] bindings/python-cffi: preserve environment for tests David Bremner
2019-11-04  1:39 ` [PATCH 2/5] configure: check for python cffi module David Bremner
2019-11-04 21:24   ` Tomi Ollila
2019-11-04  1:39 ` [PATCH 3/5] build: optionally build python-cffi bindings David Bremner
2019-11-04 21:26   ` Tomi Ollila [this message]
2019-11-05  0:32     ` David Bremner
2020-05-22  1:06     ` Daniel Kahn Gillmor
2019-11-04  1:39 ` [PATCH 4/5] tests: run python-cffi tests David Bremner
2019-11-04 16:18   ` Tomi Ollila
2019-11-04 16:57     ` David Bremner
2019-11-04 21:45   ` Tomi Ollila
2019-11-04 22:04     ` Tomi Ollila
2019-11-06  2:19     ` David Bremner
2019-11-06 20:51       ` Tomi Ollila
2019-11-09  1:36         ` David Bremner
2019-11-09 21:59           ` Tomi Ollila
2019-11-22  3:03             ` David Bremner
2019-11-26  0:52               ` David Bremner
2019-12-03 12:16                 ` David Bremner
2019-11-04  1:39 ` [PATCH 5/5] travis: add python3-{cffi,pytest,setuptools} David Bremner
2019-11-04 11:10 ` python CFFI bindings integration into notmuch build/test David Bremner
2019-11-05 20:47 ` Tomi Ollila
2019-11-06  2:22   ` David Bremner
2019-11-14 18:52     ` Floris Bruynooghe
2019-11-14 20:20       ` Tomi Ollila
2019-11-14 22:24         ` Floris Bruynooghe
2019-11-14 23:09           ` Floris Bruynooghe
2019-11-16 15:51             ` David Bremner
2019-11-17 14:40               ` Floris Bruynooghe
2019-11-17 16:09                 ` David Bremner
2019-11-16 15:43         ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m24kzjib9a.fsf@guru.guru-group.fi \
    --to=tomi.ollila@iki.fi \
    --cc=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).