From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 866CD6DE09ED for ; Tue, 26 Nov 2019 12:05:41 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.277 X-Spam-Level: X-Spam-Status: No, score=0.277 tagged_above=-999 required=5 tests=[AWL=-0.375, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_NEUTRAL=0.652, UNPARSEABLE_RELAY=0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t-UXK1_Dk3UX for ; Tue, 26 Nov 2019 12:05:40 -0800 (PST) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by arlo.cworth.org (Postfix) with ESMTPS id 1CC006DE0931 for ; Tue, 26 Nov 2019 12:05:39 -0800 (PST) Received: by mail-wr1-f68.google.com with SMTP id z7so20533503wrl.13 for ; Tue, 26 Nov 2019 12:05:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dme-org.20150623.gappssmtp.com; s=20150623; h=to:cc:subject:in-reply-to:references:from:date:message-id :mime-version; bh=JEGZtHPwBfJ5C1KBSDntJ0khz2dEP0FFpCtw0sNiPkM=; b=Zyvr7RGqD1nMiYcvq1Rq9PFyNsMPavb6pqVDpKeKEiu3cEHZc82pnKMZR92qWajfyC WdGCGHTYaKA+iEGMXWAEPPOAZC2J+7IPCCNos48/0mmlAg+wZOEG/PKaa7I5iIlkH8vO HYLCvDD0B0it0JmjEVQg4W06G+e04wWPoegvLyuTNw3zIApaXA3ay5Tm1+7ac14Wmd4m QCTuAo0LkbL10NLQ5xnqV0gRkXl8H9aFvI3eZfxyNdLP5/GDI9U1EAi3akq2D3DeNICJ zXqsr5IA0Zpt2j3c6FWx7I3DAuMDakIm2qU9uhpPyFJl9dwuWI410746UhbEtaXXDvWY 2tmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:subject:in-reply-to:references:from:date :message-id:mime-version; bh=JEGZtHPwBfJ5C1KBSDntJ0khz2dEP0FFpCtw0sNiPkM=; b=BUxmbSakarU/4NKfvi6BUQW5kZYarkSU8R4UihgqxndhrELiqIFICtHSKV3ilaeD11 rX9tGftkFjb8YVAgJUCVwFc6XIxGNDednecVVPiwmwn0xMsaesqgP/mtV3/m+i12/lur uS7o471Le9bORoB9+ujZfpNnXtt1Xf4OKQVQoND6B4tVF7ebF+WjeX6XfeaQFE82Q6Vz W5CvaJ75d746nrI/0eSyTBo4jyccC3zkptS9Q+TSL40JxTWk7FX2tqNeiXQ49+2qaRR2 WCHRorDW7QvqYw7Vp2qpAurYZs03MzcbzLcgaQbFpOouJJpDEfR/db3EoqrBmrqqj+km 1kZg== X-Gm-Message-State: APjAAAWr2uTiRElLO4VEDMJJDFG0/NIXT7dsyjrVUZ+abiV5fpY+Dl8S 5KLU5C6WDIlIElbKry9Xp4bREw== X-Google-Smtp-Source: APXvYqwKPtnzwYQtQi9pe3RiMgxTqe+AIfDaTgWKwKXeJDeAtpJyIwImcT4PDFsfp0xxPTvLaN/Gkg== X-Received: by 2002:adf:c145:: with SMTP id w5mr606121wre.205.1574798737028; Tue, 26 Nov 2019 12:05:37 -0800 (PST) Received: from disaster-area.hh.sledj.net (disaster-area.hh.sledj.net. [81.149.164.25]) by smtp.gmail.com with ESMTPSA id m3sm17094161wrb.67.2019.11.26.12.05.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2019 12:05:36 -0800 (PST) Received: from localhost (disaster-area.hh.sledj.net [local]) by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id b4571cb4; Tue, 26 Nov 2019 20:05:35 +0000 (UTC) To: Sean Whitton , emacs-orgmode@gnu.org Cc: notmuch@notmuchmail.org Subject: Re: Bug: ol-notmuch.el: calls `notmuch-show' with arbitrary search query In-Reply-To: <87h82wrjvb.fsf@iris.silentflame.com> References: <87h82wrjvb.fsf@iris.silentflame.com> X-HGTTG: zarniwoop From: David Edmondson Date: Tue, 26 Nov 2019 20:05:35 +0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Nov 2019 20:05:41 -0000 On Thursday, 2019-11-21 at 14:37:44 -07, Sean Whitton wrote: > The function `org-notmuch-follow-link' in {org,ol}-notmuch.el calls > `notmuch-show' with an arbitrary notmuch search query. However, the > docstring for `notmuch-show' specifies that a notmuch thread ID, rather > than an arbitrary notmuch query, should be supplied to `notmuch-show'. > > The effect of this is that the variable `notmuch-show-thread-id' may > contain an arbitrary search query rather than a thread ID. That broke > some code of mine which uses that variable. Could you explain how you were using `notmuch-show-thread-id' in a way that was broken by the presence of an arbitrary query? (Not arguing right or wrong, just trying to understand the problem.) > `org-notmuch-follow-link' needs to continue to accept an arbitrary query > (as notmuch thread IDs are not stable), but it should convert it to a > thread ID before passing it to `notmuch-show'. dme. -- I'd rather be with you than flying through space.