From: David Edmondson <dme@dme.org>
To: William Casarin <jb55@jb55.com>,
Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
notmuch@notmuchmail.org
Subject: Re: [PATCH v3 0/7] Port notmuch-show's x/X bindings to notmuch-tree
Date: Fri, 21 Feb 2020 17:18:32 +0000 [thread overview]
Message-ID: <m24kvjkgev.fsf@dme.org> (raw)
In-Reply-To: <87tv3j7tuh.fsf@jb55.com>
On Friday, 2020-02-21 at 09:06:46 -08, William Casarin wrote:
> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
>
>> On Sat 2019-12-28 10:01:17 -0500, William Casarin wrote:
>>> These patches bring notmuch-tree more in line with the user experience
>>> of notmuch-show by adding the x/X bindings.
>>
>> It looks like this series has been reviewed by dme, and is presumably
>> approved by him, with the exception of patch 3/7, which
>> id:m25zhyxasu.fsf@dme.org suggests some improvement on.
>>
>> William, would you be up for doing one last re-spin of this series to
>> address dme's comments? it'd be nice to land this series unless someone
>> raises objections.
>
> I was planning on it but it fell by the wayside. The only comment was
> just a naming thing, perhaps we can just pull this and rename it in a
> future patch?
That would be fine with me.
> I could do a whole new series but I feel like that is overkill.
dme.
--
You make me feel like a natural woman.
next prev parent reply other threads:[~2020-02-21 17:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-28 15:01 [PATCH v3 0/7] Port notmuch-show's x/X bindings to notmuch-tree William Casarin
2019-12-28 15:01 ` [PATCH v3 1/7] emacs/tree: return true if a thread was found in next-thread William Casarin
2019-12-30 12:17 ` David Edmondson
2019-12-28 15:01 ` [PATCH v3 2/7] emacs/tree: add notmuch-tree-goto-matching-message William Casarin
2019-12-30 12:20 ` David Edmondson
2019-12-28 15:01 ` [PATCH v3 3/7] emacs/tree: add notmuch-tree-matching-message William Casarin
2019-12-30 12:22 ` David Edmondson
2020-04-03 12:15 ` David Bremner
2019-12-28 15:01 ` [PATCH v3 4/7] emacs/tree: add kill-both prefix argument to notmuch-tree-quit William Casarin
2019-12-30 12:23 ` David Edmondson
2019-12-28 15:01 ` [PATCH v3 5/7] emacs/tree: add notmuch-tree-archive-message-than-next-or-exit William Casarin
2019-12-30 12:24 ` David Edmondson
2019-12-28 15:01 ` [PATCH v3 6/7] emacs/tree: add notmuch-tree-archive-thread-then-exit William Casarin
2019-12-30 12:25 ` David Edmondson
2019-12-28 15:01 ` [PATCH v3 7/7] emacs/tree: add x/X bindings William Casarin
2019-12-30 12:25 ` David Edmondson
2020-02-20 19:43 ` [PATCH v3 0/7] Port notmuch-show's x/X bindings to notmuch-tree Daniel Kahn Gillmor
2020-02-21 17:06 ` William Casarin
2020-02-21 17:18 ` David Edmondson [this message]
2020-03-23 16:38 ` William Casarin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m24kvjkgev.fsf@dme.org \
--to=dme@dme.org \
--cc=dkg@fifthhorseman.net \
--cc=jb55@jb55.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).