From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id OLouEa+olV7APAAA0tVLHw (envelope-from ) for ; Tue, 14 Apr 2020 12:12:31 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id P8ytCLKolV7PdQAA1q6Kng (envelope-from ) for ; Tue, 14 Apr 2020 12:12:34 +0000 Received: from arlo.cworth.org (arlo.cworth.org [50.126.95.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EF9A1941A35 for ; Tue, 14 Apr 2020 12:12:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 0BBED6DE10D2; Tue, 14 Apr 2020 05:12:24 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Mr-uq5568jNt; Tue, 14 Apr 2020 05:12:23 -0700 (PDT) Received: from arlo.cworth.org (localhost [IPv6:::1]) by arlo.cworth.org (Postfix) with ESMTP id 7EF5E6DE0F5A; Tue, 14 Apr 2020 05:12:22 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 39C636DE0F5A for ; Tue, 14 Apr 2020 05:12:20 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JprcXlf9jDUe for ; Tue, 14 Apr 2020 05:12:19 -0700 (PDT) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by arlo.cworth.org (Postfix) with ESMTPS id 253F16DE0E8B for ; Tue, 14 Apr 2020 05:12:19 -0700 (PDT) Received: by mail-wr1-f66.google.com with SMTP id t14so811717wrw.12 for ; Tue, 14 Apr 2020 05:12:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dme-org.20150623.gappssmtp.com; s=20150623; h=to:subject:in-reply-to:references:from:date:message-id:mime-version; bh=rp/n68XI3UjRiECyJhhxOkVpXODyUdjv8B3zdvKpcNo=; b=JlHTMvnk0nJwUt69l19FYrretrtoypx6sgBvOyzVFAu3D1Gpjgp08T43dHUUb2XLzh WN8SHnyIYCQ5EU6Iy9G4gyfgGPJ9Qzg6er/whI2i8jXwL4Qs0cW2GILqFKTJedw0bq45 kfp70AQwy93gojgF0fm1C+MtPH/tJFUC79Q31u1Wv+whcsxxP5eA2VL5m+4uPQmBLhS4 n1icLDApP6f10rwBfyBHpdDm8SOunwjXW6e736SnGcyuhAirHuDACEUlZk1P7k0aBvKB PD78gFSrZUJ1e8kHAKKV7/9sfMb6seqDtLKdXajWQxELj5ABXmV95VLiA3SuKPDjnmQg 6X5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:subject:in-reply-to:references:from:date :message-id:mime-version; bh=rp/n68XI3UjRiECyJhhxOkVpXODyUdjv8B3zdvKpcNo=; b=PeAJMcRcAoFuoFa2FyCkJHTZaiRvnsdvW+wGGUjzA54eu8/N+8JDmLDcx1DbUelWSQ pOZXkODmUI7lzszguwb1cSuNXRnt96fOKf/n3UHu5y52qcMEm3pR12jJeNUWiwjIsdzX IGXmS8DoeHGTTruYRJ6AlefLt8gviwCG2QMTCjlbxcxJCQDM/CdbEDBKHCGpRD/ZJaTf iu/A3iqFFqzV/mQFptHF+dVtxeJXGC6gZTZI+4hG4UwcgTNpvT+OUFqBb72PG2lHTndd MoWyI0k4TpJ5HxhMupfe97w30LGbqtLCTtHojIyLeVMhYEFr1fWzp9rh4VSvl2KYyktq fMxw== X-Gm-Message-State: AGi0PuYLfmOVGprwjnt2KvKJNUh792PW0dYG+os8PyJYFqUXnUgTf4QN SwWO8FMt86mQu4b+wG8Faf2NpQ== X-Google-Smtp-Source: APiQypIm7lBAKOL4kSBiQzXOrZp/MyT2P/u5mLEcWpnT820Vi1UAVvc1vK9SfXQiQjc7pYH5rJmDzw== X-Received: by 2002:a5d:4d8f:: with SMTP id b15mr2424782wru.107.1586866337301; Tue, 14 Apr 2020 05:12:17 -0700 (PDT) Received: from disaster-area.hh.sledj.net (disaster-area.hh.sledj.net. [81.187.26.238]) by smtp.gmail.com with ESMTPSA id c17sm19003060wrp.28.2020.04.14.05.12.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2020 05:12:16 -0700 (PDT) Received: from localhost (disaster-area.hh.sledj.net [local]) by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id a441c134; Tue, 14 Apr 2020 12:12:13 +0000 (UTC) To: Keegan Carruthers-Smith , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: use def instead of initial-input for notmuch-show-browse-urls In-Reply-To: References: X-HGTTG: heart-of-gold From: David Edmondson Date: Tue, 14 Apr 2020 13:12:13 +0100 Message-ID: MIME-Version: 1.0 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: notmuch-bounces@notmuchmail.org Sender: "notmuch" X-Scanner: scn0 X-Spam-Score: -0.01 Authentication-Results: aspmx1.migadu.com; dkim=fail (body hash did not verify) header.d=dme-org.20150623.gappssmtp.com header.s=20150623 header.b=JlHTMvnk; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 50.126.95.6 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Scan-Result: default: False [-0.01 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.45109512615312]; TO_DN_SOME(0.00)[]; IP_REPUTATION_HAM(0.00)[asn: 27017(-0.18), country: US(-0.01), ip: 50.126.95.6(-0.45)]; R_DKIM_REJECT(1.00)[dme-org.20150623.gappssmtp.com:s=20150623]; R_SPF_ALLOW(-0.20)[+a]; DKIM_TRACE(0.00)[dme-org.20150623.gappssmtp.com:-]; RCPT_COUNT_TWO(0.00)[2]; MX_GOOD(-0.50)[notmuchmail.org]; MAILLIST(-0.20)[mailman]; FREEMAIL_TO(0.00)[gmail.com,notmuchmail.org]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:27017, ipnet:50.126.64.0/18, country:US]; MID_RHS_MATCH_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[dme@dme.org,notmuch-bounces@notmuchmail.org]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; SPF_REPUTATION_HAM(0.00)[-0.44958498725373]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[notmuch@notmuchmail.org]; HAS_LIST_UNSUB(-0.01)[]; DMARC_NA(0.00)[dme.org]; RCVD_COUNT_SEVEN(0.00)[10]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: PeuGowzbFion On Monday, 2020-04-13 at 21:58:19 +02, Keegan Carruthers-Smith wrote: > This is the non-deprecated way to use completing-read. Additionally > the old use was broken when using ivy for completing-read. For user's > using completing-read-default they won't see the default URL now, but > if they hit enter it will be visited. Alternatively they can select > it with M-n. > > From the completing-read documentation for initial-input: > > This feature is deprecated--it is best to pass nil for INITIAL-INPUT > and supply the default value DEF instead. The user can yank the > default value into the minibuffer easily using M-n. > > Additionally collection is now all urls, rather than all but the > first. I'm not sure why "(cdr urls)" was previously done. Reviewed-by: David Edmondson > --- > emacs/notmuch-show.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el > index 214e279f..079281c3 100644 > --- a/emacs/notmuch-show.el > +++ b/emacs/notmuch-show.el > @@ -2559,7 +2559,7 @@ browsing." > (prompt (if kill "Copy URL to kill ring: " "Browse URL: ")) > (fn (if kill #'kill-new #'browse-url))) > (if urls > - (funcall fn (completing-read prompt (cdr urls) nil nil (car urls))) > + (funcall fn (completing-read prompt urls nil nil nil nil (car urls))) > (message "No URLs found.")))) > > (provide 'notmuch-show) > -- > 2.26.0 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > https://notmuchmail.org/mailman/listinfo/notmuch dme. -- I used to worry, thought I was goin' mad in a hurry.