From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id ejZULoNCpV6uZwAA0tVLHw (envelope-from ) for ; Sun, 26 Apr 2020 08:12:51 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id GOwGIotCpV4aOAAAbx9fmQ (envelope-from ) for ; Sun, 26 Apr 2020 08:12:59 +0000 Received: from arlo.cworth.org (arlo.cworth.org [50.126.95.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 265A19422BA for ; Sun, 26 Apr 2020 08:12:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 8DF266DE01F1; Sun, 26 Apr 2020 01:12:54 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FYGys3gBl6oL; Sun, 26 Apr 2020 01:12:54 -0700 (PDT) Received: from arlo.cworth.org (localhost [IPv6:::1]) by arlo.cworth.org (Postfix) with ESMTP id 4D6196DE021A; Sun, 26 Apr 2020 01:12:53 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 827CA6DE021A for ; Sun, 26 Apr 2020 01:12:51 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GDgdYHd9pnih for ; Sun, 26 Apr 2020 01:12:50 -0700 (PDT) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [212.16.98.55]) by arlo.cworth.org (Postfix) with ESMTPS id B40D66DE01F1 for ; Sun, 26 Apr 2020 01:12:47 -0700 (PDT) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id D50C91B00426; Sun, 26 Apr 2020 11:12:41 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1587888762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WwNlP4vqQ1VvRSHM0sXySAL+rLkbRPbT7PZVsiOQQSU=; b=Bl9/0j3cX4JMj1trIMf2yfEP3pSEzgHgWJUbUvNDz1PPKM/oUdm5EqstscqhUZAtxgSXMe Q4DwSOpFGuyTZKmzKmD/+dzPsF1HJ83eiO5KG1r5KrXF7vhoX+iAiiirlNK2EPR9gJlnet FtJ7TloUmg4aaKMdvH1yeSVdP94RHEiPjgBSzcqYIV3HtiF9tJ7gzyjNu2i0iYDkZZGvKp mJ0jp0G8Tr/iVkJjkjHgjBC9D6DToNLorDHbW5ZHSCkGhoWAy+IMHb1jVI4A8pRKypza93 3J41bvjqe6k/yv5oc5xQ30W2ShguzcSNLWKcn7WMcs33vbmYDkM7xSVgENS0Aw== From: Tomi Ollila To: David Bremner , Milton Vandersloot , "notmuch\@notmuchmail.org" Subject: Re: test_emacs_expect_t does ignore Emacs as prerequisite In-Reply-To: <871rodkwgt.fsf@tethera.net> References: <4EC8sDKjAVEjYY1U-bmmhcOzj4Sekf_jKwOaaduMv3Oes4rNecwwrOLmvYbFwjGVd_5BW6PEeK7M0iMUKgOkHEwyETf-mjJqFexnKkqSUNM=@protonmail.com> <871rodkwgt.fsf@tethera.net> User-Agent: Notmuch/0.28.3+84~g41389bb (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1587888762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WwNlP4vqQ1VvRSHM0sXySAL+rLkbRPbT7PZVsiOQQSU=; b=vZOBZbWlmQgJYLzu35lrFOi1MJianiSt3ymNeA+lf5mBwKmYxqqloPoD4V+OTtJAAemFIA WZrkoVJksq9SBCE5lfFHoE0PRre9+zjTrc9MXkB35tr67GwaUzgIfXuloJ4VZRYtnXMQp9 IbNXHtirQ25o4pUyFKbpkS9xv69o4gCtsq6aJi+q9vbFk21UHYnWldQE/2i7TjjDH+/YdE gA3RF6j45QNgwwfafJiwfZZM8G86BbEiMAafwM3Hmqy3e15SLR01PO5/6lVKGa4aIwkFdM uT2Q5DUsp2Xwk1+aZ4h/D3IaCJNIFrjNQd3p9lO0xtXpzyZGQXOofQl8YT2HXw== ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1587888762; a=rsa-sha256; cv=none; b=aInzqmaZtrctsfNW+48v57VS6dG4XOUpxazS7VWgyZpfCS8CuqYwdh20jdwp/WEfR427LF zMiu6MQy8ZEjjxHzpYsAXF9vh3714pakX2z2Ga/ihtThuz3FArSdC9A+bdreSgiEb/hFWz ucy9FMVy71ncGa9lTZnDHCDacS39+pBMzZVKxvcGL6zlsp1KRx/Y7kaKpc+oeN38LCYaex vgNTw97ilLjQpraXzRbxDW05J6Rcu1SZU8iNbF4IINo1iAJ2xSuqhqUolJWZVMoyvPFF69 U96/dwkBYCR8xPlyrd3CaEBWz3CbY1VNajeLWQGF7dJeihBMhN1vHLBCL2GanQ== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: notmuch-bounces@notmuchmail.org Sender: "notmuch" X-Scanner: scn0 X-Spam-Score: 1.99 Authentication-Results: aspmx1.migadu.com; dkim=fail (body hash did not verify) header.d=iki.fi header.s=lahtoruutu header.b=Bl9/0j3c; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 50.126.95.6 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Scan-Result: default: False [1.99 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.45963687406155]; DWL_DNSWL_BLOCKED(0.00)[50.126.95.6:from]; R_SPF_ALLOW(-0.20)[+a:c]; IP_REPUTATION_HAM(0.00)[asn: 27017(-0.18), country: US(-0.00), ip: 50.126.95.6(-0.46)]; R_DKIM_REJECT(1.00)[iki.fi:s=lahtoruutu]; ARC_REJECT(2.00)[signature check failed: fail, {[1] = sig:iki.fi:reject}]; TO_DN_ALL(0.00)[]; MX_GOOD(-0.50)[cached: notmuchmail.org]; DKIM_TRACE(0.00)[iki.fi:-]; MAILLIST(-0.20)[mailman]; FREEMAIL_TO(0.00)[tethera.net,protonmail.com,notmuchmail.org]; RCVD_IN_DNSWL_FAIL(0.00)[50.126.95.6:server fail]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:27017, ipnet:50.126.64.0/18, country:US]; FROM_NEQ_ENVFROM(0.00)[tomi.ollila@iki.fi,notmuch-bounces@notmuchmail.org]; URIBL_BLOCKED(0.00)[notmuchmail.org:email,protonmail.com:email]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[notmuch@notmuchmail.org]; DMARC_NA(0.00)[iki.fi]; HAS_LIST_UNSUB(-0.01)[]; RCVD_COUNT_SEVEN(0.00)[8]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: 7WPYq/mUPrJ+ On Fri, Apr 24 2020, David Bremner wrote: > Milton Vandersloot writes: >> >> [PATCH] Let test_emacs_expect_t respect missing external prerequisites >> >> test_emacs_expect_t did not test for missing prerequisites (even though >> it called test_emacs which does it). Fix that by testing for missing >> prerequisites. >> > > I agree there's a bug here, but I'm not sure this is the best/cleanest > fix. Maybe Tomi (in Cc) can comment. The logic for prerequisite checking > is already opaque. For example test_skip is already calling > test_check_missing_external_prereqs_ as a side effect. For starters I > wonder if test_emacs should use a return value to indicate failure, > along the lines of the patch at the end of the message. I'd like David's approach, but in that case we don't get the "missing prerequisities" messages. Milton's solution looks like something that works =D. Just that the content inside {} needs to be indented, and opening brace ({) should be after || in same line... In case of test_skip it doesn't know about missing emacs prerequisities as the "subtest prerequisities" infomation is cleaned before every test and the information is regained in test_emacs... Tomi > BTW, it will make our life easier if you follow > https://notmuchmail.org/contributing/#index5h2; in particular using > git-send-email and keeping the discussion/notes after ---. >