From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>
Subject: Re: [PATCH 4/7] test/path-config: use test_expect_equal_file_nonempty
Date: Sat, 21 Aug 2021 23:41:57 +0300 [thread overview]
Message-ID: <m24kbiv8bu.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20210804104236.3986362-5-david@tethera.net>
On Wed, Aug 04 2021, David Bremner wrote:
> This is more robust against crashes when the expected output is also
> generated by notmuch. In the case where the expected output is
> explicit, it seems like overkill.
1,2,3 and 4 in this series look good to me
Tomi (on mobile device)
> ---
> test/T055-path-config.sh | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/test/T055-path-config.sh b/test/T055-path-config.sh
> index bb3bf665..8271579f 100755
> --- a/test/T055-path-config.sh
> +++ b/test/T055-path-config.sh
> @@ -141,13 +141,13 @@ EOF
> notmuch tag -inbox '*'
> notmuch restore < EXPECTED
> notmuch dump > OUTPUT
> - test_expect_equal_file EXPECTED OUTPUT
> + test_expect_equal_file_nonempty EXPECTED OUTPUT
>
> test_begin_subtest "reindex ($config)"
> notmuch search --output=messages '*' > EXPECTED
> notmuch reindex '*'
> notmuch search --output=messages '*' > OUTPUT
> - test_expect_equal_file EXPECTED OUTPUT
> + test_expect_equal_file_nonempty EXPECTED OUTPUT
>
> test_begin_subtest "use existing database ($config)"
> output=$(notmuch new)
> @@ -169,7 +169,7 @@ EOF
> test_begin_subtest "Show a raw message ($config)"
> add_message
> notmuch show --format=raw id:$gen_msg_id > OUTPUT
> - test_expect_equal_file $gen_msg_filename OUTPUT
> + test_expect_equal_file_nonempty $gen_msg_filename OUTPUT
> rm -f $gen_msg_filename
>
> test_begin_subtest "reply ($config)"
> @@ -198,14 +198,13 @@ EOF
> mkdir -p "$MAIL_DIR"/{cur,new,tmp}
> notmuch insert < "$gen_msg_filename"
> cur_msg_filename=$(notmuch search --output=files "subject:insert-subject")
> - test_expect_equal_file "$cur_msg_filename" "$gen_msg_filename"
> -
> + test_expect_equal_file_nonempty "$cur_msg_filename" "$gen_msg_filename"
>
> test_begin_subtest "compact+search ($config)"
> notmuch search --output=messages '*' | sort > EXPECTED
> notmuch compact
> notmuch search --output=messages '*' | sort > OUTPUT
> - test_expect_equal_file EXPECTED OUTPUT
> + test_expect_equal_file_nonempty EXPECTED OUTPUT
>
> test_begin_subtest "upgrade backup ($config)"
> features=$(xapian-metadata get $XAPIAN_PATH features | grep -v "^relative directory paths")
> --
> 2.30.2
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org
next prev parent reply other threads:[~2021-08-21 21:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 10:42 v2 look in MAILDIR for database David Bremner
2021-08-04 10:42 ` [PATCH 1/7] test/expect_equal_file: whitespace cleanup David Bremner
2021-08-22 2:44 ` David Bremner
2021-08-04 10:42 ` [PATCH 2/7] test: factor out test_diff_file_ David Bremner
2021-08-04 10:42 ` [PATCH 3/7] test: add test_expect_equal_file_nonempty David Bremner
2021-08-04 10:42 ` [PATCH 4/7] test/path-config: use test_expect_equal_file_nonempty David Bremner
2021-08-21 20:41 ` Tomi Ollila [this message]
2021-08-04 10:42 ` [PATCH 5/7] test: add known broken tests for finding database via MAILDIR David Bremner
2021-08-04 10:42 ` [PATCH 6/7] lib/open: look in MAILDIR for database, as documented David Bremner
2021-08-04 10:42 ` [PATCH 7/7] doc: document database search algorithm David Bremner
2021-08-21 15:03 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m24kbiv8bu.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).