From: Tomi Ollila <tomi.ollila@iki.fi>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/5] Rewrite mbox and raw show formats
Date: Sat, 03 Mar 2012 10:18:50 +0200 [thread overview]
Message-ID: <m2399qrtat.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1330752025-2542-1-git-send-email-amdragon@mit.edu>
On Sat, 3 Mar 2012 00:20:20 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> The show (rewrite) must go on. These are the last two formats in
> notmuch show proper; the only remaining format is the reply format.
>
> One of the ultimate goals of the show rewrite is to make raw actually
> work (and probably to split it into two different formats). This
> series does not do that; it just ports the existing raw format. I
> plan to make the new raw formats once the rewrite is done.
The whole patch series LGTM.
On somewhat related note: should there be NOTMUCH_STATUS_FAILURE (= 1)
in enum _notmuch_status (indicating unspecified failure). This would make
lines like
return show_message (ctx, format, message, 0, params) != NOTMUCH_STATUS_SUCCESS;
look better (or were/are all of these failures due to memory exhaustion) ?
Tomi
next prev parent reply other threads:[~2012-03-03 8:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-03 5:20 [PATCH 0/5] Rewrite mbox and raw show formats Austin Clements
2012-03-03 5:20 ` [PATCH 1/5] show: Allow formatters to return errors Austin Clements
2012-03-03 5:20 ` [PATCH 2/5] show: Move format_message_mbox with the other new-style formats Austin Clements
2012-03-03 5:20 ` [PATCH 3/5] show: Convert mbox format to new self-recursive style Austin Clements
2012-03-03 5:20 ` [PATCH 4/5] show: Move format_part_content_raw with the other new-style formats Austin Clements
2012-03-03 5:20 ` [PATCH 5/5] show: Convert raw format to the new self-recursive style Austin Clements
2012-03-03 22:05 ` Jameson Graef Rollins
2012-03-06 18:43 ` Austin Clements
2012-03-03 8:18 ` Tomi Ollila [this message]
2012-03-06 18:48 ` [PATCH v2 0/8] Rewrite mbox and raw show formats Austin Clements
2012-03-06 18:48 ` [PATCH v2 1/8] test: Fix typo in test description Austin Clements
2012-03-06 18:48 ` [PATCH v2 2/8] test: Fix malformed multipart message Austin Clements
2012-03-06 18:48 ` [PATCH v2 3/8] show: Allow formatters to return errors Austin Clements
2012-03-06 21:22 ` Mark Walters
2012-03-07 20:18 ` Tomi Ollila
2012-03-11 23:34 ` Austin Clements
2012-03-06 18:48 ` [PATCH v2 4/8] show: Move format_message_mbox with the other new-style formats Austin Clements
2012-03-06 18:48 ` [PATCH v2 5/8] show: Convert mbox format to new self-recursive style Austin Clements
2012-03-06 18:48 ` [PATCH v2 6/8] show: Move format_part_content_raw with the other new-style formats Austin Clements
2012-03-06 18:48 ` [PATCH v2 7/8] show: Convert raw format to the new self-recursive style, properly support interior parts Austin Clements
2012-03-06 18:48 ` [PATCH v2 8/8] man: Update raw format documentation Austin Clements
2012-03-09 3:25 ` [PATCH v2 0/8] Rewrite mbox and raw show formats Adam Wolfe Gordon
2012-03-18 12:51 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2399qrtat.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=amdragon@MIT.EDU \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).