From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tomi.ollila@iki.fi>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 0C0326DE1151
 for <notmuch@notmuchmail.org>; Tue, 20 Sep 2016 09:19:29 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: 0.549
X-Spam-Level: 
X-Spam-Status: No, score=0.549 tagged_above=-999 required=5 tests=[AWL=-0.103, 
 SPF_NEUTRAL=0.652] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id oidVkbdIkw7X for <notmuch@notmuchmail.org>;
 Tue, 20 Sep 2016 09:19:27 -0700 (PDT)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
 by arlo.cworth.org (Postfix) with ESMTP id 9AE756DE1149
 for <notmuch@notmuchmail.org>; Tue, 20 Sep 2016 09:19:27 -0700 (PDT)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
 by guru.guru-group.fi (Postfix) with ESMTP id 39F9610007F;
 Tue, 20 Sep 2016 19:19:41 +0300 (EEST)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: tree: make jump close message pane
In-Reply-To: <1474277989-13572-1-git-send-email-markwalters1009@gmail.com>
References: <1474277989-13572-1-git-send-email-markwalters1009@gmail.com>
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
 !)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Tue, 20 Sep 2016 19:19:40 +0300
Message-ID: <m237kuee77.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Sep 2016 16:19:29 -0000

On Mon, Sep 19 2016, Mark Walters <markwalters1009@gmail.com> wrote:

> j is in the global notmuch keymap bound to notmuch jump. In tree-mode
> it makes sense to close the message pane first (otherwise the new
> search runs in the small top pane of tree-mode).

looks good plus one

> ---
>
> I think this is essentially a bugfix -- I can't see why someone would
> want to keep the message pane open in tree-mode when using notmuch
> jump: the broad ethos of tree-mode is that the tree-view and the
> message pane are really one window.
>
> Best wishes
>
> Mark
>
>
>
>
> emacs/notmuch-tree.el | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el
> index 5431384..851e112 100644
> --- a/emacs/notmuch-tree.el
> +++ b/emacs/notmuch-tree.el
> @@ -241,6 +241,8 @@ FUNC."
>      (define-key map [remap notmuch-search] 'notmuch-tree-to-search)
>      ;; Override because we want to close message pane first.
>      (define-key map [remap notmuch-mua-new-mail] (notmuch-tree-close-message-pane-and #'notmuch-mua-new-mail))
> +    ;; Override because we want to close message pane first.
> +    (define-key map [remap notmuch-jump-search] (notmuch-tree-close-message-pane-and #'notmuch-jump-search))
>  
>      (define-key map "S" 'notmuch-search-from-tree-current-query)
>  
> -- 
> 2.1.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch