unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: tree: make jump close message pane
Date: Tue, 20 Sep 2016 19:19:40 +0300	[thread overview]
Message-ID: <m237kuee77.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1474277989-13572-1-git-send-email-markwalters1009@gmail.com>

On Mon, Sep 19 2016, Mark Walters <markwalters1009@gmail.com> wrote:

> j is in the global notmuch keymap bound to notmuch jump. In tree-mode
> it makes sense to close the message pane first (otherwise the new
> search runs in the small top pane of tree-mode).

looks good plus one

> ---
>
> I think this is essentially a bugfix -- I can't see why someone would
> want to keep the message pane open in tree-mode when using notmuch
> jump: the broad ethos of tree-mode is that the tree-view and the
> message pane are really one window.
>
> Best wishes
>
> Mark
>
>
>
>
> emacs/notmuch-tree.el | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el
> index 5431384..851e112 100644
> --- a/emacs/notmuch-tree.el
> +++ b/emacs/notmuch-tree.el
> @@ -241,6 +241,8 @@ FUNC."
>      (define-key map [remap notmuch-search] 'notmuch-tree-to-search)
>      ;; Override because we want to close message pane first.
>      (define-key map [remap notmuch-mua-new-mail] (notmuch-tree-close-message-pane-and #'notmuch-mua-new-mail))
> +    ;; Override because we want to close message pane first.
> +    (define-key map [remap notmuch-jump-search] (notmuch-tree-close-message-pane-and #'notmuch-jump-search))
>  
>      (define-key map "S" 'notmuch-search-from-tree-current-query)
>  
> -- 
> 2.1.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

  parent reply	other threads:[~2016-09-20 16:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-19  9:39 [PATCH] emacs: tree: make jump close message pane Mark Walters
2016-09-19 23:51 ` David Bremner
2016-09-20 16:19 ` Tomi Ollila [this message]
2016-09-24 13:18 ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m237kuee77.fsf@guru.guru-group.fi \
    --to=tomi.ollila@iki.fi \
    --cc=markwalters1009@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).