From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] lib: remove notmuch_query_{count, search}_{threads, messages}
Date: Sun, 26 Feb 2017 11:07:38 +0200 [thread overview]
Message-ID: <m237f1wc9x.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <87bmtq11dk.fsf@tethera.net>
On Sat, Feb 25 2017, David Bremner <david@tethera.net> wrote:
> Jani Nikula <jani@nikula.org> writes:
>
>> On Wed, 22 Feb 2017, David Bremner <david@tethera.net> wrote:
>>> These 4 functions were originally deprecated in notmuch 0.21, more
>>> than a year ago.
>>
>> This leaves the implementations of the functions as unused code behind.
I thought this was intentional as there were no LIBNOTMUCH_*_VERSION bump.
>
> oh oops.
>
>> How long until we can add them back with the same signature as the _st
>> versions, and deprecate the _st versions instead? ;)
>>
>
> I was thinking at least one release ;).
So, for 0.25 the non _st versions are back, _st versions as wrapper (or
some linking-time aliases?/?) for the non_st and n-year deprecation period
for the _st version (to not piss developers using the API again ;) ?
>
> d
Tomi
next prev parent reply other threads:[~2017-02-26 9:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 1:46 [PATCH] lib: remove notmuch_query_{count,search}_{threads,messages} David Bremner
2017-02-25 19:26 ` [PATCH] lib: remove notmuch_query_{count, search}_{threads, messages} Jani Nikula
2017-02-25 20:06 ` David Bremner
2017-02-26 9:07 ` Tomi Ollila [this message]
2017-02-26 21:21 ` v2 remove notmuch_query_{count,search}_{threads,messages} David Bremner
2017-02-26 21:21 ` [PATCH 1/6] lib: bump SONAME to libnotmuch5 David Bremner
2017-03-22 11:53 ` David Bremner
2017-02-26 21:21 ` [PATCH 2/6] lib: replace n_query_search_threads with status returning version David Bremner
2017-02-26 21:21 ` [PATCH 3/6] lib: replace deprecated n_q_search_messages " David Bremner
2017-02-26 21:21 ` [PATCH 4/6] fixup! " David Bremner
2017-02-26 21:21 ` [PATCH 5/6] lib: replace deprecated n_q_count_messages " David Bremner
2017-02-26 21:21 ` [PATCH 6/6] lib: replace deprecated n_q_count_threads " David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m237f1wc9x.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).