Re: [PATCH] emacs: drop use of message-default-charset

[Tomi Ollila <tomi.ollila@iki.fi>]

On Mon, Apr 22 2019, Daniel Kahn Gillmor wrote:

> Apparently, message-default-charset is deprecated, which causes the
> following warning messages during the build:
>
>   In notmuch-maildir-setup-message-for-saving:
>   emacs/notmuch-maildir-fcc.el:172:31:Warning: ‘message-default-charset’ is an
>       obsolete variable (as of 26.1); The default charset comes from the
>       language environment
>
> In discussion with emacs upstream over on
> https://debbugs.gnu.org/35370, it appears that we can just drop this
> entirely and things should still work with emacs 25.

I looked this a bit (well, quite a few minutes, rfc2047.el in emacs 24.3,
25.2 and 26.1), and while it is impossible to gain any real knowledge
with such a shallow peek, I'd guess the following might be true:

Since `mail-parse-charset` and `message-default-charset` are (were) both
`nil` by default, this change does have any effect for users that never
customized message-default-charset. If anyone did, now there is small
chance that the line:

"If nil, you might be asked to input the charset."

(from message-default-charset docstring) can happen.

In this context the change is IMO even more unlikely.

So this change LGTM.

Tomi

> ---
>  emacs/notmuch-maildir-fcc.el | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/emacs/notmuch-maildir-fcc.el b/emacs/notmuch-maildir-fcc.el
> index 1551e8b6..ae56bacd 100644
> --- a/emacs/notmuch-maildir-fcc.el
> +++ b/emacs/notmuch-maildir-fcc.el
> @@ -169,8 +169,7 @@ This is taken from the function message-do-fcc."
>    (message-encode-message-body)
>    (save-restriction
>      (message-narrow-to-headers)
> -    (let ((mail-parse-charset message-default-charset))
> -      (mail-encode-encoded-word-buffer)))
> +    (mail-encode-encoded-word-buffer))
>    (goto-char (point-min))
>    (when (re-search-forward
>  	 (concat "^" (regexp-quote mail-header-separator) "$")
> -- 
> 2.20.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch