From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id mPCOBv3m6V86BwAA0tVLHw (envelope-from ) for ; Mon, 28 Dec 2020 14:09:01 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id oM5mAv3m6V8dbgAAB5/wlQ (envelope-from ) for ; Mon, 28 Dec 2020 14:09:01 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 424AF9405D0 for ; Mon, 28 Dec 2020 14:08:58 +0000 (UTC) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id AB4F629CF4; Mon, 28 Dec 2020 09:08:47 -0500 (EST) Received: from lahtoruutu.iki.fi (unknown [IPv6:2a0b:5c81:1c1::37]) by mail.notmuchmail.org (Postfix) with ESMTPS id 70D782852E for ; Mon, 28 Dec 2020 09:08:44 -0500 (EST) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 125941B00080; Mon, 28 Dec 2020 16:08:30 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1609164510; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wMXBdBvokc2RII/HIzxo0PXSkZVEtm9yYcYKqLHYlrI=; b=oulASN6KHS8nhTOwA9XsYaH4pNiyTdASx5IJ6GGD4K2ys+aD0sByMMHSfA4CHQ9d/QCd05 Dtgq4FpEVj+aSi9aw91oBtibc6MO04zsk09j9m09i+4MvW8XgK1/fnghL1mjwpO1/Be/aX fj6lGNyY6zjO+k6WJuZA6me3FWNcYiD4j53WdcNxzUDcAUS4IVjV9upt5F4Z+6Kc0pzq2+ UkvI39LtcPzZ10MLBQcLMy+W/9fjJ3XU5vR8UFKzoiFpUHgsUdGNvzFLJ+2SKq1Nx0+JsN XnhHivLcGrYda9RCNJf7WramVMBE2Tk8D7Ax+LmEJ1dtdiC/xxzBql3bBnBt0Q== From: Tomi Ollila To: Jonas Bernoulli , notmuch@notmuchmail.org Subject: Re: [PATCH 00/32] [emacs] Add outline headings and switch to lexical scope In-Reply-To: References: <20201214162401.19569-1-jonas@bernoul.li> User-Agent: Notmuch/0.31.3+70~g95b022c (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1609164510; a=rsa-sha256; cv=none; b=V1KuEpLaC7cEkOkmfqethGjag1ehtPCbSiNSf5UxXl39gHr2eYs3WvTUQksvehs58NqIAC DF1Y7WqyYHBM7lcTq5D73ir+vzQ6G4ylpyWj0V/xa2ThZE2oIxZG8h+ehhj+jF81BhuTA0 TTPOrvzjsqH4y85jLt5vI/scWVujAvDIevErYZvlOP+F6bRQLYUUKoSk5qU7uR6xoYLORr OTncsnxHrAGD/WayhVPQIUbEP94L+zdn6ZZoEt3QKp4kxlMZSVHl8iyVIEC3vGnDtS1p9y n4nv63EOQHuQ3A/H2jhKhecOk9xcz5p1GJ2O4aLBWzTaDHaZxNoBssNX6gzEIQ== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1609164510; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wMXBdBvokc2RII/HIzxo0PXSkZVEtm9yYcYKqLHYlrI=; b=GcW64kmue54dzu1NVcUYBDpjIv85ZVG6Ka+Y1/nlh2UZToee3zdTdzWqUvkQZIDw792tzD 5lEaye9GDbvgHoBnI/0lSDK13tCJFW8NoiZcvk9MB2qCiNmSoVywVv96LK3G0RQkun9/YL reW5O8rM+39B5h+yJ+4RAX9Buy4j3moQKKUG7ec6H151a7FWoldn+l+MXQVDMKz6dxzdFI tz9YoedjqmrF60NuwrpxcMXOvoCQe5UXASB9zOoUoJg/xVwkfThOYFvj8UZTwVifBdD9aA MjoDaq56rcyWTSIelKOAqgnXKuO5AItoCTWofNCRkoU6XGv/8PAfiyI8GyCCcA== Message-ID-Hash: DJA4AQAP73BEGUUAYQG2YI62OQIOJYMD X-Message-ID-Hash: DJA4AQAP73BEGUUAYQG2YI62OQIOJYMD X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 1.12 Authentication-Results: aspmx1.migadu.com; dkim=fail (body hash did not verify) header.d=iki.fi header.s=lahtoruutu header.b=oulASN6K; arc=reject (signature check failed: fail, {[1] = sig:iki.fi:reject}); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 424AF9405D0 X-Spam-Score: 1.12 X-Migadu-Scanner: scn1.migadu.com X-TUID: rgFNXqq/etA7 On Sun, Dec 27 2020, Tomi Ollila wrote: > On Mon, Dec 14 2020, Jonas Bernoulli wrote: > >> Hello, >> >> This patch serious changes a number of things, including boring >> cleanup, but the big changes are the following. The respective >> commits are also marked in the list below. See these commits >> for longer descriptions. >> >> 1. Split all libraries into sections by adding new headings or >> formatting existing headings properly to be compatible with >> outline-minor-mode. >> >> 2. Use lexical-scope in all libraries. This is potentially faster >> and is recommended for all new code (and old code someone cares >> about enough). It also has the advantage that it can reveal >> subtle bugs. > > The patch series did not apply for me (fully) anymore. First had to Ok, applied when using `git am -3` Sending this email to remind everyone the --3way option of git-am, as it is forgotten so often (or then it is just me). Now I have this series in use, which my User-Agent: may also reveal (Notmuch/0.31.3+70~g95b022c (https://notmuchmail.org) Emacs/27.1). Tomi > be skipped, then two of more of the last, therefore I did not put > this into use for now (as, if it fails I don't know whether the > reason is dropped changes or my way of building it...) > > I like the series (on paper), 2 comments > > In patch 23/32, line > + (y-or-n-p (format "Fcc header %s is an absolute path%s%s" subdir > should be > + (y-or-n-p (format "Fcc header %s is an absolute path %s %s" subdir > > (I.e. spaces around %s's) > > Then, I personally don't see enough point for requiring subr-x > just just for changing (string= foo "") to (string-empty-p). If > there were more features picked from subr-x then that would be > different... > >> Among the many more commits that do not concern these two big >> changes, there are a few that might need special attention. >> (Again see the commits for details.) >> >> 3. No longer use Ido in notmuch-mua-prompt-for-sender. Might be >> controversial. >> >> 4. Stop using unnecessary let-bindings, though how "unnecessary" >> these bindings are is somewhat subjective. > > I like these two changes. > >> >> Cheers, >> Jonas > > Tomi > > PS: I used the following code to drop cr's (\r) from base64-encoded > text blobs; just enough to work in this particular case. > > #!/usr/bin/perl > # -*- mode: cperl; cperl-indent-level: 4 -*- > > use 5.8.1; > use strict; > use warnings; > use MIME::Base64; > > while () { > print $_; > if (/^Content-Transfer-Encoding: base64/) { > while () { print $_; last if /^\s*$/ } > my @lines; > while () { last if /^\s*$/; push @lines, $_ } > my $decoded = decode_base64 join('', @lines); > $decoded =~ tr/\r//d; > print(encode_base64 $decoded); > print "\n" > } > }