From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CflQDRO4jWCCCQEAgWs5BA (envelope-from ) for ; Sat, 01 May 2021 22:20:35 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id UHRvCBO4jWC4VAAAbx9fmQ (envelope-from ) for ; Sat, 01 May 2021 20:20:35 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A3B3C18ED8 for ; Sat, 1 May 2021 22:20:34 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 7C17D2717A; Sat, 1 May 2021 16:20:32 -0400 (EDT) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [185.185.170.37]) by mail.notmuchmail.org (Postfix) with ESMTPS id 89A701FBC5 for ; Sat, 1 May 2021 16:20:30 -0400 (EDT) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 66BCA1B0102A; Sat, 1 May 2021 23:20:29 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1619900429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NNLL/akEYkdBYNHv0SjclUtxZnXH71ADRblC9yUJXo8=; b=QpF1mp1ghgokA/17CmGjAAOIu93HhVl1iWn3Oe8ZJaZJ9U40JO4IG+8c0ZRSYB/qS2PbB+ cjeYWMUBBqnbYGx1bZoSXQXAJus+MBap5XaAOzhNHM1S7Hh2yRb9OPEcG80wY+ydvXyOIl 5RGrw+V8HjzclGtsL3kkapAyAWfoV07kYx4ERKWHez/6fq2Dez1eDlHEadCplXPPIF9cCC BNWpQ/oGP5I8DjJ3gmf31ltS3GQI+WZSwcMu41IdN4TFZijWuUJKy3SPskVoH/sIFSpAMy quFrxnOsJVQn6i/DpPsjvuFfrspVwkxHKpIAsYpPMAWgYoYo8hMBwa5p7Tp7EQ== From: Tomi Ollila To: Felipe Contreras , notmuch@notmuchmail.org Subject: Re: [PATCH 09/13] test: emacs: simplify missing dependencies check In-Reply-To: <20210501115422.483314-10-felipe.contreras@gmail.com> References: <20210501115422.483314-1-felipe.contreras@gmail.com> <20210501115422.483314-10-felipe.contreras@gmail.com> User-Agent: Notmuch/0.31.4+128~gc67b63a (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1619900429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NNLL/akEYkdBYNHv0SjclUtxZnXH71ADRblC9yUJXo8=; b=Ui6QP+QDUpf6GEed1ycGAhZc6r9cjE0GezL1mz/d8DV6cEbxfPP0uzY6qWVZBeLdppCL49 +AOSADeZ4nav2OCG8DqQ9N6C5PAlmjX1C6zw0ZRt0LA5KlXKrvWwTStazplZSXs8eaiIQN +chWySYjjJrLWaeTGz/D+sTgIZCX+ACopurNCzBd6ckomz1zGABtUI32Vr8ltaAD1V0AY5 F0zpkNFmh5dRoSBOLhPP/vK+2/3X/1JO4VNZ+ooWw+4OKpWrZao0cO98ef2AsTJqdU93ha Pob0quSVkW1HlXU5osN0lRZTw+yNci2BjzQ7x8AtIHs387GjouPEP1yG4J7IVw== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1619900429; a=rsa-sha256; cv=none; b=I6HbVze1CtvpT8RTHC9JVlEyR9dAtc293T53pKLwUhJlv53xwNWuWxMUgzJ7/Dt+/75MNy zPiqzHRSmAfetmfGGjmIvHPm6N0EqGOh0loPqPoONMJa/lQwCzK++LXmdl5QBl1MVB2fhu fJI7np3/lt26666JC0ENh4ygWoYgA4e5e4bPy/UnExYhfwe8uzsJEI0TrreC9wMX9RWix3 LstF5Bshk98TX8i/dYIZDRdizinebzKmSjAtLpEOz3hQlOthyi1LRk1emOvp5wU0/H/ESz CBFzLbAXz7VEwqwVgr8yLA7z0sqUUmpSWiAYy/RLROT4eBlX6Dw9VJJgea+vPA== Message-ID-Hash: AROODFS44HNVBPRKOLRER7YR2OUE7APW X-Message-ID-Hash: AROODFS44HNVBPRKOLRER7YR2OUE7APW X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Daniel Kahn Gillmor X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619900434; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=A9VGBXN9reLdHMlbzQR5KYdld7eT+KrOICzBuFqsfVc=; b=bZsFCPoBPqRxghvGqnW2N4/1k3G7YpSHni1dKH8c0zekH5qyBnkSVF/CORKH87W8tWWtkS OY9NYxCRn20QyLtVLIS4BkfbVBxcbYXPH42FJxkDXa2nSJIBWSe3S5UMxLKf6WK0p0eJqf fGmtvfb2joOUC7oAPVBinJFHoDwL4hWey0DAjjpGrJRa0743pQgJwSMs+YIiTWAMIrGOnr iGO0wHoJ/3hvtOaRbptg+lvBfG/7i7toS77KyNboMaTuhTHyARY+wSXdwm5g4CB+XG5qf7 1So55jQeySWAXAP+0PHNmpV5eVy+8kYKrucToxkthfAnUFTMBYqnT6NAXJ9y2Q== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1619900434; a=rsa-sha256; cv=fail; b=LAcK7xrgDyz/CoUf+7SVdW0A5JHj2yJ4gR2TBxX5aC1UfaPFB9D4vVpnR61o5bfC8EGMJv TEElvv5meK6JWfefuUotGvogry2yYvt7DkwVxgIxCytlyfBo3vG7k2y4uZYD6F9MfVLCvf tV/hp3OQw2xDhiJf3T1R1pOxX/TnJ1L+qBUUr/9P+O4fMoj68RYOqC1UQs+7xyv432gjP9 JMlTg/EXe/uJmZeHP4/ZGsb+TD7BM7Dph4IFgPeHR3W8D8FpWlJ8WGgIvxT/h2jNhU1M/o epOZuEI9bYr0eCJWofvbstSAkzabIByCVVf83oWhcSWkkp1MRFfcXE3HIefolw== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=QpF1mp1g; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: 0.91 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=QpF1mp1g; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: A3B3C18ED8 X-Spam-Score: 0.91 X-Migadu-Scanner: scn0.migadu.com X-TUID: c18Oa15f3Sbr On Sat, May 01 2021, Felipe Contreras wrote: > No functional changes. LGTM. Tomi > > Signed-off-by: Felipe Contreras > --- > test/test-lib-emacs.sh | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/test/test-lib-emacs.sh b/test/test-lib-emacs.sh > index ecad501a..83f5b10b 100644 > --- a/test/test-lib-emacs.sh > +++ b/test/test-lib-emacs.sh > @@ -15,9 +15,11 @@ > # along with this program. If not, see https://www.gnu.org/licenses/ . > > test_require_emacs () { > - test_require_external_prereq emacs > - test_require_external_prereq ${TEST_EMACSCLIENT} > - test_require_external_prereq dtach > + local ret=0 > + test_require_external_prereq emacs || ret=1 > + test_require_external_prereq ${TEST_EMACSCLIENT} || ret=1 > + test_require_external_prereq dtach || ret=1 > + return $ret > } > > # Deliver a message with emacs and add it to the database > @@ -167,11 +169,7 @@ EOF > > test_emacs () { > # test dependencies beforehand to avoid the waiting loop below > - missing_dependencies= > - test_require_external_prereq dtach || missing_dependencies=1 > - test_require_external_prereq emacs || missing_dependencies=1 > - test_require_external_prereq ${TEST_EMACSCLIENT} || missing_dependencies=1 > - test -z "$missing_dependencies" || return > + test_require_emacs || return > > if [ -z "$EMACS_SERVER" ]; then > emacs_tests="$NOTMUCH_SRCDIR/test/${this_test_bare}.el" > -- > 2.31.0 > _______________________________________________ > notmuch mailing list -- notmuch@notmuchmail.org > To unsubscribe send an email to notmuch-leave@notmuchmail.org