From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id AO1QNWR+4WAlyQAAgWs5BA (envelope-from ) for ; Sun, 04 Jul 2021 11:24:52 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id oPsAMWR+4WB3BwAAB5/wlQ (envelope-from ) for ; Sun, 04 Jul 2021 09:24:52 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 543191D065 for ; Sun, 4 Jul 2021 11:24:52 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id EAC4826C01; Sun, 4 Jul 2021 05:24:47 -0400 (EDT) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [185.185.170.37]) by mail.notmuchmail.org (Postfix) with ESMTPS id E293A26B99 for ; Sun, 4 Jul 2021 05:24:44 -0400 (EDT) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 549DB1B001CF; Sun, 4 Jul 2021 12:24:42 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1625390682; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=69qcDxtvnrVzcnMsZlDDABhLAlnwlnGACDgyaB1y5Fg=; b=O0aj94GRqvAPlhLGmXPx5repTRlhoDqHIR5pvVBaHnkpDCiAdlUv7LHagzELCC94XhRw8f rIGj2+jj+FRETAsQJ/8+VuqOQ4B5GKEowIaE/KbtVQASqnyQn0epCJXMZIcCVyEa+5Z3Lo 5punIMNNNGuAsSUoqZdUJ/kV9rnpB/HC6bdbHr4Crhm6bJWcWv61PFWJF5XJ/N4erTq1Fz nSthaQ8NU73fE1nXFBAaQgaDC0rtStrKQ0Dp8Xxrr+LcvAK/5VAJcHATrliNLUwyvyyywk kD1pV9LvLVu+o6Ga9AphT5lnSoEgkZl9BGP1zU/QppGIay4TPXifh1Z8sfnZTw== From: Tomi Ollila To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH 2/2] test: known broken test for emacs display of message/rfc822 parts In-Reply-To: <20210703201131.3184165-2-david@tethera.net> References: <20210703201131.3184165-1-david@tethera.net> <20210703201131.3184165-2-david@tethera.net> User-Agent: Notmuch/0.32+21~gfdddd4c (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1625390682; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=69qcDxtvnrVzcnMsZlDDABhLAlnwlnGACDgyaB1y5Fg=; b=kcDAwkf/0MhyyulW4YzzMF4J2mxggBZaXzOutsk8LKOghPRjAND9HFfBDympMEhr5VpyOz +v5b1fSi1TKthJDRuPH20lusZJTO1s2UeYFNv64CkApoomufGZQWw5SP0bKrWim7Eu9yAT N/7C6q+Z7izIEhVvaQ04s7DvXRnNE+/rMWkXp3aAaIbaY7aDbyrjSQ9dccfhQ2RAnDCXJt hVxcUUnIcDftqjHmDDfKkMPoL6fevofxFakmWdIxS724SK0s2USFILJg5D/wTOlFZKYt/+ qJNXFAcmXzmpwIM4AVx4QP8gQFjRJqrIWgntBLjwYW0fXlyYZEtkups7mPsPeg== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1625390682; a=rsa-sha256; cv=none; b=KU/O/lJ6XG12AVEsEUzEeA+kZzEmUyfkZPDhwTtOmSzzlGf/J3sFAmK4XH9H3pNwZuvejO KC568TthsUzyyYfoPWc2YPizO4a8y5aISV9FlfmsPIXSt2U5mgJ334KEFNGftRpd44hOcW 7nA+PLqvaCotwEY2+WavE/z7uXlvHfk4FByq/8YoETFZL/BpdPVP9iXr9c5EOVcXAZjNxw 9M/6gqshkscLk3TTy0TqH5u3Jj5jlsIJjiD6wX34WwwD0k/DQz1cLSBXdySY6T3WYgwW94 uQ8QVA8whzwZqM0zD2Xg6TErVgtQ01jZYCt7oHq1gacD3OugZhn1RAXHQ9VqAg== Message-ID-Hash: GV4HNNJDUHS5LC6E3TDJVFBC3WBC4FSX X-Message-ID-Hash: GV4HNNJDUHS5LC6E3TDJVFBC3WBC4FSX X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625390692; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=xuLNubeW8hS8W2oFmGstNupwQkYXxv0h7uQha/oLiX8=; b=DP6U3BbPkoqyrRGzje3b99Gk5lnNAgO12fNuI6Va6NAG6bgX+Wq31pNmVVOcPoW2KatveW mhkQk8KzrVkXe/sIaMFq5DJz8xynz3OkGZTzsWYzOxyXnqPcge2OEJkbSp6NpvdhHZVQ6d ni+S8prXh5BR9n1utKdu+P5d5ilt2BeDUZnhxak8pRUb0Cjf+g0rHBO0XoIq9+uZI0+XiI Bcr7L7KlykRS8PznUZxMgEH6Ff15XXXqYEnTW0FDV/MDBDk1cICKoSriHk1zD+26uu8+vL zmWJ4ow3w/VjPTrd0uBwBP9GFubUYBKpvBOyNcdIAlFIL92DMDgIL4Z5mplGFA== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1625390692; a=rsa-sha256; cv=fail; b=FuUgDKt03ufEzwbdxF+mZpcfBjimsLgH/Iy0YNXw/dXDZr/q/S1CKmDKeI4z54brKEDZkl C0sPw9i+6RVLKcGD+XDJ3B/Kq3n4lMyelow9BBvcm2TwZwSrwM/6YbcRqS2/Ydjl5oCbpF Y5cKCz/py90MoFLAFOrGbwtBc4MX9qk2423fYYON909LM4OhoT2lwXxsz8Bdhi66FtJGTu DdtgEqHpqUaXzM+TyHpCHKJmcAS67k0i4EahKuaR2tePm12cP4D4MxZvnLZcf7mSbzPAGu OH2c0qnKOz+wEooU8NReFA8ZOK1IsPsX9Ngh1Z+KMzS6eyz5MAZw4FvMtdT5Uw== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=O0aj94GR; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: 0.94 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=O0aj94GR; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 543191D065 X-Spam-Score: 0.94 X-Migadu-Scanner: scn0.migadu.com X-TUID: 9VvC7VGftp5s On Sat, Jul 03 2021, David Bremner wrote: > There are at least 3 bugs present. > > 1) notmuch-show-insert-part-message/rfc822 assumes that message/rfc822 > parts will have a ":content" property, but that turns out not to be > the case. > > 2) something deep in gnus wants gnus-newsgroup-charset, but that is > defined in gnus-sum, which is not loaded by default. > > 3) If gnus-sum is loaded, then the display of the message/rfc822 part > succeeds, but the buffer gets put into gnus-article-mode, which means > that, inter alia, notmuch text properties and keybindings get wiped. > --- > test/T450-emacs-show.sh | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/test/T450-emacs-show.sh b/test/T450-emacs-show.sh > index 9d08d2cc..bf7c1fe0 100755 > --- a/test/T450-emacs-show.sh > +++ b/test/T450-emacs-show.sh > @@ -219,6 +219,13 @@ test_emacs '(notmuch-show "id:basic-encrypted@crypto.notmuchmail.org") > (test-visible-output)' > test_expect_equal_file $EXPECTED/notmuch-show-decrypted-message OUTPUT > > +test_begin_subtest "show encrypted rfc822 message" > +test_subtest_known_broken > +test_emacs '(notmuch-show "id:encrypted-rfc822-attachment@crypto.notmuchmail.org") > + (test-visible-output)' > +fgrep '!!!' OUTPUT > OUTPUT.err > +test_expect_equal_file /dev/null OUTPUT.err In this case one could just do test_expect_code 1 "fgrep -q '!!!' OUTPUT" (these file comparisons w/ /dev/null (currently 5) annoys me ;/ so if I am biased the current suggestion is fine) Tomi > + > test_begin_subtest "show undecryptable message" > test_emacs '(notmuch-show "id:simple-encrypted@crypto.notmuchmail.org") > (test-visible-output)' > -- > 2.30.2