From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4KGDItCj4GFEJgEAgWs5BA (envelope-from ) for ; Thu, 13 Jan 2022 23:12:32 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id +LooH9Cj4GFWJwEAauVa8A (envelope-from ) for ; Thu, 13 Jan 2022 23:12:32 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 59D5D126D9 for ; Thu, 13 Jan 2022 23:12:32 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 6269B5F71D; Thu, 13 Jan 2022 22:12:28 +0000 (UTC) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [185.185.170.37]) by mail.notmuchmail.org (Postfix) with ESMTPS id B4A095F70A for ; Thu, 13 Jan 2022 22:12:24 +0000 (UTC) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id DB3F11B000F7; Fri, 14 Jan 2022 00:12:23 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1642111944; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mAqdPTOKp9v2JR+/JBHwXPKkvg8YaJKJtIhoTx4U5rg=; b=aj2CDfSapjifzLWEMMHPT+SPPTEs0XPygYOEGDivOIusCzr6IY00G8vYm4PXaR3eYwchDZ p+1qM01gPycS90r96v5A8pPKRRUo+3sbVHmUGTGGXQb2NWJ3o407DsQbxIUysPulsnPODX G122NOQuZsg7AZZo4aXZdba3skC1AE2GgUyj4/5gfISes6hbeusPRmqi0pKQXyVyHLkdB3 QfgYPdRnkSnTcXoCdmWdMOLA7dTbvHJZmkVl/MN8HnYeY5qkd1+0y2lUTqP9MmYnG0OTUQ IBsZtyuzYDAWy9PKlb1v89tJY3tnKd60aYKo4ACutRiK43etBZrbPFwE6SxLpg== From: Tomi Ollila To: LdBeth , Notmuch Mailing List Subject: Re: [PATCH] emacs/notmuch-tag.el: add xmlns attribute to svg icons In-Reply-To: References: User-Agent: Notmuch/0.33+54~gcaf4513 (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1642111944; a=rsa-sha256; cv=none; b=mu61cjlv2hH6K/TjJgSjrFhp96mlSU5RZiAlM/+kEsxTn+KO4WnnkTkX6kRu3DhgcRi1+h gPqZDbaqMh2YCZUInDYqKu53v1fCXpTg2MUSNoS6hUjg10qvhhv12bgs+xu4t5iWaRZkla LMFBJg929YbVGSKs4fcNfXhwWZkmXFe60FxWAjeMaJvqhFwzToup6wTGuNADaFNHynLoB+ N60hmHgK0LdCW2XvJGTMxPDt3/wDHIID3/q2fsSQSAcEETRCWbUR5N2U+tONz11F1To/iZ LIrTSuB55YfqNH2vOeDaoveKjhfdAg5+koRTEvmNHfbcCb5FfjGJtc5YRdD+lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1642111944; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mAqdPTOKp9v2JR+/JBHwXPKkvg8YaJKJtIhoTx4U5rg=; b=Z5VXBbIWbbwMmUmpniyWYKY38GYU+bvm2YDMCDHM139AdnsVNkAkGeUS/pzFY/LN7Bv+92 OtppzPcuGd+sFYvRkgf10PzxxyNLVkBHdZNTSWXt/SuJIZK+xaVcgtUzT8+uVu5M0hZQLn 2LHxHyZGG76g0XFP0eNfxjJ+w418dBJQuu0CM1mQBZkyE+itkUS+pVcCYzSFD0mwu9K/la po3izmOefCo1X3BH83LoipHQKOGgmRlD0zCwy7UUhVgGlrJRTCXCNcGkLNm/f5fEN6w2+5 EK43SlBh7/Z4JSnIQw/JGOM+QuDli8E/WQnvLU0UqNDidlgfBZooKfV3S9S+xQ== Message-ID-Hash: YMBGITLX5D2AUDPN6DI4D3O75VJJPVFR X-Message-ID-Hash: YMBGITLX5D2AUDPN6DI4D3O75VJJPVFR X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642111952; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=2lsgKLkZJCYojZPJQ6lmT26ttWlj9aEsolyHTHhCrT8=; b=tRlHHTXikeBUuUOMNeGFgGe+WJPq4ev5dPX4GrnwmZoYc2wf19VUqd+bjSjxfXn99KGu+B 7gqgSUT/GVU/RpCjXInSgF7abG6vs1D2YqFqR8VQEYw5ExBfcDBhx04VJv7NKP4RL07ben yHDdN68WjI7pqnOIE5P/FlXT9KZUyx/ctFirrN8CRinpIgjEdW72841aTxJXSMKBa2vj14 xGdykfinrVOwFDFMLyddW4jUI04xLm5+EZPibUIdedSiZgLt9riMhkTlmTfmF1oKbU6je2 3/wujU+0XwXkZMD6IVvgvs28Dmmz2hoWs9MVmfeo9C3Npvv7Fb64FNSX4QTgKw== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1642111952; a=rsa-sha256; cv=fail; b=MMWwyimVYymGV4wc+Fx+VSqCQWWOB6yDt1Ili7O76FX+5xTaZcXhagLEnwJ+sgnC9a2QKr Uop9fOJu1GXaaHVJmB35bta9VZrKOP63M5hgfm/mBNTy0aOy2Gb89tybVl9du/O6Y1WPNy +FzOlgEs9rDoUldTjCZ0Jg0LPnc5mo2ndQ+/U3adWFb3uumVeygmA9swiAROsFjYKNr/qB +ms3Imf0yrhfsMWPGfrjFjH6X5p74FdF/nm19z30YrjFgH9pdkxizlhzD6oQpVGsIrmAm5 CWiMK1wTtSsD6AJ5v9Ayre/yi5htK0o36/V2KpBJxnyYXT2Z3/KyekD0HAbZug== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=aj2CDfSa; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -0.30 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=aj2CDfSa; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 59D5D126D9 X-Spam-Score: -0.30 X-Migadu-Scanner: scn0.migadu.com X-TUID: UhDQ6h4p1v72 On Thu, Jan 13 2022, LdBeth wrote: > emacs-mac that compiled with OS X system API instead of imagemagick > cannot render svg without xmlns correctly [1]. Referecing Imagemagick in this commit message may be incorrect, otherwise content looks good. In case of Emacs 26, when imagemagick is used to render svg images, transparent background is rendered white. The alternative "librsvg" (if I remember correctly, does not do that). I've tried hard to scale svg images while doing notmuch-logo.svg but it always failed, when using imagemagick background got white (bad when using dark background), and when not using, image got clipped instead of resized. So, I cannot say for sure imagemagick is not used to render these icons, but I'd guess so. Btw: when using emacs 27, and pressing '+' or '-' when cursor is on the (svg) notmuch logo in notmuch-hello window, background does not render white, as happened with emacs 26. Tomi > > [1]: id:tencent_127AA231767438AC66FEE4DDB4BBF51DF909@qq.com > --- > emacs/notmuch-tag.el | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el > index 145f309f..8af09e68 100644 > --- a/emacs/notmuch-tag.el > +++ b/emacs/notmuch-tag.el > @@ -241,7 +241,7 @@ DATA is the content of an SVG picture (e.g., as returned by > "Return SVG data representing a star icon. > This can be used with `notmuch-tag-format-image-data'." > " > - > + > > d=\"m 290.25762,334.31206 -17.64143,-11.77975 -19.70508,7.85447 5.75171,-20.41814 -13.55925,-16.31348 21.19618,-0.83936 11.325,-17.93675 7.34825,19.89939 20.55849,5.22795 -16.65471,13.13786 z\" > @@ -254,7 +254,7 @@ This can be used with `notmuch-tag-format-image-data'." > "Return SVG data representing an empty star icon. > This can be used with `notmuch-tag-format-image-data'." > " > - > + > > d=\"m 290.25762,334.31206 -17.64143,-11.77975 -19.70508,7.85447 5.75171,-20.41814 -13.55925,-16.31348 21.19618,-0.83936 11.325,-17.93675 7.34825,19.89939 20.55849,5.22795 -16.65471,13.13786 z\" > @@ -267,7 +267,7 @@ This can be used with `notmuch-tag-format-image-data'." > "Return SVG data representing a tag icon. > This can be used with `notmuch-tag-format-image-data'." > " > - > + > > d=\"m 0.44642857,1040.9336 12.50000043,0 2.700893,3.6161 -2.700893,3.616 -12.50000043,0 z\" > -- > 2.20.1