unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: LdBeth <andpuke@foxmail.com>
Cc: Notmuch Mailing List <notmuch@notmuchmail.org>
Subject: Re: [PATCH v2] emacs/notmuch-tag.el: add xmlns attribute to svg icons
Date: Fri, 14 Jan 2022 22:21:10 +0200	[thread overview]
Message-ID: <m235lq83wp.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <tencent_D5854E8155F39F885B5377A3A37FCF39C606@qq.com>

On Fri, Jan 14 2022, LdBeth wrote:

> emacs-mac that compiled with OS X system API for image display
> support cannot correctly render svg without xmlns parameter [1].

LGTM.

Tomi

>
> [1]: id:tencent_127AA231767438AC66FEE4DDB4BBF51DF909@qq.com
> ---
>  emacs/notmuch-tag.el | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el
> index 145f309f..8af09e68 100644
> --- a/emacs/notmuch-tag.el
> +++ b/emacs/notmuch-tag.el
> @@ -241,7 +241,7 @@ DATA is the content of an SVG picture (e.g., as returned by
>    "Return SVG data representing a star icon.
>  This can be used with `notmuch-tag-format-image-data'."
>    "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"no\"?>
> -<svg version=\"1.1\" width=\"16\" height=\"16\">
> +<svg version=\"1.1\" width=\"16\" height=\"16\" xmlns=\"http://www.w3.org/2000/svg\">
>    <g transform=\"translate(-242.81601,-315.59635)\">
>      <path
>         d=\"m 290.25762,334.31206 -17.64143,-11.77975 -19.70508,7.85447 5.75171,-20.41814 -13.55925,-16.31348 21.19618,-0.83936 11.325,-17.93675 7.34825,19.89939 20.55849,5.22795 -16.65471,13.13786 z\"
> @@ -254,7 +254,7 @@ This can be used with `notmuch-tag-format-image-data'."
>    "Return SVG data representing an empty star icon.
>  This can be used with `notmuch-tag-format-image-data'."
>    "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"no\"?>
> -<svg version=\"1.1\" width=\"16\" height=\"16\">
> +<svg version=\"1.1\" width=\"16\" height=\"16\" xmlns=\"http://www.w3.org/2000/svg\">
>    <g transform=\"translate(-242.81601,-315.59635)\">
>      <path
>         d=\"m 290.25762,334.31206 -17.64143,-11.77975 -19.70508,7.85447 5.75171,-20.41814 -13.55925,-16.31348 21.19618,-0.83936 11.325,-17.93675 7.34825,19.89939 20.55849,5.22795 -16.65471,13.13786 z\"
> @@ -267,7 +267,7 @@ This can be used with `notmuch-tag-format-image-data'."
>    "Return SVG data representing a tag icon.
>  This can be used with `notmuch-tag-format-image-data'."
>    "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"no\"?>
> -<svg version=\"1.1\" width=\"16\" height=\"16\">
> +<svg version=\"1.1\" width=\"16\" height=\"16\" xmlns=\"http://www.w3.org/2000/svg\">
>    <g transform=\"translate(0,-1036.3622)\">
>      <path
>         d=\"m 0.44642857,1040.9336 12.50000043,0 2.700893,3.6161 -2.700893,3.616 -12.50000043,0 z\"
> -- 
> 2.20.1

  reply	other threads:[~2022-01-14 20:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-13 21:19 [PATCH] emacs/notmuch-tag.el: add xmlns attribute to svg icons LdBeth
2022-01-13 22:12 ` Tomi Ollila
2022-01-14 13:15   ` [PATCH v2] " LdBeth
2022-01-14 20:21     ` Tomi Ollila [this message]
2022-01-14 21:15     ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m235lq83wp.fsf@guru.guru-group.fi \
    --to=tomi.ollila@iki.fi \
    --cc=andpuke@foxmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).