From: Tomi Ollila <tomi.ollila@iki.fi>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: cleanup and simplify `notmuch-show-archive-thread' and related functions
Date: Thu, 09 Feb 2012 09:54:30 +0200 [thread overview]
Message-ID: <m21uq4saq1.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1328719731-13402-1-git-send-email-dmitry.kurochkin@gmail.com>
On Wed, 8 Feb 2012 20:48:51 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> Recent changes in notmuch-show tagging introduced some code
> duplication. The patch cleanups and simplifies
> `notmuch-show-archive-thread' function by using
> `notmuch-show-tag-all', no longer used function are removed. After
> the change, `notmuch-show-archive-thread' function becomes symmetric
> with `notmuch-show-archive-message'.
>
> A side effect of these changes is that `notmuch-show-archive-thread'
> no longer calls "notmuch tag" for each message in the thread.
> ---
+1, works fine, is fast
Tomi
next prev parent reply other threads:[~2012-02-09 7:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 16:48 [PATCH] emacs: cleanup and simplify `notmuch-show-archive-thread' and related functions Dmitry Kurochkin
2012-02-09 7:54 ` Tomi Ollila [this message]
2012-02-09 8:10 ` David Edmondson
2012-02-12 18:08 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m21uq4saq1.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=dmitry.kurochkin@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).