unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] contrib: pick: Do not indent messages in the message pane
Date: Mon, 17 Dec 2012 18:26:53 +0200	[thread overview]
Message-ID: <m21ueoir02.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1355085019-18534-1-git-send-email-markwalters1009@gmail.com>

On Sun, Dec 09 2012, Mark Walters wrote:

> Currently pick just uses notmuch-show to display messages in the
> message pane: this means that they get indented just as show
> would. However, since pick is only displaying one message at a time
> there is no need to indent so override the indentation.
> ---

LGTM.

Tomi

>
> Thanks to jrollins for the suggestion. It would also be possible to
> indent the headers (as a visual clue to how deep we are in the thread)
> or to make this customisable. However there is no point in doing that
> unless someone says they would prefer something else.
>
> Best wishes
>
> Mark
>
>
>
>  contrib/notmuch-pick/notmuch-pick.el |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
> index cf026af..ce5d0d4 100644
> --- a/contrib/notmuch-pick/notmuch-pick.el
> +++ b/contrib/notmuch-pick/notmuch-pick.el
> @@ -337,8 +337,10 @@ Does NOT change the database."
>        (setq notmuch-pick-message-window
>  	    (split-window-vertically (/ (window-height) 4)))
>        (with-selected-window notmuch-pick-message-window
> -	(setq current-prefix-arg '(4))
> -	(setq buffer (notmuch-show id nil nil nil)))
> +	;; Since we are only displaying one message do not indent.
> +	(let ((notmuch-show-indent-messages-width 0))
> +	  (setq current-prefix-arg '(4))
> +	  (setq buffer (notmuch-show id nil nil nil))))
>        (notmuch-pick-tag-update-display (list "-unread"))
>        (setq notmuch-pick-message-buffer buffer))))
>  
> -- 
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

  reply	other threads:[~2012-12-17 16:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-09 20:30 [PATCH] contrib: pick: Do not indent messages in the message pane Mark Walters
2012-12-17 16:26 ` Tomi Ollila [this message]
2012-12-17 17:51 ` Jameson Graef Rollins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m21ueoir02.fsf@guru.guru-group.fi \
    --to=tomi.ollila@iki.fi \
    --cc=markwalters1009@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).