From: Tomi Ollila <tomi.ollila@iki.fi>
To: Daniel Bergey <bergey@alum.mit.edu>,
Notmuch Mail List <notmuch@notmuchmail.org>,
Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>
Cc: Chris Thachuk <chris.thachuk@cs.ox.ac.uk>
Subject: Re: [PATCH] emacs: functions to import sender or recipient into BBDB
Date: Tue, 19 Feb 2013 09:24:51 +0200 [thread overview]
Message-ID: <m21uccsr3w.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <87ip64gdpg.fsf@chladni.lan>
On Thu, Feb 07 2013, Daniel Bergey wrote:
>From a show buffer, notmuch-bbdb/snarf-from imports the sender into
> bbdb. notmuch-bbdb/snarf-to imports all recipients. Newly imported
> concacts are reported in the minibuffer / Messages buffer.
>
> Both functions use the BBDB parser to recognize email address formats.
> ---
> Following discussion upthread, I put everything in notmuch-address. I
> renamed the functions to put notmuch before bbdb. And I replaced the
> horrid comma-splitting from my first version with the functions BBDB
> provides for parsing email headers.
>
> It looks as though Reply-To is not exposed in the :headers plist. I
> assume the Resent-* headers are not, either. Therefore none of these
> are imported (nil entries in notmuch-bbdb/header-by-name). They would be
> easy to add if the plist is expanded.
>
> Thanks, and sorry it's taken me so long to get back to this patch.
From my understanding the code looks pretty good; I have only some
whitespace consistency things that jist briefly passes the threshold
to mention -- comments inline.
But before doing a potential cleanup patch the users of notmuch-bbdb
please test and comment
> emacs/notmuch-address.el | 43 +++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
>
> diff --git a/emacs/notmuch-address.el b/emacs/notmuch-address.el
> index 2bf762b..8d5f727 100644
> --- a/emacs/notmuch-address.el
> +++ b/emacs/notmuch-address.el
> @@ -98,4 +98,47 @@ line."
>
> ;;
This ';;' used to be 3rd last line in notmuch-address.el.
Running 'tail -n 5 emacs/*.el' reveals that it is (somewhat) consistent
to use it as "separator" between code above and (provide 'notmuch-...)
that follows.
> +;; functions to add sender / recipients to BBDB
> +
> +(defun notmuch-bbdb/snarf-headers (headers)
> + ;; Helper function to avoid code duplication in the two below
> + ;; headers should have the same format as bbdb-get-addresses-headers
> +
> + ;; bbdb-get-addresses reads these
> + ;; Ugh, pass-by-global
> + (let ((addrs (bbdb-get-addresses nil nil 'notmuch-bbdb/get-header-content))
> + (bbdb-get-addresses-headers headers) ; headers to read
> + (bbdb-gag-messages t) ; suppress m/n processed message
> + )
> + (bbdb-update-records addrs t t)))
> +
> +(defun notmuch-bbdb/snarf-from ()
> + "Import the sender of the current message into BBDB"
> + (interactive)
> + (notmuch-bbdb/snarf-headers
> + (list (assoc 'authors bbdb-get-addresses-headers))))
Two spaces above.
> +
> +(defun notmuch-bbdb/snarf-to ()
> + "Import all recipients of the current message into BBDB"
> + (interactive)
> + (notmuch-bbdb/snarf-headers
> + (list (assoc 'recipients bbdb-get-addresses-headers))))
Ditto.
> +
> +(defvar notmuch-bbdb/header-by-name
> + ;; both are case sensitive
> + '( ("From" . :From)
> + ("To" . :To)
> + ("CC" . :Cc)
> + ("BCC" . :Bcc)
> + ("Resent-From" . nil)
> + ("Reply-To" . nil)
> + ("Resent-To" . nil)
> + ("Resent-CC" . nil))
> + "Alist for dispatching header symbols as used by notmuch-show-get-header
> +from strings as used by bbdb-get-addresses")
> +
> +(defun notmuch-bbdb/get-header-content (name)
> + (notmuch-show-get-header (cdr (assoc name notmuch-bbdb/header-by-name))))
> +
> +
2 empty lines --- somewhat consistent with notmuch-lib.el ... but
not with anything else ;D
> (provide 'notmuch-address)
> --
> 1.7.10.4
next prev parent reply other threads:[~2013-02-19 7:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 20:09 [PATCH] emacs: functions to import sender or recipient into BBDB Daniel Bergey
2012-10-19 22:52 ` Ethan Glasser-Camp
2012-10-20 9:14 ` Tomi Ollila
2012-10-20 18:23 ` Jameson Graef Rollins
2012-10-20 19:35 ` Tomi Ollila
2012-10-20 21:10 ` Jani Nikula
2012-10-21 12:16 ` Tomi Ollila
2012-11-19 0:08 ` Daniel Bergey
2013-02-07 18:51 ` Daniel Bergey
2013-02-19 7:24 ` Tomi Ollila [this message]
2013-03-31 18:20 ` Daniel Bergey
2013-03-31 18:40 ` Tomi Ollila
2013-04-06 11:37 ` David Bremner
2013-04-06 19:43 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m21uccsr3w.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=bergey@alum.mit.edu \
--cc=chris.thachuk@cs.ox.ac.uk \
--cc=ethan.glasser.camp@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).