[PATCH] emacs: bugfix unquoted symbol

[PATCH] emacs: bugfix unquoted symbol

[Mark Walters]

In the recent changes for search order handling the default-value of
notmuch-search-oldest-first was used. However, default-value needs a
symbol so the symbol-name needs to be quoted.

This missing quote was causing strange sort-orders in some cases.
---

I think this is clearly correct (and what was intended) and it seems
to work as expected.

Best wishes

Mark




 emacs/notmuch.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index 4de6229..0ff248b 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -888,7 +888,7 @@ the configured default sort order."
     nil
     ;; Use the default search order (if we're doing a search from a
     ;; search buffer, ignore any buffer-local overrides)
-    (default-value notmuch-search-oldest-first)))
+    (default-value 'notmuch-search-oldest-first)))
 
   (let* ((query (or query (notmuch-read-query "Notmuch search: ")))
 	 (buffer (get-buffer-create (notmuch-search-buffer-title query))))
-- 
1.7.9.1

Re: [PATCH] emacs: bugfix unquoted symbol

[Austin Clements]

Definitely LGTM.

Quoth Mark Walters on Sep 14 at  9:17 pm:
> In the recent changes for search order handling the default-value of
> notmuch-search-oldest-first was used. However, default-value needs a
> symbol so the symbol-name needs to be quoted.
> 
> This missing quote was causing strange sort-orders in some cases.
> ---
> 
> I think this is clearly correct (and what was intended) and it seems
> to work as expected.
> 
> Best wishes
> 
> Mark
> 
> 
> 
> 
>  emacs/notmuch.el |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
> index 4de6229..0ff248b 100644
> --- a/emacs/notmuch.el
> +++ b/emacs/notmuch.el
> @@ -888,7 +888,7 @@ the configured default sort order."
>      nil
>      ;; Use the default search order (if we're doing a search from a
>      ;; search buffer, ignore any buffer-local overrides)
> -    (default-value notmuch-search-oldest-first)))
> +    (default-value 'notmuch-search-oldest-first)))
>  
>    (let* ((query (or query (notmuch-read-query "Notmuch search: ")))
>  	 (buffer (get-buffer-create (notmuch-search-buffer-title query))))

Re: [PATCH] emacs: bugfix unquoted symbol

[Tomi Ollila]

On Sat, Sep 14 2013, Mark Walters <markwalters1009@gmail.com> wrote:

> In the recent changes for search order handling the default-value of
> notmuch-search-oldest-first was used. However, default-value needs a
> symbol so the symbol-name needs to be quoted.
>
> This missing quote was causing strange sort-orders in some cases.
> ---
>
> I think this is clearly correct (and what was intended) and it seems
> to work as expected.

Marked ready.

>
> Best wishes
>
> Mark
>

Tomi

>
>
>
>  emacs/notmuch.el |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
> index 4de6229..0ff248b 100644
> --- a/emacs/notmuch.el
> +++ b/emacs/notmuch.el
> @@ -888,7 +888,7 @@ the configured default sort order."
>      nil
>      ;; Use the default search order (if we're doing a search from a
>      ;; search buffer, ignore any buffer-local overrides)
> -    (default-value notmuch-search-oldest-first)))
> +    (default-value 'notmuch-search-oldest-first)))
>  
>    (let* ((query (or query (notmuch-read-query "Notmuch search: ")))
>  	 (buffer (get-buffer-create (notmuch-search-buffer-title query))))
> -- 
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: bugfix unquoted symbol

[David Bremner]

Mark Walters <markwalters1009@gmail.com> writes:

> In the recent changes for search order handling the default-value of
> notmuch-search-oldest-first was used. However, default-value needs a
> symbol so the symbol-name needs to be quoted.

pushed

d