From: Tomi Ollila <tomi.ollila@iki.fi>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: bugfix unquoted symbol
Date: Sun, 15 Sep 2013 10:32:24 +0300 [thread overview]
Message-ID: <m21u4qa6bb.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1379189827-21363-1-git-send-email-markwalters1009@gmail.com>
On Sat, Sep 14 2013, Mark Walters <markwalters1009@gmail.com> wrote:
> In the recent changes for search order handling the default-value of
> notmuch-search-oldest-first was used. However, default-value needs a
> symbol so the symbol-name needs to be quoted.
>
> This missing quote was causing strange sort-orders in some cases.
> ---
>
> I think this is clearly correct (and what was intended) and it seems
> to work as expected.
Marked ready.
>
> Best wishes
>
> Mark
>
Tomi
>
>
>
> emacs/notmuch.el | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
> index 4de6229..0ff248b 100644
> --- a/emacs/notmuch.el
> +++ b/emacs/notmuch.el
> @@ -888,7 +888,7 @@ the configured default sort order."
> nil
> ;; Use the default search order (if we're doing a search from a
> ;; search buffer, ignore any buffer-local overrides)
> - (default-value notmuch-search-oldest-first)))
> + (default-value 'notmuch-search-oldest-first)))
>
> (let* ((query (or query (notmuch-read-query "Notmuch search: ")))
> (buffer (get-buffer-create (notmuch-search-buffer-title query))))
> --
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2013-09-15 7:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-14 20:17 [PATCH] emacs: bugfix unquoted symbol Mark Walters
2013-09-14 20:55 ` Austin Clements
2013-09-15 7:32 ` Tomi Ollila [this message]
2013-09-15 12:09 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m21u4qa6bb.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).