From: Tomi Ollila <tomi.ollila@iki.fi>
To: Charles Celerier <cceleri@cs.stanford.edu>, notmuch@notmuchmail.org
Subject: Re: [PATCH 4/5] T360-symbol-hiding: Added code to support testing on Mac OS X.
Date: Tue, 06 May 2014 21:21:43 +0300 [thread overview]
Message-ID: <m21tw6ix8o.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1399395748-44920-5-git-send-email-cceleri@cs.stanford.edu>
On Tue, May 06 2014, Charles Celerier <cceleri@cs.stanford.edu> wrote:
> The Mac OS X platform uses *.dylib object files instead of *.so object
> files for linking. Adding the path to notmuch.dylib to the end of
> DYLD_FALLBACK_LIBRARY_PATH has a similar effect to adding the path to
> notmuch.so to LD_LIBRARY_PATH on most Linux-based platforms (see
> dyld(1)).
This series LGTM. I don't understand this difference suffixing
DYLD_FALLBACK_LIBRARY_PATH with $TEST_DIRECTORY/../lib on Mac OS X
compared to prefixing LD_LIBRARY_PATH with the same on other
systems, so I take your word that it works :D
Tomi
>
> Signed-off-by: Charles Celerier <cceleri@cs.stanford.edu>
> ---
> test/T360-symbol-hiding.sh | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/test/T360-symbol-hiding.sh b/test/T360-symbol-hiding.sh
> index 636ec91..97c734a 100755
> --- a/test/T360-symbol-hiding.sh
> +++ b/test/T360-symbol-hiding.sh
> @@ -12,7 +12,14 @@ test_description='exception symbol hiding'
> . ./test-lib.sh
>
> run_test(){
> - result=$(LD_LIBRARY_PATH="$TEST_DIRECTORY/../lib${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}" $TEST_DIRECTORY/symbol-test 2>&1)
> + case $(uname -s) in
> + Darwin)
> + result=$(DYLD_FALLBACK_LIBRARY_PATH="${DYLD_FALLBACK_LIBRARY_PATH:+$DYLD_FALLBACK_LIBRARY_PATH:}$TEST_DIRECTORY/../lib" $TEST_DIRECTORY/symbol-test 2>&1)
> + ;;
> + *)
> + result=$(LD_LIBRARY_PATH="$TEST_DIRECTORY/../lib${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}" $TEST_DIRECTORY/symbol-test 2>&1)
> + ;;
> + esac
> }
>
> output="A Xapian exception occurred opening database: Couldn't stat 'fakedb/.notmuch/xapian'
> --
> 1.8.5.2 (Apple Git-48)
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2014-05-06 18:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 17:02 [PATCH 0/5] Improving portability to Mac OS X Charles Celerier
2014-05-06 17:02 ` [PATCH 1/5] test/Makefile.local: Added configured TALLOC_LDFLAGS Charles Celerier
2014-05-06 17:02 ` [PATCH 2/5] configure, test: Added variables for paths to true and false Charles Celerier
2014-05-06 17:02 ` [PATCH 3/5] atomicity.gdb: Allow breakpoint symbols to be resolved later Charles Celerier
2014-05-06 17:02 ` [PATCH 4/5] T360-symbol-hiding: Added code to support testing on Mac OS X Charles Celerier
2014-05-06 17:02 ` [PATCH 5/5] T360-symbol-hiding: Use nm instead of objdump Charles Celerier
2014-05-06 18:21 ` Tomi Ollila [this message]
2014-05-06 18:35 ` [PATCH 4/5] T360-symbol-hiding: Added code to support testing on Mac OS X Charles Celerier
2014-05-06 19:09 ` Tomi Ollila
2014-05-06 18:26 ` [PATCH 3/5] atomicity.gdb: Allow breakpoint symbols to be resolved later Tomi Ollila
2014-05-08 12:32 ` [PATCH 2/5] configure, test: Added variables for paths to true and false David Bremner
2014-05-08 15:00 ` Charles Celerier
2014-05-08 22:14 ` David Bremner
2014-05-17 21:46 ` [PATCH 1/5] test/Makefile.local: Added configured TALLOC_LDFLAGS David Bremner
2014-05-07 3:50 ` [PATCH v2 4/5] T360-symbol-hiding: Added code to support testing on Mac OS X Charles Celerier
2014-05-07 3:50 ` [PATCH v2 5/5] T360-symbol-hiding: Use nm instead of objdump Charles Celerier
2014-05-08 13:06 ` David Bremner
2014-05-08 15:03 ` Charles Celerier
2014-05-08 22:07 ` David Bremner
2014-05-09 1:20 ` Charles Celerier
2014-05-10 9:49 ` David Bremner
2014-05-10 14:55 ` Charles Celerier
2014-07-12 19:00 ` David Bremner
2014-07-13 15:36 ` [PATCH v2 4/5] T360-symbol-hiding: Added code to support testing on Mac OS X David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m21tw6ix8o.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=cceleri@cs.stanford.edu \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).