From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] test: check for debug symbols in notmuch
Date: Fri, 03 Oct 2014 23:49:31 +0300 [thread overview]
Message-ID: <m21tqoho9w.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1412367730-25890-1-git-send-email-david@tethera.net>
On Fri, Oct 03 2014, David Bremner <david@tethera.net> wrote:
> In the future, tests may rely on debug symbols being present in
> notmuch, so we plan to switch the default flags.
>
> The main purpose of this test is to help explain the perhaps
> mysterious failures of other tests which rely on symbols being
> present.
> ---
series LGTM.
> test/T000-basic.sh | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/test/T000-basic.sh b/test/T000-basic.sh
> index ebbb6d2..bf08f3e 100755
> --- a/test/T000-basic.sh
> +++ b/test/T000-basic.sh
> @@ -91,4 +91,9 @@ test_expect_equal \
> "$(dirname ${TEST_DIRECTORY})" \
> "$(echo $PATH|cut -f1 -d: | sed -e 's,/test/valgrind/bin$,,')"
>
> +test_begin_subtest 'notmuch is compiled with debugging symbols'
> +test_subtest_known_broken
> +readelf --sections $(which notmuch) | grep \.debug
> +test_expect_equal 0 $?
> +
> test_done
> --
> 2.1.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2014-10-03 20:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 20:22 [PATCH 1/2] test: check for debug symbols in notmuch David Bremner
2014-10-03 20:22 ` [PATCH 2/2] configure: add debug flags by default David Bremner
2014-10-03 20:49 ` Tomi Ollila [this message]
2014-10-05 5:32 ` [PATCH 1/2] test: check for debug symbols in notmuch David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m21tqoho9w.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).