From: David Edmondson <dme@dme.org>
To: David Bremner <david@tethera.net>,
David Bremner <david@tethera.net>,
notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs/address: use member instead of memq to check for pair
Date: Wed, 13 Sep 2017 08:55:31 +0100 [thread overview]
Message-ID: <m21snbnibw.fsf@dme.org> (raw)
In-Reply-To: <20170913013146.32286-1-david@tethera.net>
Looks good.
On Tuesday, 2017-09-12 at 22:31:46 -0300, David Bremner wrote:
> Quoting from the elisp reference:
>
> For other types (e.g., lists, vectors, strings), two arguments
> with the same contents or elements are not necessarily ‘eq’ to
> each other.
>
> Thanks to "Attic Hermit" for the fix.
> ---
> emacs/notmuch-address.el | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch-address.el b/emacs/notmuch-address.el
> index f937e708..64887a43 100644
> --- a/emacs/notmuch-address.el
> +++ b/emacs/notmuch-address.el
> @@ -159,7 +159,7 @@ matching `notmuch-address-completion-headers-regexp'.
> #'notmuch-address-expand-name)))
> (when setup-company
> (notmuch-company-setup))
> - (unless (memq pair message-completion-alist)
> + (unless (member pair message-completion-alist)
> (setq message-completion-alist
> (push pair message-completion-alist)))))
>
> --
> 2.14.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
dme.
--
And the sign said: long haired freaky people need not apply.
next prev parent reply other threads:[~2017-09-13 7:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 4:21 [BUG] Notmuch keeps adding notmuch-address-expand-name to message-completion-alist Attic Hermit
2017-09-11 10:14 ` David Bremner
2017-09-11 10:50 ` Attic Hermit
2017-09-13 1:31 ` [PATCH] emacs/address: use member instead of memq to check for pair David Bremner
2017-09-13 7:55 ` David Edmondson [this message]
2017-09-13 12:07 ` David Bremner
2017-09-13 12:48 ` Attic Hermit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m21snbnibw.fsf@dme.org \
--to=dme@dme.org \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).