From: David Edmondson <dme@dme.org>
To: Sean Whitton <spwhitton@spwhitton.name>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: notmuch-search: avoid wiping out buffer-local variables
Date: Wed, 22 Jul 2020 16:46:41 +0100 [thread overview]
Message-ID: <m21rl3v9ge.fsf@dme.org> (raw)
In-Reply-To: <20200722151132.28299-1-spwhitton@spwhitton.name>
On Wednesday, 2020-07-22 at 08:11:32 -07, Sean Whitton wrote:
>
Reviewed-by: David Edmondson <dme@dme.org>
> ---
> emacs/notmuch.el | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
> index dd18f2e1..c97997fe 100644
> --- a/emacs/notmuch.el
> +++ b/emacs/notmuch.el
> @@ -987,7 +987,11 @@ the configured default sort order."
> (if no-display
> (set-buffer buffer)
> (switch-to-buffer buffer))
> - (notmuch-search-mode)
> + ;; avoid wiping out third party buffer-local variables in the case
> + ;; where we're just refreshing or changing the sort order of an
> + ;; existing search results buffer
> + (unless (eq major-mode 'notmuch-search-mode)
> + (notmuch-search-mode))
> ;; Don't track undo information for this buffer
> (set 'buffer-undo-list t)
> (set 'notmuch-search-query-string query)
> --
> 2.27.0
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org
dme.
--
Hello? Is anybody home? Well, you don't know me, but I know you.
next prev parent reply other threads:[~2020-07-22 15:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 23:03 notmuch.el: notmuch-search: avoid wiping out buffer-local variables Sean Whitton
2020-07-22 10:32 ` David Edmondson
2020-07-22 15:11 ` [PATCH] emacs: " Sean Whitton
2020-07-22 15:46 ` David Edmondson [this message]
2020-07-22 22:51 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m21rl3v9ge.fsf@dme.org \
--to=dme@dme.org \
--cc=notmuch@notmuchmail.org \
--cc=spwhitton@spwhitton.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).