From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id hAEfEm6bCWES6QAAgWs5BA (envelope-from ) for ; Tue, 03 Aug 2021 21:39:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 8Io7DW6bCWH8IQAA1q6Kng (envelope-from ) for ; Tue, 03 Aug 2021 19:39:26 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AE6361EC50 for ; Tue, 3 Aug 2021 21:39:25 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 689C22C09D; Tue, 3 Aug 2021 15:39:21 -0400 (EDT) Received: from lahtoruutu.iki.fi (unknown [IPv6:2a0b:5c81:1c1::37]) by mail.notmuchmail.org (Postfix) with ESMTPS id AED882C09B for ; Tue, 3 Aug 2021 15:39:19 -0400 (EDT) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id EAF9C1B0004B; Tue, 3 Aug 2021 22:39:07 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1628019548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ij67gGOpzznhwBqfVj3I4AjbDLWJEcPFtYYzi+Cv0F0=; b=PZhK3ljj9vRILguCXK+Pjxr1g2vC0G3GkMdn5kcKiR6fmkYZ8xz10WvdrPhGoLJei9MtW1 7e+rAXe8S78c+HOgp5UH0iTBT/6MJYxHPRhUXfZ80SCtBTcMaXOA9uu/LJNvtWbKPbx9MO JRAn7SeaFwxT8KnfrGv6GKB9S3dc12tPml+SHmqhy+QdLmOWt46+3g4XzyDEfTPMaoj2gI 5sXhERphP4Ppx4+YE6xQgjkd+27W70smte4RVOKO3qaGJyl7yuj994uhYAVrQa0GbLi4Xy uDX27i2TPHrO2Kx9BiVJ7Vztc5XLuzTvHWXIfTRvsSIrfVk4Fs6U10PVOXHTBg== From: Tomi Ollila To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH] test: aggregate-results updates In-Reply-To: <874kc814q8.fsf@tethera.net> References: <20210517081109.31897-1-tomi.ollila@iki.fi> <874kc814q8.fsf@tethera.net> User-Agent: Notmuch/0.32+21~gfdddd4c (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1628019548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ij67gGOpzznhwBqfVj3I4AjbDLWJEcPFtYYzi+Cv0F0=; b=gW6En+J2Y9L735BP+6DxZ0cttviD9WBTYxh1BU4eoyVb5Iim+LeqDds7yf0JLyqgCwlukt l4e+LRMRlhJrScCEOJjJwdhyLVmfPtIxscaUX4QY7VRKGE0RF9ulJbprMqTpKQQVfMdW03 c2NXFRNR8Wqm2ml2J+1IQ/IgjhOOvYd+7HaGwlBMnk7GegDWcXn/U2stPI6PPp6OUt2F4m uSIVE7SjQkoXmSfA0+00xuYwY9A/2UffG+vZoZxIi6ka0x/zbn4D6Qb9E0equdYXTyDTfb yGIWkLvWUgkPpRJCL/RRIVAz64Oe5mNnnFdUoXxCLc1XEKk7h0Tec3tSw6snvg== ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1628019548; a=rsa-sha256; cv=none; b=ogwC3Q/uFi7gpgQeK9rNRiasreY9O+qiMLv0FdmazeQMZezwjKAzuB6URgOKgkLnd6d7Sk RMUMJbH8ZZMQFZuwWXPbBLyZeA64VIbicsCZkGILUwoOo3YNFgT2ySQ5AAqA5OaG7xkcdO BtOeO5uwfECuacpzJnBJ8R93EDkw/F9Yg/EPKsasDflc/JibN6JNmnuySP22YFF5BcmeGB 2tMaIPkZaTDrS5hxjBkMDSmUJ/ssMDk7CANdp+RRHkF2lYzvL/i2fDfCaWqG0/LsXHxg6z 4ar3uGHp+UFxwOPCRgSDit6JeHoR3mk2SRKd3cwR0EDaM/OaBiARI0j1qlVqjw== Message-ID-Hash: THA3PKPTMCDRPCULPEEHVHRWCTZJJH6Q X-Message-ID-Hash: THA3PKPTMCDRPCULPEEHVHRWCTZJJH6Q X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1628019566; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=sYyI/6nAY5F314GEg/ctnClotoe6Qw8hjxANjfW/bCA=; b=iGTo1t+A6oN8GGsiE83bkGg59cmOr7GF5vXwTHHsOAG6WwvfYGFvfxja0L7LDMrbdg/1CT jlSDS9s6e9HIkjl9kMA7C/vGHJNcDuYSsaDLDtB8fEC1ENq+h1USOyDZGY3st0AOI4R2MT qIM0SddNH2IBDiljK1RYycP182t0MIQhoMbriqXfYnNNjtg1AnB56HkuWlllpS8pRSYNsw oPIAXTHa3c4DHY8UX1kEwRnt1817PgpgpHtxi/PAfRGwtUDmHca5qdj3nXrVJ0fWgBmiYA bfLOW9JOKuTqFgq3pup8jtaY31d/3WZJJjWhtb5m4g+4bWvgVMs6vKK7sM9fpQ== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1628019566; a=rsa-sha256; cv=fail; b=DsoPqdkxTDJXT02FP21G8fWOrOis1WhReQFAxu35o6xudvy2sOYj76oHQQ3LWT00JmqoNI lO/x28MWs7+tLUW59aPmR1fWr5G4yOBvlqMzbHYZ6vUBlplkcmeJRgyxxCMVDw/gBBFHmg jZgrLIgikfoWGmK6sxrPiwEMzwqLcDlHvC0AK8xpeQDhv4ddrlocPejCcg5727ytyuC2Tn e0e5VqryB0HncK0xjRHs/AdrJMVIc2/lDdDLCZ2vt7wxXBwEfzCzeTtpQXrMY3opj9b6Vt 9rUihel8/VOiUGRZocitOZru1lt8SM/BVVPSq1P+jz0Vt+C7EaCmgDyIZ0H29g== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=PZhK3ljj; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: 0.99 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=PZhK3ljj; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: AE6361EC50 X-Spam-Score: 0.99 X-Migadu-Scanner: scn0.migadu.com X-TUID: oFWGyooJc8bi On Mon, Aug 02 2021, David Bremner wrote: > Tomi Ollila writes: > >> - mkdir -p "$test_results_dir" >> + test -d "$test_results_dir" || mkdir "$test_results_dir" > > Lately I've notice some complaints during parallel test running > > mkdir: cannot create directory '/home/bremner/software/upstream/notmuch/test/test-results': File exists > > It seems like this change might be the culprit. Can you explain why it > was needed? ah, parallel test non-atomicity is the problem; fix would be to restore -p to mkdir (so it does not fail when another program executed mkdir between that test check and mkdir execution) i.e. test -d "$test_results_dir" || mkdir -p "$test_results_dir" Checking the dir with shell builtin drops need to execute mkdir in external process, which makes the tests run a bit snappier (in small increments). Tomi