From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id IA+/FnwoBGJ4EQEAgWs5BA (envelope-from ) for ; Wed, 09 Feb 2022 21:47:56 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id IOzBE3woBGLwMAEAauVa8A (envelope-from ) for ; Wed, 09 Feb 2022 21:47:56 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BDC942A3DF for ; Wed, 9 Feb 2022 21:47:55 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id C8ACA5F713; Wed, 9 Feb 2022 20:47:52 +0000 (UTC) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [185.185.170.37]) by mail.notmuchmail.org (Postfix) with ESMTPS id 0261E5F711 for ; Wed, 9 Feb 2022 20:47:49 +0000 (UTC) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 4BF621B0009A; Wed, 9 Feb 2022 22:47:48 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1644439668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qOcwVxtNR2MnHQjrysT/K+H77o4wuC5PMcUArtJ/498=; b=njrtcpHxzAc3SB9NbRplKJGg5AR8VeHU9jLRuyACpiErdyS6uZXmTCGSjK+JOTY6YckBBr YMc34pLL7SQKjWcW0mKOr/B1nFy758XfV1jtiefDrPiv/colozvAk4gPo1fNjfzCIJ+70Q 9EDKdXYX1ME5VuMY//F/dYEAn6KTFW2jz1ly12vkQ37rhtuwoAg9gmOnM126OkwwmYgg1J tSvzQmDDh+aygFZtgFsthocNPlWOPJ6WueEq4HZh+O0HWi1eOig1A0IqW0KkY2M2gvDEFg iM5ocbVPLgOgM2VtUee+8pv+JBy5W4NYybAN1IIHQ1ovVxFLKA1+z5w0vAfGqg== From: Tomi Ollila To: Michael J Gruber , notmuch@notmuchmail.org Subject: Re: [PATCH 1/4] test: correct comparison order in T380 In-Reply-To: <51ecae6ac67b360410790ce7ad208162ecc7d517.1644406756.git.git@grubix.eu> References: <51ecae6ac67b360410790ce7ad208162ecc7d517.1644406756.git.git@grubix.eu> User-Agent: Notmuch/0.35+4~ge2bb4cd (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1644439668; a=rsa-sha256; cv=none; b=SqnomV6kRihO552jKABsGOpbsZlyK542BzIDfMrss+R2V1yDDSW3Zu1GcRbrkofP361OrO Vh8ZS5vVD8r/J7eZ+0y0EAnbHcbc3EWwgdg/cV720/jRt9RSRgPiBe9vc2yMQv9ub+LWdt ggoo0dQHSo/+Vs5l6TsiIc1S0KRH2zNHdFI/d3THpflPT3p4eXA2mNkl01EsmAuNs35SXV nY/iYaCPd0yMWdxIKPH7osy8uTeQvA+nsaYaJVv8VsZp+ruiuDhepKcyW6WaLP6A4Y3Ujr sHQgrNJfNwfsWEKaoNqshoHLSV8zKiAKOJF1E9nnKnZzfg/NDbBYrTMjXZdAlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1644439668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qOcwVxtNR2MnHQjrysT/K+H77o4wuC5PMcUArtJ/498=; b=e/fuk52jcLrbpHrnNP+uTWdeiXQMFCnlKUxRfNKidMlX/cDE3RRMyUtK/VBR5Vw4CmjbZN TwRtP75zvbfciIi9WpWMEpqmLdh1NSuKM20EfffYY1Gs6BkKcxL//P6DNUJVKzt2V614hL tsizZdAXyleuX6jzuXNHp21kEiqC1yK77ZKUs4J8YaXfQWT6AubJ8DP8ZX/Wf8AtuWf73b s5wtofbxkR9Nb+79ZSW7gaRp39qUiIYau5kqiyc5Evrtv9VFz7vph8+bEsikVGwIRAGs5Z JI8E+Klndn11Uk978PkhPnN31V5iBEugQnBR5TilTWW+Z2rRPzrr/Tw4rKl+Lw== Message-ID-Hash: ILYQREVWWODYBTVVJXY2OQVPPZV7QV2G X-Message-ID-Hash: ILYQREVWWODYBTVVJXY2OQVPPZV7QV2G X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644439675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=QYg0CVbLSEqN+hOcWt2LkfCuQX8PjC02Q22j/xSq1Lg=; b=NVIK+wPueR3n0M811Hh3Auo86vxMmsQRx6azhtaf02hhgzcisjSn/pxIwXU9LEnwVIGdHV A1PfTahssizL8Y9Hyok3tXrIPwQMJbQ+lGyH0wymJ7/Dul4gaswCLctTI0J5xPDCyLImez f5xd7G206X7w6pLI5I3Vqx5E7FuzeQqzSBChWJXUX3w8a8HImv2sTbjt0at4z1dSRd4E0M CUMWlI8eJP7Q3PC/KKf2bjhOP5K4vWwinPQ8tgLe97bgPD4VQ3ZoRzmz9QJ5ExgvGI8F2/ VhmU73HeaM3gm0hua7bryp26nN6Dp0nEeQAbvXAxLhbDxhA8qtk7J/pDIFE5cQ== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1644439675; a=rsa-sha256; cv=fail; b=tg4GPIijKxybKp8uDdNC2WGUK2b2WPoFoF5y+Vd4rlOggHTSXGLR2Um+TBj3QhOpfFuKgV zIJ0vLMYe7d/iDDIuLYaMywUdXpTLiumQcArCyh9/fUao2il2j7NiQQBHO4jHW3Z9Lcq9r wVaP5hg2z0nLbMmzImFQDc9AAIs7n2iBqTKtcNimSNm9eSuQbY/WG+qCtqV7kqLrhiNw17 A9ZVlYQoQZhbmAjItLX7rVCb7YsHc4qPRbS9nqEC4urhdnyf2GBWPZ0q7duVLbiSb0PBnJ Zs7EM3OrICHkiFv9LhQeSPJZfVVIkIqTcijXSWGI3yppFT1UH1ftvJylLvCxTQ== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=njrtcpHx; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -1.82 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=njrtcpHx; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: BDC942A3DF X-Spam-Score: -1.82 X-Migadu-Scanner: scn0.migadu.com X-TUID: YJUsDIhhiQj+ On Wed, Feb 09 2022, Michael J. Gruber wrote: > Specifying test comparisons as "expected actual" gives a better readable > diff since the "-" indicates missing, "+" additional items compared to > the expectations. > > Signed-off-by: Michael J Gruber > --- > test/T380-atomicity.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/T380-atomicity.sh b/test/T380-atomicity.sh > index afe49d93..a6f1e037 100755 > --- a/test/T380-atomicity.sh > +++ b/test/T380-atomicity.sh > @@ -93,7 +93,7 @@ if test_require_external_prereq gdb; then > fi > > test_begin_subtest '"notmuch new" is idempotent under arbitrary aborts' > -test_expect_equal_file searchall expectall > +test_expect_equal_file expectall searchall Good in princible, but if things are like decade ago, we still have hundreds of these in wrong order -- if so, all should be changed for consistency. If I am wrong and all / many of those are already changed, then this is OK. > > test_begin_subtest "detected $outcount>10 abort points" > test_expect_success "test $outcount -gt 10" > -- > 2.35.1.306.ga00bde9711