From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id QMRiNPdpDWKYRgAAgWs5BA (envelope-from ) for ; Wed, 16 Feb 2022 22:17:43 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id WJfpMPdpDWIdSwAAauVa8A (envelope-from ) for ; Wed, 16 Feb 2022 22:17:43 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7539947E6F for ; Wed, 16 Feb 2022 22:17:43 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 8B84A5F709; Wed, 16 Feb 2022 21:17:41 +0000 (UTC) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [IPv6:2a0b:5c81:1c1::37]) by mail.notmuchmail.org (Postfix) with ESMTPS id CFC965F5EB for ; Wed, 16 Feb 2022 21:17:38 +0000 (UTC) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 0DFD31B00228; Wed, 16 Feb 2022 23:17:38 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1645046258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6632xU9mD+xw+otkj5D9KhYAN+PhUy1WeT/sq93Aedc=; b=hfnoUaqKZtIKBSg9yz6afCHSa1oosjXj+EWZP6a49l5F2QaNsVCppH/Xf+PR/4DaxvIrM+ lmFu6Et5Bqdbr7yEuSKIPT1TX8Edba0eZ58LgbF2qkCbCZVvhA+YuKmAVTYl/hCjfsWNXN uzD+2GLrhZLGnXa1G8Msqeqsm9AI3yEOdykHKqoA00sWl6vqLXLBJ+plchztncGJoFApF0 QRKDzrjTf1YzVz6nVBWX6SdhjbV9CN8m0ZUuitpaDrJ8sTnNF9pwieXcOtsmAzfn3zIKKf /YmgVOISV6XxBv541itqUAFKtp7jepTf301OrD3yEXlkGzOc6+oseNTNDy7z1w== From: Tomi Ollila To: Michael J Gruber , David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH] test: allow to use --full-sync In-Reply-To: <164502680299.11303.10470378844531764064.git@grubix.eu> References: <164493828675.3239.10351078681225652378.git@grubix.eu> <8ab69ee29faf9322c5ba25ac0fe320ca17f67490.1645005076.git.git@grubix.eu> <87iltft12m.fsf@tethera.net> <164502680299.11303.10470378844531764064.git@grubix.eu> User-Agent: Notmuch/0.35+4~ge2bb4cd (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1645046258; a=rsa-sha256; cv=none; b=MTFmmZcHpPS30KvGU21D8QzITacoiQqn0EH44tmlltpEjVVIWyZFSup2mI5Dstdd2pm3PH VoMUNP5m2maE5yNqCaINwob4/Te711bVipg+OC4/NpzbNULMokx6uJ01KjNaFRhguXLkKF Cgoj0e2i83ZECe4+x/ERzDW2TNDEAK3jBQJ3Zjq+PDlBkJNDgjlKTCw8ElJHdbo60n/QmS x0E+wAcjow3tGZIRAt16a+crcTjizGTTFpFNHIDdBM3tEdmt1kuvVWYmI0ZNrQGVkkUttD Iz2tTU7Uz55tZwfcpIgzWscNKryB8kLuauCP9PakQIqFxk5D9zXYS1T3dS1FfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1645046258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6632xU9mD+xw+otkj5D9KhYAN+PhUy1WeT/sq93Aedc=; b=CGOfV1I/PvQNJtEjzDAuUDmrtvHnjNammhZOBZwwQMnABUonp8749NspLxs7XZKnhaFhRR s+HGkIOs0sL2dfeAQwWEZU0LHlBlr+AIvomYCc4AvNZlzLwr+o8XTFVQNkLhYtLOK04Mab viG7AMfC6/KnOIyjqXh8bylqE6w7Gnkh9sTo+5ASRIH49/lUKR2W06pOpaGSnseq8FGzdL FhlPT8BcgYzD0HmpHTY9pgFi7EBLjSaVRiXVfzkZp5X/UkNaHAlmy2W3sj/PZD9yn1yToc 9je2PVlhY7MP+XkHDrD9LCGV7eNEPjkf2E3bjhMNL6+xu3p8N5HKFhqE/rGbgg== Message-ID-Hash: O6KOUC46EWJKGVA2MCADJVNSOC63RBPF X-Message-ID-Hash: O6KOUC46EWJKGVA2MCADJVNSOC63RBPF X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1645046263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=lT5t2YpPBcUcEocogRXtEumJuYlO56ghQKTftuWs+dY=; b=Y/xQew7CcwJ79vPQ5qjud/JckFbc8DCJRfZ8/MHBV9WpEHhiBEmmPW+rdiDXx38ZVyaGXn IKE9zJzGiS4uIGBJeYs5klfAyQIZ2zYaDZVrXdGTmccPreDUPkSITg+Z6ojmQOjxNSsWnb VIdw8p2V29SGepphUdQPfUfQKXVl6s7hKcWoovDE57aSwx53H63A4HSsXJZMuibcZ9YmWn Z8Fp7eBe8LCBQ9cld1VlAZC+TRSVStNxK9E/kkCJW2ZwYBLTRGlKig0h4Tgop08gVUyEtv j5nbdKR5bCiqKTNDc5Qs5wvVjevhYR0WSJnvPMEODchRbrpXYC0XbYz11QcsKw== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1645046263; a=rsa-sha256; cv=fail; b=LUHlr9n0NGwzjcucqDnJZj2XHrmLVcrEXFSjX7pEhjC2QGrqZ4INsBNKxlxb9mUevZp6bo /KZwu+L0NYYRGHHd+OOt42ef7cVjYMSmMd5aZ7kC9BoeLIu8EYlLyRLGTG8yBckN2pHj3L 0XqkmnizMsdrhrT0VvaxlSBdgqpcn+ODTuESMRxcnmLTb4N1ZrMRnuQV40drMFbSdMTpQ/ b4bolcCmqs8WN9ah0ChBsK9lvV6Ehs54dqXiYWeuy5Vpc2BLoTNdASDlPrsvj1zZvZEv9q MExcMRtnxbUwQ/6vymKbukp2i4MF/IJ5bHYdrbpX9Yzsx/icX4NEGd/qF9fJow== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=hfnoUaqK; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -0.35 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=hfnoUaqK; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 7539947E6F X-Spam-Score: -0.35 X-Migadu-Scanner: scn1.migadu.com X-TUID: j8uCIDciMnGj On Wed, Feb 16 2022, Michael J. Gruber wrote: > David Bremner venit, vidit, dixit 2022-02-16 14:04:17: >> Michael J Gruber writes: >> >> > Some build infrastructure appears to habe problems with mtime/stat, >> >> have > > Huh, this looks as if my mother tongue slipped in, while it's just key > proximity. > >> > leading to spurious failures (noticed on s390x and aarch64 with epel8). >> > Allow the test suite to be run with --full-sync so that release builds >> > can use the test suite while avoiding spurious failures. >> > >> > Signed-off-by: Michael J Gruber >> > --- >> > test/README | 8 ++++++++ >> > test/test-lib-common.sh | 7 ++++++- >> > test/test-lib.sh | 2 +- >> > 3 files changed, 15 insertions(+), 2 deletions(-) >> > >> > diff --git a/test/README b/test/README >> > index 10f127cb..1de79b78 100644 >> > --- a/test/README >> > +++ b/test/README >> > @@ -110,6 +110,14 @@ printed on screen. This printing can be disabled by setting the >> > NOTMUCH_TEST_QUIET variable to a non-null value. Message on test >> > failures and skips are still printed. >> >> typo in variable name. > > Not here, but in fact in the actual patch ;) > > >> How confident are you that this actually fixes your intermittent >> failures? There are quite a few literal invocations of "notmuch new" in >> the test suite. Would those need to be changed as well? > > About 80% confident ... The patch covers all areas in which I've ever > witnessed the spurious FAILs. I have not had a single failure with the > patch. Many of the other invocations are not immediately after message > creation. > > Some of them are immediately after, and - given that notmuch new catches > the case of same time - I do not understand why this happens at all. > That accounts for the other 20%. > > I don't mind carrying this locally and retrying without for the next > round of notmuch updates. Having the patch here on-list may help > someone else in the future in any case. I'd not merge this NOTMUCH_NEW_OPTIONS=--full-scan ;D too eagerly ... I'd like we really knew the reason (which is then written in commit message) > > Michael Tomi