[PATCH] emacs: Allow headers to be shown by default in show mode

[PATCH] emacs: Allow headers to be shown by default in show mode

[David Edmondson]

Add `notmuch-show-headers-visible' which, when set `t', causes headers
to be shown by default.
---
 emacs/notmuch-show.el |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index cd859f0..3ea07c8 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -42,6 +42,11 @@
 that if this order is changed the headers shown when a message is
 collapsed will change.")
 
+(defcustom notmuch-show-headers-visible nil
+  "Should the headers be visible by default?"
+  :group 'notmuch
+  :type 'boolean)
+
 (defvar notmuch-show-markup-headers-hook '(notmuch-show-colour-headers)
   "A list of functions called to decorate the headers listed in
 `notmuch-show-headers'.")
@@ -433,8 +438,8 @@ current buffer, if possible."
     ;; the content).
     (notmuch-show-set-message-properties msg)
 
-    ;; Headers are hidden by default.
-    (notmuch-show-headers-visible msg nil)
+    ;; Set header visibility.
+    (notmuch-show-headers-visible msg notmuch-show-headers-visible)
 
     ;; Message visibility depends on whether it matched the search
     ;; criteria.
-- 
1.7.0

Re: [PATCH] emacs: Allow headers to be shown by default in show mode

[Dirk Hohndel]

On Fri, 23 Apr 2010 12:54:21 +0100, David Edmondson <dme@dme.org> wrote:
> Add `notmuch-show-headers-visible' which, when set `t', causes headers
> to be shown by default.

Excellent - Carl, can you pull this into 0.3, please?

/D

-- 
Dirk Hohndel
Intel Open Source Technology Center

Re: [PATCH] emacs: Allow headers to be shown by default in show mode

[Jameson Rollins]

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

On Fri, 23 Apr 2010 10:13:37 -0700, Dirk Hohndel <hohndel@infradead.org> wrote:
> On Fri, 23 Apr 2010 12:54:21 +0100, David Edmondson <dme@dme.org> wrote:
> > Add `notmuch-show-headers-visible' which, when set `t', causes headers
> > to be shown by default.
> 
> Excellent - Carl, can you pull this into 0.3, please?

Agreed.  Again, thanks so much David.  This is exactly what I wanted.
Tested and ...

Approved-By: Jameson Rollins <jrollins@finestructure.net>

jamie.

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

Re: [PATCH] emacs: Allow headers to be shown by default in show mode

[Servilio Afre Puentes]

On 23 April 2010 13:13, Dirk Hohndel <hohndel@infradead.org> wrote:
> On Fri, 23 Apr 2010 12:54:21 +0100, David Edmondson <dme@dme.org> wrote:
>> Add `notmuch-show-headers-visible' which, when set `t', causes headers
>> to be shown by default.
>
> Excellent - Carl, can you pull this into 0.3, please?

+1

Servilio

Re: [PATCH] emacs: Allow headers to be shown by default in show mode

[Carl Worth]

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

On Fri, 23 Apr 2010 12:54:21 +0100, David Edmondson <dme@dme.org> wrote:
> Add `notmuch-show-headers-visible' which, when set `t', causes headers
> to be shown by default.

A nice improvement, definitely. But I don't hear anyone actually wanting
a configuration value here.

Would anyone complain if I just made these all visible by default?

Would anyone complain if I removed the code to allow for th hiding of
the header?

That's what I'm inclined to do.

Let me know.

-Carl

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] emacs: Allow headers to be shown by default in show mode

[Jameson Rollins]

[-- Attachment #1: Type: text/plain, Size: 730 bytes --]

On Fri, 23 Apr 2010 12:26:43 -0700, Carl Worth <cworth@cworth.org> wrote:
> A nice improvement, definitely. But I don't hear anyone actually wanting
> a configuration value here.
> 
> Would anyone complain if I just made these all visible by default?
> 
> Would anyone complain if I removed the code to allow for th hiding of
> the header?

Oh yeah that makes much more sense to me.  I definitely don't want the
headers hidden, so not having a config value for it certainly works for
me.  I just assumed that the header hiding was implemented because some
people wanted it.  If no one really wants to hide headers, then I would
definitely vote for just removing all of that code and just displaying
them.

jamie.

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

Re: [PATCH] emacs: Allow headers to be shown by default in show mode

[David Edmondson]

I like the current behaviour, but changing the default would be fine.

On Friday, April 23, 2010, Carl Worth <cworth@cworth.org> wrote:
> On Fri, 23 Apr 2010 12:54:21 +0100, David Edmondson <dme@dme.org> wrote:
>> Add `notmuch-show-headers-visible' which, when set `t', causes headers
>> to be shown by default.
>
> A nice improvement, definitely. But I don't hear anyone actually wanting
> a configuration value here.
>
> Would anyone complain if I just made these all visible by default?
>
> Would anyone complain if I removed the code to allow for th hiding of
> the header?
>
> That's what I'm inclined to do.
>
> Let me know.
>
> -Carl
>

Re: [PATCH] emacs: Allow headers to be shown by default in show mode

[Carl Worth]

[-- Attachment #1: Type: text/plain, Size: 619 bytes --]

On Fri, 23 Apr 2010 21:08:48 +0100, David Edmondson <dme@dme.org> wrote:
> I like the current behaviour, but changing the default would be fine.

Which parts of it do you like? Being able to toggle the header back and
forth? Or just that the hidden headers take up so little vertical space?

I think that I would personally like to have the To and Cc headers
visible always. But having From and Date visible as separate rows is
redundant with our current summary bar, (well, Date isn't precisely
redundant).

I think I'll accept the patch, change the default, then remove From from
the list of headers inserted.

-Carl

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] emacs: Allow headers to be shown by default in show mode

[Carl Worth]

[-- Attachment #1: Type: text/plain, Size: 894 bytes --]

On Sat, 24 Apr 2010 05:42:54 -0700, Carl Worth <cworth@cworth.org> wrote:
> I think I'll accept the patch, change the default, then remove From from
> the list of headers inserted.

I've done this now.

I've also exported the list of headers to display as another nice
customizable option in "M-x customize-group" "notmuch".

For myself, I removed "Date" from that list too. That gives me a very
compact display without hiding too much information.

I didn't do that by default because several people recently said they'd
prefer to see the actual date rather than the relative date that's in
the summary line. I suppose another possibility would be to remove the
Date header by default and provide an option to display the actual date
in the summary-line instead of the relative date.

Someone that wants that could do that to get one more line of message
content per message displayed.

-Carl

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] emacs: Allow headers to be shown by default in show mode

[David Edmondson]

On Sat, 24 Apr 2010 05:42:54 -0700, Carl Worth <cworth@cworth.org> wrote:
> On Fri, 23 Apr 2010 21:08:48 +0100, David Edmondson <dme@dme.org> wrote:
> > I like the current behaviour, but changing the default would be fine.
> 
> Which parts of it do you like? Being able to toggle the header back and
> forth? Or just that the hidden headers take up so little vertical
> space?

Both, particularly that the headers can be hidden by default. Mostly I
care about what you have to say and who you are, not who you said it to.

dme.
-- 
David Edmondson, http://dme.org

Re: [PATCH] emacs: Allow headers to be shown by default in show mode

[Dirk Hohndel]

On Mon, 26 Apr 2010 11:55:33 +0100, David Edmondson <dme@dme.org> wrote:
> On Sat, 24 Apr 2010 05:42:54 -0700, Carl Worth <cworth@cworth.org> wrote:
> > On Fri, 23 Apr 2010 21:08:48 +0100, David Edmondson <dme@dme.org> wrote:
> > > I like the current behaviour, but changing the default would be fine.
> > 
> > Which parts of it do you like? Being able to toggle the header back and
> > forth? Or just that the hidden headers take up so little vertical
> > space?
> 
> Both, particularly that the headers can be hidden by default. Mostly I
> care about what you have to say and who you are, not who you said it to.

I think that this is something where we really need a customization - as
my preference is the exact opposite of David's. Since I get email from
so many people it really helps me to understand the context (and who
else an email was sent to) when browsing through mail...

/D

-- 
Dirk Hohndel
Intel Open Source Technology Center