From: Jan Janak <jan@ryngle.com>
To: Carl Worth <cworth@cworth.org>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] notmuch-new: Eliminate gcc warning caused by ino_cmp.
Date: Mon, 23 Nov 2009 03:47:24 +0100 [thread overview]
Message-ID: <f35dbb950911221847h6afa4bd4n9a634426613fed5d@mail.gmail.com> (raw)
In-Reply-To: <876392ge3i.fsf@yoom.home.cworth.org>
On Mon, Nov 23, 2009 at 3:38 AM, Carl Worth <cworth@cworth.org> wrote:
> On Sun, 22 Nov 2009 13:32:36 +0100, Jan Janak <jan@ryngle.com> wrote:
>> The function passed to scandir in the fourth argument takes two
>> const void* arguments. To eliminate the gcc warning about incompatible
>> types, we change ino_cmp to match this and then re-type the parameters
>> in the body of ino_cmp.
>
> Actually, on my system at least, (Linux with glibc 2.10.1), our current
> function matches the prototype. So applying your patch actually
> *introduces* a warning where there was no warning before.
>
> What a nuisance...
>
> Any ideas for a good fix, anyone?
OK, I have an older version of glibc. If the original code works with
glibc 2.10 then just ignore the patch. I think testing for a
particular version of glibc is not worth the effort (it's just a
warning anyway).
-- Jan
prev parent reply other threads:[~2009-11-23 2:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-22 12:32 [PATCH] notmuch-new: Eliminate gcc warning caused by ino_cmp Jan Janak
2009-11-23 2:38 ` Carl Worth
2009-11-23 2:47 ` Jan Janak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f35dbb950911221847h6afa4bd4n9a634426613fed5d@mail.gmail.com \
--to=jan@ryngle.com \
--cc=cworth@cworth.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).