unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* Why is no. of files from count_files reset to 0?
@ 2009-11-18 14:36 Jan Janak
  2009-11-18 23:29 ` Carl Worth
  0 siblings, 1 reply; 2+ messages in thread
From: Jan Janak @ 2009-11-18 14:36 UTC (permalink / raw)
  To: notmuch

Hello,

The function count_file returns the total number of files to be
processed, the result is then stored in add_files_state.total_files.
But that variable is reset back to 0 in notmuch_new_command.

When I comment out the following line (before add_files is called):

add_files_state.total_files = 0;

The progress indicator shows the total number of files to be
processed, as well as the time remaining. This is, IMHO, much better,
especially if you process a large collection of emails.

Is there any reason for having the variable reset to 0 before calling
add_files? Thanks!

   -- Jan

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Why is no. of files from count_files reset to 0?
  2009-11-18 14:36 Why is no. of files from count_files reset to 0? Jan Janak
@ 2009-11-18 23:29 ` Carl Worth
  0 siblings, 0 replies; 2+ messages in thread
From: Carl Worth @ 2009-11-18 23:29 UTC (permalink / raw)
  To: Jan Janak, notmuch

On Wed, 18 Nov 2009 15:36:51 +0100, Jan Janak <jan@ryngle.com> wrote:
> When I comment out the following line (before add_files is called):
> 
> add_files_state.total_files = 0;
> 
> The progress indicator shows the total number of files to be
> processed, as well as the time remaining. This is, IMHO, much better,
> especially if you process a large collection of emails.
> 
> Is there any reason for having the variable reset to 0 before calling
> add_files? Thanks!

Just a bug. Thanks for pointing this out. It's fixed now---and it will
be nice for new users to have the countdown working once again.

-Carl

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-11-18 23:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-18 14:36 Why is no. of files from count_files reset to 0? Jan Janak
2009-11-18 23:29 ` Carl Worth

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).