unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: "W. Trevor King" <wking@tremily.us>
To: notmuch@notmuchmail.org
Subject: [PATCH 16/17] nmbug-status: Use <code> and <p> markup where appropriate
Date: Mon,  3 Feb 2014 02:59:34 -0800	[thread overview]
Message-ID: <ec1176e5bde52c91869640e71535b0e35d9ef614.1391424512.git.wking@tremily.us> (raw)
In-Reply-To: <cover.1391424512.git.wking@tremily.us>
In-Reply-To: <cover.1391424512.git.wking@tremily.us>

* Wrap free text in <p> tags.
* Convert <blockquote> to <p><code> for query strings.
* Wrap message-id-term (id:"...") in <code>.

The <code> tags get nicer default markup (smaller monospace font) for
notmuch query terms [1].  The <p> tags don't have much effect without
attached CSS, but bare text (phrasing content [2]) in <body> (which
expects flow content [3,4]) feels wrong.

[1]: http://www.w3.org/TR/html5/text-level-semantics.html#the-code-element
[2]: http://www.w3.org/TR/html5/dom.html#phrasing-content-1
[3]: http://www.w3.org/TR/html5/dom.html#flow-content-1
[4]: http://www.w3.org/TR/html5/sections.html#the-body-element
---
 devel/nmbug/nmbug-status | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/devel/nmbug/nmbug-status b/devel/nmbug/nmbug-status
index 9bdb34f..21fb481 100755
--- a/devel/nmbug/nmbug-status
+++ b/devel/nmbug/nmbug-status
@@ -162,14 +162,18 @@ class HtmlPage (Page):
 
     def _write_view_header(self, view, stream):
         stream.write('<h3 id="{id}">{title}</h3>\n'.format(**view))
+        stream.write('<p>\n')
         if 'comment' in view:
             stream.write(view['comment'])
             stream.write('\n')
         for line in [
                 'The view is generated from the following query:',
-                '<blockquote>',
+                '</p>',
+                '<p>',
+                '  <code>',
                 view['query-string'],
-                '</blockquote>',
+                '  </code>',
+                '</p>',
                 ]:
             stream.write(line)
             stream.write('\n')
@@ -183,7 +187,7 @@ class HtmlPage (Page):
                 stream.write((
                     '<tr>\n'
                     '  <td>{date}</td>\n'
-                    '  <td>{message-id-term}</td>\n'
+                    '  <td><code>{message-id-term}</code></td>\n'
                     '</tr>\n'
                     '<tr>\n'
                     '  <td>{from}</td>\n'
@@ -219,8 +223,10 @@ _PAGES['html'] = HtmlPage(
 </head>
 <body>
 <h2>Notmuch Patches</h2>
+<p>
 Generated: {date}<br />
 For more infomation see <a href="http://notmuchmail.org/nmbug">nmbug</a>
+</p>
 <h3>Views</h3>
 '''.format(date=datetime.datetime.utcnow().date(),
            encoding=_ENCODING),
-- 
1.8.5.2.8.g0f6c0d1

  parent reply	other threads:[~2014-02-03 11:03 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-03 10:59 [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring W. Trevor King
2014-02-03 10:59 ` [PATCH 01/17] nmbug-status: Convert to Python-3-compatible print functions W. Trevor King
2014-02-03 10:59 ` [PATCH 02/17] nmbug-status: Use email.utils instead of rfc822 W. Trevor King
2014-02-03 10:59 ` [PATCH 03/17] nmbug-status: Decode Popen output using the user's locale W. Trevor King
2014-02-03 10:59 ` [PATCH 04/17] nmbug-status: Factor config-loading out into read_config W. Trevor King
2014-02-03 10:59 ` [PATCH 05/17] nmbug-status: Add metavars for --config and --get-query W. Trevor King
2014-02-03 10:59 ` [PATCH 06/17] nmbug-status: Consolidate functions and main code W. Trevor King
2014-02-03 10:59 ` [PATCH 07/17] nmbug-status: Don't require write access W. Trevor King
2014-02-03 10:59 ` [PATCH 08/17] nmbug-status: Consolidate HTML header printing W. Trevor King
2014-02-03 10:59 ` [PATCH 09/17] nmbug-status: Add a Python-3-compatible urllib.parse.quote import W. Trevor King
2014-02-03 10:59 ` [PATCH 10/17] nmbug-status: Add Page and HtmlPage for modular rendering W. Trevor King
2014-02-03 10:59 ` [PATCH 11/17] nmbug-status: Normalize table HTML indentation W. Trevor King
2014-02-03 10:59 ` [PATCH 12/17] nmbug-status: Convert from XHTML 1.0 to HTML 5 W. Trevor King
2014-02-03 10:59 ` [PATCH 13/17] nmbug-status: Encode output using the user's locale W. Trevor King
2014-02-03 10:59 ` [PATCH 14/17] nmbug-status: Anchor with h3 ids instead of a names W. Trevor King
2014-02-03 10:59 ` [PATCH 15/17] nmbug-status: Quote the title when using it as an id W. Trevor King
2014-02-08 23:18   ` W. Trevor King
2014-02-09  9:34     ` Tomi Ollila
2014-02-03 10:59 ` W. Trevor King [this message]
2014-02-03 10:59 ` [PATCH 17/17] nmbug-status: Color threads in HTML output W. Trevor King
2014-02-03 21:10 ` [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring Tomi Ollila
2014-02-04  0:53   ` W. Trevor King
2014-02-04 10:30     ` Tomi Ollila
2014-02-04 13:07       ` David Bremner
2014-02-04 15:50         ` W. Trevor King
2014-02-04 17:39           ` W. Trevor King
2014-02-04 16:11       ` W. Trevor King
2014-02-04 18:40         ` Tomi Ollila
2014-02-04 19:14           ` W. Trevor King
2014-02-04 20:06             ` Tomi Ollila
2014-02-05 15:00               ` Tomi Ollila
2014-02-05 15:24                 ` Tomi Ollila
2014-02-05 15:31                   ` W. Trevor King
2014-02-07 22:15                     ` W. Trevor King
2014-02-05 15:27                 ` W. Trevor King
2014-02-05 22:54                   ` Tomi Ollila
2014-02-06 18:14                     ` W. Trevor King
2014-02-08 16:11                       ` David Bremner
     [not found]                       ` <87ob2hogkr.fsf@zancas.localnet>
2014-02-08 17:16                         ` W. Trevor King
2014-02-08 18:29                           ` Tomi Ollila
2014-02-08 19:09                             ` W. Trevor King
2014-02-08 19:37                               ` Tomi Ollila
2014-02-08 22:19                                 ` W. Trevor King
2014-02-04 17:48       ` W. Trevor King
2014-02-04 18:34         ` Tomi Ollila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec1176e5bde52c91869640e71535b0e35d9ef614.1391424512.git.wking@tremily.us \
    --to=wking@tremily.us \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).